[INFO] updating cached repository stevebob/belt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevebob/belt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/belt" "work/ex/clippy-test-run/sources/stable/gh/stevebob/belt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevebob/belt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevebob/belt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/belt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/belt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e606988c7e432f81dfdb2a21d1376315cdd6cf52 [INFO] sha for GitHub repo stevebob/belt: e606988c7e432f81dfdb2a21d1376315cdd6cf52 [INFO] validating manifest of stevebob/belt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevebob/belt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevebob/belt [INFO] finished frobbing stevebob/belt [INFO] frobbed toml for stevebob/belt written to work/ex/clippy-test-run/sources/stable/gh/stevebob/belt/Cargo.toml [INFO] started frobbing stevebob/belt [INFO] finished frobbing stevebob/belt [INFO] frobbed toml for stevebob/belt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevebob/belt/Cargo.toml [INFO] crate stevebob/belt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevebob/belt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stevebob/belt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba6c848e577991f7484f4cc1c48b4a6d229f5d035b0f014ad5a57d862ad3a078 [INFO] running `"docker" "start" "-a" "ba6c848e577991f7484f4cc1c48b4a6d229f5d035b0f014ad5a57d862ad3a078"` [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.15.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking gilrs v0.6.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.13.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_window_glutin v0.23.0 [INFO] [stderr] Checking belt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `graphics` [INFO] [stderr] --> src/main.rs:850:5 [INFO] [stderr] | [INFO] [stderr] 850 | graphics: &'a Graphics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:58 [INFO] [stderr] | [INFO] [stderr] 99 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:58 [INFO] [stderr] | [INFO] [stderr] 198 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:37 [INFO] [stderr] | [INFO] [stderr] 322 | output_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:58 [INFO] [stderr] | [INFO] [stderr] 322 | output_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `graphics` [INFO] [stderr] --> src/main.rs:850:5 [INFO] [stderr] | [INFO] [stderr] 850 | graphics: &'a Graphics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:445:37 [INFO] [stderr] | [INFO] [stderr] 445 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:445:58 [INFO] [stderr] | [INFO] [stderr] 445 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:483:36 [INFO] [stderr] | [INFO] [stderr] 483 | writer.is_player = (to_render.is_player as u8) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((to_render.is_player as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:572:37 [INFO] [stderr] | [INFO] [stderr] 572 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 573 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 574 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 575 | | external_event = Some(ExternalEvent::Quit); [INFO] [stderr] ... | [INFO] [stderr] 609 | | _ => (), [INFO] [stderr] 610 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 572 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 573 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 574 | external_event = Some(ExternalEvent::Quit); [INFO] [stderr] 575 | } [INFO] [stderr] 576 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 577 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:705:9 [INFO] [stderr] | [INFO] [stderr] 705 | / match update_input_model(&mut input_model, &mut events_loop, &mut gilrs) { [INFO] [stderr] 706 | | Some(ExternalEvent::Quit) => break, [INFO] [stderr] 707 | | None => (), [INFO] [stderr] 708 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ExternalEvent::Quit) = update_input_model(&mut input_model, &mut events_loop, &mut gilrs) { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GameState` [INFO] [stderr] --> src/main.rs:855:5 [INFO] [stderr] | [INFO] [stderr] 855 | / pub fn new() -> Self { [INFO] [stderr] 856 | | let mut entity_id_allocator = EntityIdAllocator::default(); [INFO] [stderr] 857 | | let player_id = entity_id_allocator.allocate(); [INFO] [stderr] 858 | | let mut game_state = Self { [INFO] [stderr] ... | [INFO] [stderr] 900 | | game_state [INFO] [stderr] 901 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 836 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:58 [INFO] [stderr] | [INFO] [stderr] 99 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:37 [INFO] [stderr] | [INFO] [stderr] 198 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:58 [INFO] [stderr] | [INFO] [stderr] 198 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:37 [INFO] [stderr] | [INFO] [stderr] 322 | output_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:322:58 [INFO] [stderr] | [INFO] [stderr] 322 | output_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:445:37 [INFO] [stderr] | [INFO] [stderr] 445 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:445:58 [INFO] [stderr] | [INFO] [stderr] 445 | window_size_in_pixels: [window_width as f32, window_height as f32], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(window_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:483:36 [INFO] [stderr] | [INFO] [stderr] 483 | writer.is_player = (to_render.is_player as u8) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((to_render.is_player as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:572:37 [INFO] [stderr] | [INFO] [stderr] 572 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 573 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 574 | | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 575 | | external_event = Some(ExternalEvent::Quit); [INFO] [stderr] ... | [INFO] [stderr] 609 | | _ => (), [INFO] [stderr] 610 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 572 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 573 | glutin::WindowEvent::CloseRequested => { [INFO] [stderr] 574 | external_event = Some(ExternalEvent::Quit); [INFO] [stderr] 575 | } [INFO] [stderr] 576 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 577 | if let Some(virtual_keycode) = input.virtual_keycode { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:705:9 [INFO] [stderr] | [INFO] [stderr] 705 | / match update_input_model(&mut input_model, &mut events_loop, &mut gilrs) { [INFO] [stderr] 706 | | Some(ExternalEvent::Quit) => break, [INFO] [stderr] 707 | | None => (), [INFO] [stderr] 708 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ExternalEvent::Quit) = update_input_model(&mut input_model, &mut events_loop, &mut gilrs) { break }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GameState` [INFO] [stderr] --> src/main.rs:855:5 [INFO] [stderr] | [INFO] [stderr] 855 | / pub fn new() -> Self { [INFO] [stderr] 856 | | let mut entity_id_allocator = EntityIdAllocator::default(); [INFO] [stderr] 857 | | let player_id = entity_id_allocator.allocate(); [INFO] [stderr] 858 | | let mut game_state = Self { [INFO] [stderr] ... | [INFO] [stderr] 900 | | game_state [INFO] [stderr] 901 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 836 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 13s [INFO] running `"docker" "inspect" "ba6c848e577991f7484f4cc1c48b4a6d229f5d035b0f014ad5a57d862ad3a078"` [INFO] running `"docker" "rm" "-f" "ba6c848e577991f7484f4cc1c48b4a6d229f5d035b0f014ad5a57d862ad3a078"` [INFO] [stdout] ba6c848e577991f7484f4cc1c48b4a6d229f5d035b0f014ad5a57d862ad3a078