[INFO] updating cached repository steamroller-airmash/statsbot-log-tools-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/steamroller-airmash/statsbot-log-tools-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/steamroller-airmash/statsbot-log-tools-rs" "work/ex/clippy-test-run/sources/stable/gh/steamroller-airmash/statsbot-log-tools-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/steamroller-airmash/statsbot-log-tools-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/steamroller-airmash/statsbot-log-tools-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steamroller-airmash/statsbot-log-tools-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steamroller-airmash/statsbot-log-tools-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] efd1c112242056d37f68a8c403c2612e854f2bd6
[INFO] sha for GitHub repo steamroller-airmash/statsbot-log-tools-rs: efd1c112242056d37f68a8c403c2612e854f2bd6
[INFO] validating manifest of steamroller-airmash/statsbot-log-tools-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of steamroller-airmash/statsbot-log-tools-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing steamroller-airmash/statsbot-log-tools-rs
[INFO] finished frobbing steamroller-airmash/statsbot-log-tools-rs
[INFO] frobbed toml for steamroller-airmash/statsbot-log-tools-rs written to work/ex/clippy-test-run/sources/stable/gh/steamroller-airmash/statsbot-log-tools-rs/Cargo.toml
[INFO] started frobbing steamroller-airmash/statsbot-log-tools-rs
[INFO] finished frobbing steamroller-airmash/statsbot-log-tools-rs
[INFO] frobbed toml for steamroller-airmash/statsbot-log-tools-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steamroller-airmash/statsbot-log-tools-rs/Cargo.toml
[INFO] crate steamroller-airmash/statsbot-log-tools-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting steamroller-airmash/statsbot-log-tools-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/steamroller-airmash/statsbot-log-tools-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 830ac7c7600319978eed4205a07703d29ea2fa5cfd272304a3d2945227e78372
[INFO] running `"docker" "start" "-a" "830ac7c7600319978eed4205a07703d29ea2fa5cfd272304a3d2945227e78372"`
[INFO] [stderr]     Checking ucd-util v0.1.2
[INFO] [stderr]     Checking regex-syntax v0.5.6
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking statslib v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:71:2
[INFO] [stderr]    |
[INFO] [stderr] 71 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:84:2
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return Ok(val);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:103:2
[INFO] [stderr]     |
[INFO] [stderr] 103 |     return Ok(values);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(values)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:131:2
[INFO] [stderr]     |
[INFO] [stderr] 131 |     return Ok((name, value));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((name, value))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:162:2
[INFO] [stderr]     |
[INFO] [stderr] 162 |     return parse_record(&mut it);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_record(&mut it)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:179:2
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return Ok(record);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(record)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/writer.rs:15:2
[INFO] [stderr]    |
[INFO] [stderr] 15 |       return match v {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 16 | |         &RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 | |         &RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 | |         &RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 | |         &RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr] 20 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 15 |     match v {
[INFO] [stderr] 16 |         &RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 |         &RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 |         &RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 |         &RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr] 20 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/time.rs:24:2
[INFO] [stderr]    |
[INFO] [stderr] 24 |       return Some(Utc.ymd(
[INFO] [stderr]    |  _____^
[INFO] [stderr] 25 | |             vals[0] as i32,
[INFO] [stderr] 26 | |             vals[1],
[INFO] [stderr] 27 | |             vals[2])
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |             vals[5],
[INFO] [stderr] 32 | |             vals[6]));
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 24 |     Some(Utc.ymd(
[INFO] [stderr] 25 |             vals[0] as i32,
[INFO] [stderr] 26 |             vals[1],
[INFO] [stderr] 27 |             vals[2])
[INFO] [stderr] 28 |         .and_hms_milli(
[INFO] [stderr] 29 |             vals[3],
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lexer.rs:71:2
[INFO] [stderr]    |
[INFO] [stderr] 71 |     return tokens;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:84:2
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return Ok(val);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(val)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:103:2
[INFO] [stderr]     |
[INFO] [stderr] 103 |     return Ok(values);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(values)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:131:2
[INFO] [stderr]     |
[INFO] [stderr] 131 |     return Ok((name, value));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((name, value))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:162:2
[INFO] [stderr]     |
[INFO] [stderr] 162 |     return parse_record(&mut it);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_record(&mut it)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:179:2
[INFO] [stderr]     |
[INFO] [stderr] 179 |     return Ok(record);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(record)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/writer.rs:15:2
[INFO] [stderr]    |
[INFO] [stderr] 15 |       return match v {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 16 | |         &RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 | |         &RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 | |         &RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 | |         &RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr] 20 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 15 |     match v {
[INFO] [stderr] 16 |         &RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 |         &RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 |         &RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 |         &RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr] 20 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/time.rs:24:2
[INFO] [stderr]    |
[INFO] [stderr] 24 |       return Some(Utc.ymd(
[INFO] [stderr]    |  _____^
[INFO] [stderr] 25 | |             vals[0] as i32,
[INFO] [stderr] 26 | |             vals[1],
[INFO] [stderr] 27 | |             vals[2])
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |             vals[5],
[INFO] [stderr] 32 | |             vals[6]));
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 24 |     Some(Utc.ymd(
[INFO] [stderr] 25 |             vals[0] as i32,
[INFO] [stderr] 26 |             vals[1],
[INFO] [stderr] 27 |             vals[2])
[INFO] [stderr] 28 |         .and_hms_milli(
[INFO] [stderr] 29 |             vals[3],
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/parser.rs:70:1
[INFO] [stderr]    |
[INFO] [stderr] 70 | / fn parse_string<'a>(s: &'a str) -> RecordValue<'a> {
[INFO] [stderr] 71 | |     RecordValue::Str(s)
[INFO] [stderr] 72 | | } 
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:160:1
[INFO] [stderr]     |
[INFO] [stderr] 160 | / pub fn parse_noreplace<'a>(s: &'a str) -> Result<Record<'a>, ParseError> {
[INFO] [stderr] 161 | |     let mut it = TokenIterator::new(lex(s).into_iter());
[INFO] [stderr] 162 | |     return parse_record(&mut it);
[INFO] [stderr] 163 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:165:1
[INFO] [stderr]     |
[INFO] [stderr] 165 | / pub fn parse<'a>(s: &'a str) -> Result<Record<'a>, ParseError> {
[INFO] [stderr] 166 | |     let mut record = try!(parse_noreplace(s));
[INFO] [stderr] 167 | |
[INFO] [stderr] 168 | |     if record.tag == "PACKET" && record.entries.contains_key("c") {
[INFO] [stderr] ...   |
[INFO] [stderr] 179 | |     return Ok(record);
[INFO] [stderr] 180 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/writer.rs:7:23
[INFO] [stderr]   |
[INFO] [stderr] 7 | fn write_array<'a>(v: &Vec<RecordValue<'a>>) -> String {
[INFO] [stderr]   |                       ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RecordValue<'a>]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/writer.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |       return match v {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 16 | |         &RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 | |         &RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 | |         &RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 | |         &RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr] 20 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return match *v {
[INFO] [stderr] 16 |         RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 |         RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 |         RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 |         RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/time.rs:8:10
[INFO] [stderr]   |
[INFO] [stderr] 8 |         .split(":")
[INFO] [stderr]   |                ^^^ help: try using a char instead: `':'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/parser.rs:70:1
[INFO] [stderr]    |
[INFO] [stderr] 70 | / fn parse_string<'a>(s: &'a str) -> RecordValue<'a> {
[INFO] [stderr] 71 | |     RecordValue::Str(s)
[INFO] [stderr] 72 | | } 
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:160:1
[INFO] [stderr]     |
[INFO] [stderr] 160 | / pub fn parse_noreplace<'a>(s: &'a str) -> Result<Record<'a>, ParseError> {
[INFO] [stderr] 161 | |     let mut it = TokenIterator::new(lex(s).into_iter());
[INFO] [stderr] 162 | |     return parse_record(&mut it);
[INFO] [stderr] 163 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:165:1
[INFO] [stderr]     |
[INFO] [stderr] 165 | / pub fn parse<'a>(s: &'a str) -> Result<Record<'a>, ParseError> {
[INFO] [stderr] 166 | |     let mut record = try!(parse_noreplace(s));
[INFO] [stderr] 167 | |
[INFO] [stderr] 168 | |     if record.tag == "PACKET" && record.entries.contains_key("c") {
[INFO] [stderr] ...   |
[INFO] [stderr] 179 | |     return Ok(record);
[INFO] [stderr] 180 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/writer.rs:7:23
[INFO] [stderr]   |
[INFO] [stderr] 7 | fn write_array<'a>(v: &Vec<RecordValue<'a>>) -> String {
[INFO] [stderr]   |                       ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RecordValue<'a>]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/writer.rs:15:9
[INFO] [stderr]    |
[INFO] [stderr] 15 |       return match v {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 16 | |         &RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 | |         &RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 | |         &RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 | |         &RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr] 20 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return match *v {
[INFO] [stderr] 16 |         RecordValue::Int(v) => v.to_string(),
[INFO] [stderr] 17 |         RecordValue::Num(v) => v.to_string(),
[INFO] [stderr] 18 |         RecordValue::Str(v) => format!("\"{}\"", v),
[INFO] [stderr] 19 |         RecordValue::Array(ref arr) => write_array(arr)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/time.rs:8:10
[INFO] [stderr]   |
[INFO] [stderr] 8 |         .split(":")
[INFO] [stderr]   |                ^^^ help: try using a char instead: `':'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/anonymise.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 | const ANON_NAME: &'static str = "ANON_PLAYER";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/bin/avgping.rs:44:4
[INFO] [stderr]    |
[INFO] [stderr] 44 |               if !pings.contains_key(&id) {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 45 | |                 pings.insert(id, (ping, 1));
[INFO] [stderr] 46 | |             }
[INFO] [stderr] 47 | |             else {
[INFO] [stderr] 48 | |                 (*pings.get_mut(&id).unwrap()).0 += ping;
[INFO] [stderr] 49 | |                 (*pings.get_mut(&id).unwrap()).1 += 1;
[INFO] [stderr] 50 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `pings.entry(id)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/bin/killers.rs:67:4
[INFO] [stderr]    |
[INFO] [stderr] 67 |               if killers.contains_key(&killer) {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 68 | |                 *killers.get_mut(&killer).unwrap() += 1;
[INFO] [stderr] 69 | |             }
[INFO] [stderr] 70 | |             else {
[INFO] [stderr] 71 | |                 killers.insert(killer, 1);
[INFO] [stderr] 72 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `killers.entry(killer)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/anonymise.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 | const ANON_NAME: &'static str = "ANON_PLAYER";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/bin/killers.rs:67:4
[INFO] [stderr]    |
[INFO] [stderr] 67 |               if killers.contains_key(&killer) {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 68 | |                 *killers.get_mut(&killer).unwrap() += 1;
[INFO] [stderr] 69 | |             }
[INFO] [stderr] 70 | |             else {
[INFO] [stderr] 71 | |                 killers.insert(killer, 1);
[INFO] [stderr] 72 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `killers.entry(killer)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/bin/avgping.rs:44:4
[INFO] [stderr]    |
[INFO] [stderr] 44 |               if !pings.contains_key(&id) {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 45 | |                 pings.insert(id, (ping, 1));
[INFO] [stderr] 46 | |             }
[INFO] [stderr] 47 | |             else {
[INFO] [stderr] 48 | |                 (*pings.get_mut(&id).unwrap()).0 += ping;
[INFO] [stderr] 49 | |                 (*pings.get_mut(&id).unwrap()).1 += 1;
[INFO] [stderr] 50 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `pings.entry(id)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.30s
[INFO] running `"docker" "inspect" "830ac7c7600319978eed4205a07703d29ea2fa5cfd272304a3d2945227e78372"`
[INFO] running `"docker" "rm" "-f" "830ac7c7600319978eed4205a07703d29ea2fa5cfd272304a3d2945227e78372"`
[INFO] [stdout] 830ac7c7600319978eed4205a07703d29ea2fa5cfd272304a3d2945227e78372