[INFO] updating cached repository starrtnow/mcts-connect-four
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/starrtnow/mcts-connect-four
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/starrtnow/mcts-connect-four" "work/ex/clippy-test-run/sources/stable/gh/starrtnow/mcts-connect-four"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/starrtnow/mcts-connect-four'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/starrtnow/mcts-connect-four" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/starrtnow/mcts-connect-four"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/starrtnow/mcts-connect-four'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 463ec5ceebff5936c0b2e77abf138dab9a80ab20
[INFO] sha for GitHub repo starrtnow/mcts-connect-four: 463ec5ceebff5936c0b2e77abf138dab9a80ab20
[INFO] validating manifest of starrtnow/mcts-connect-four on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of starrtnow/mcts-connect-four on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing starrtnow/mcts-connect-four
[INFO] finished frobbing starrtnow/mcts-connect-four
[INFO] frobbed toml for starrtnow/mcts-connect-four written to work/ex/clippy-test-run/sources/stable/gh/starrtnow/mcts-connect-four/Cargo.toml
[INFO] started frobbing starrtnow/mcts-connect-four
[INFO] finished frobbing starrtnow/mcts-connect-four
[INFO] frobbed toml for starrtnow/mcts-connect-four written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/starrtnow/mcts-connect-four/Cargo.toml
[INFO] crate starrtnow/mcts-connect-four has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting starrtnow/mcts-connect-four against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/starrtnow/mcts-connect-four:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 079c56237647cb7ee7401231f3a0e307f611abf1f26003a472e1f0f2520a5fe1
[INFO] running `"docker" "start" "-a" "079c56237647cb7ee7401231f3a0e307f611abf1f26003a472e1f0f2520a5fe1"`
[INFO] [stderr]     Checking rand v0.3.14
[INFO] [stderr]     Checking time v0.1.35
[INFO] [stderr]     Checking connect_three v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/monte_carlo.rs:40:17
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 path : path,
[INFO] [stderr]    |                 ^^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/monte_carlo.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 expanded_node : expanded_node
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expanded_node`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/monte_carlo.rs:40:17
[INFO] [stderr]    |
[INFO] [stderr] 40 |                 path : path,
[INFO] [stderr]    |                 ^^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/monte_carlo.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 expanded_node : expanded_node
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expanded_node`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_state.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/game_state.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if (column[i] == Color::Empty){
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_state.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 |         return copy;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `copy`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 |         return moves;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `moves`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:122:9
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         return End::Ongoing;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `End::Ongoing`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 |         return string;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `string`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monte_carlo.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 |     return random_move;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `random_move`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/monte_carlo.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 |     return best_move;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_move`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/monte_carlo.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 |     return best_move;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_move`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/monte_carlo.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 |     return best_move;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_move`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/monte_carlo.rs:243:19
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 if(uct > best_uct){
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_state.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/game_state.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if (column[i] == Color::Empty){
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/game_state.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 |         return copy;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `copy`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:106:9
[INFO] [stderr]     |
[INFO] [stderr] 106 |         return moves;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `moves`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:122:9
[INFO] [stderr]     |
[INFO] [stderr] 122 |         return true;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         return End::Ongoing;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `End::Ongoing`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/game_state.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 |         return string;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `string`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::*`
[INFO] [stderr]    --> src/game_state.rs:190:9
[INFO] [stderr]     |
[INFO] [stderr] 190 |     use super::*; 
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monte_carlo.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 |     return random_move;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `random_move`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/monte_carlo.rs:158:5
[INFO] [stderr]     |
[INFO] [stderr] 158 |     return best_move;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_move`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/monte_carlo.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 |     return best_move;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_move`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/monte_carlo.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 |     return best_move;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `best_move`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/monte_carlo.rs:243:19
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 if(uct > best_uct){
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `item`
[INFO] [stderr]   --> src/game_state.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 | fn push_back(item : Color, column : &mut [Color; 6]) -> usize{
[INFO] [stderr]    |              ^^^^ help: consider using `_item` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `player`
[INFO] [stderr]   --> src/monte_carlo.rs:66:54
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn run_simulation(state : game_state::GameState, player : game_state::Color) -> game_state::End{ 
[INFO] [stderr]    |                                                      ^^^^^^ help: consider using `_player` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `item`
[INFO] [stderr]   --> src/game_state.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 | fn push_back(item : Color, column : &mut [Color; 6]) -> usize{
[INFO] [stderr]    |              ^^^^ help: consider using `_item` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `player`
[INFO] [stderr]   --> src/monte_carlo.rs:66:54
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn run_simulation(state : game_state::GameState, player : game_state::Color) -> game_state::End{ 
[INFO] [stderr]    |                                                      ^^^^^^ help: consider using `_player` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `optimal_move_highest_win`
[INFO] [stderr]    --> src/monte_carlo.rs:161:1
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn optimal_move_highest_win(possible_moves : &Vec<(game_state::Move, &UCTData)>) -> game_state::Move{
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: comparison is useless due to type limits
[INFO] [stderr]   --> src/game_state.rs:47:35
[INFO] [stderr]    |
[INFO] [stderr] 47 |         (self.x <= BOARD_WIDTH && self.x  >= 0)
[INFO] [stderr]    |                                   ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_comparisons)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/game_state.rs:47:35
[INFO] [stderr]    |
[INFO] [stderr] 47 |         (self.x <= BOARD_WIDTH && self.x  >= 0)
[INFO] [stderr]    |                                   ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, this comparison is always true
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `game_state::GameState`
[INFO] [stderr]   --> src/game_state.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     pub fn new() -> Self{
[INFO] [stderr] 62 | |         GameState{ 
[INFO] [stderr] 63 | |             board: [[Color::Empty; BOARD_HEIGHT]; BOARD_WIDTH],
[INFO] [stderr] 64 | |             player : Color::White
[INFO] [stderr] 65 | |         }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 60 | impl Default for game_state::GameState {
[INFO] [stderr] 61 |     fn default() -> Self {
[INFO] [stderr] 62 |         Self::new()
[INFO] [stderr] 63 |     }
[INFO] [stderr] 64 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/game_state.rs:69:24
[INFO] [stderr]    |
[INFO] [stderr] 69 |         let mut copy = self.clone();
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: variable `stepX` should have a snake case name such as `step_x`
[INFO] [stderr]    --> src/game_state.rs:109:62
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn linear_match(&self, start_x : i32, start_y : i32, stepX : i32, stepY : i32, color : Color) -> bool{
[INFO] [stderr]     |                                                              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `stepY` should have a snake case name such as `step_y`
[INFO] [stderr]    --> src/game_state.rs:109:75
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn linear_match(&self, start_x : i32, start_y : i32, stepX : i32, stepY : i32, color : Color) -> bool{
[INFO] [stderr]     |                                                                           ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: comparison is useless due to type limits
[INFO] [stderr]    --> src/game_state.rs:114:16
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/game_state.rs:114:16
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: because 0 is the minimum value for this type, this comparison is always false
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: comparison is useless due to type limits
[INFO] [stderr]    --> src/game_state.rs:114:46
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                                              ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/game_state.rs:114:46
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                                              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: because 0 is the minimum value for this type, this comparison is always false
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/game_state.rs:133:18
[INFO] [stderr]     |
[INFO] [stderr] 133 |         for x in 0..BOARD_HEIGHT + 1{
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^ help: use: `0..=BOARD_HEIGHT`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/game_state.rs:134:22
[INFO] [stderr]     |
[INFO] [stderr] 134 |             for y in 0..BOARD_WIDTH + 1{
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^ help: use: `0..=BOARD_WIDTH`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `optimal_move_highest_win`
[INFO] [stderr]    --> src/monte_carlo.rs:161:1
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn optimal_move_highest_win(possible_moves : &Vec<(game_state::Move, &UCTData)>) -> game_state::Move{
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/monte_carlo.rs:27:10
[INFO] [stderr]    |
[INFO] [stderr] 27 |         (self.win_tie as f64 / self.num_plays as f64)
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.win_tie)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/monte_carlo.rs:27:32
[INFO] [stderr]    |
[INFO] [stderr] 27 |         (self.win_tie as f64 / self.num_plays as f64)
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_plays)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/monte_carlo.rs:60:39
[INFO] [stderr]    |
[INFO] [stderr] 60 | pub fn choose_random(possible_moves : &Vec<game_state::Move>) -> game_state::Move{
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[game_state::Move]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/monte_carlo.rs:62:23
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let random_move = possible_moves[random_number].clone();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possible_moves[random_number]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/monte_carlo.rs:72:12
[INFO] [stderr]    |
[INFO] [stderr] 72 |         if possible_moves.len() < 1{
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possible_moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: comparison is useless due to type limits
[INFO] [stderr]   --> src/game_state.rs:47:35
[INFO] [stderr]    |
[INFO] [stderr] 47 |         (self.x <= BOARD_WIDTH && self.x  >= 0)
[INFO] [stderr]    |                                   ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_comparisons)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]   --> src/game_state.rs:47:35
[INFO] [stderr]    |
[INFO] [stderr] 47 |         (self.x <= BOARD_WIDTH && self.x  >= 0)
[INFO] [stderr]    |                                   ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::absurd_extreme_comparisons)] on by default
[INFO] [stderr]    = help: because 0 is the minimum value for this type, this comparison is always true
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/monte_carlo.rs:154:80
[INFO] [stderr]     |
[INFO] [stderr] 154 |     let possible_moves = root.legal_moves(root.player).into_iter().map(|x| (x, statistics.get(&root.place(&x)).unwrap())).collect::<Vec<_>>();
[INFO] [stderr]     |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&statistics[&root.place(&x)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/monte_carlo.rs:156:16
[INFO] [stderr]     |
[INFO] [stderr] 156 |     let data = statistics.get(&root.place(&best_move)).unwrap();
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&statistics[&root.place(&best_move)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monte_carlo.rs:161:46
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn optimal_move_highest_win(possible_moves : &Vec<(game_state::Move, &UCTData)>) -> game_state::Move{
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(game_state::Move, &UCTData)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monte_carlo.rs:174:48
[INFO] [stderr]     |
[INFO] [stderr] 174 | fn optimal_move_most_visisted(possible_moves : &Vec<(game_state::Move, &UCTData)>) -> game_state::Move{
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(game_state::Move, &UCTData)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/monte_carlo.rs:191:24
[INFO] [stderr]     |
[INFO] [stderr] 191 |     visisted_states : &HashSet<game_state::GameState>,
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 189 | pub fn tree_policy<S: ::std::hash::BuildHasher>(
[INFO] [stderr] 190 |     current_state : &game_state::GameState,
[INFO] [stderr] 191 |     visisted_states : &HashSet<game_state::GameState, S>,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/monte_carlo.rs:192:14
[INFO] [stderr]     |
[INFO] [stderr] 192 |     stats : &HashMap<game_state::GameState, UCTData>
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 189 | pub fn tree_policy<S: ::std::hash::BuildHasher>(
[INFO] [stderr] 190 |     current_state : &game_state::GameState,
[INFO] [stderr] 191 |     visisted_states : &HashSet<game_state::GameState>,
[INFO] [stderr] 192 |     stats : &HashMap<game_state::GameState, UCTData, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/monte_carlo.rs:199:28
[INFO] [stderr]     |
[INFO] [stderr] 199 |     let mut current_node = current_state.clone();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*current_state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/monte_carlo.rs:207:12
[INFO] [stderr]     |
[INFO] [stderr] 207 |         if possible_moves.len() < 1 || victory(current_node.win()){
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possible_moves.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `game_state::GameState`
[INFO] [stderr]   --> src/game_state.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     pub fn new() -> Self{
[INFO] [stderr] 62 | |         GameState{ 
[INFO] [stderr] 63 | |             board: [[Color::Empty; BOARD_HEIGHT]; BOARD_WIDTH],
[INFO] [stderr] 64 | |             player : Color::White
[INFO] [stderr] 65 | |         }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 60 | impl Default for game_state::GameState {
[INFO] [stderr] 61 |     fn default() -> Self {
[INFO] [stderr] 62 |         Self::new()
[INFO] [stderr] 63 |     }
[INFO] [stderr] 64 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/monte_carlo.rs:213:51
[INFO] [stderr]     |
[INFO] [stderr] 213 |           let fully_explored = possible_moves.iter().fold(true, 
[INFO] [stderr]     |  ___________________________________________________^
[INFO] [stderr] 214 | |             |acc, x| 
[INFO] [stderr] 215 | |             acc && visisted_states.contains(&current_node.place(x))
[INFO] [stderr] 216 | |         );
[INFO] [stderr]     | |_ help: try: `.all(|x| visisted_states.contains(&current_node.place(x)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/game_state.rs:69:24
[INFO] [stderr]    |
[INFO] [stderr] 69 |         let mut copy = self.clone();
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/monte_carlo.rs:242:43
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 let uct = ucb1(data.wins, data.num_plays as f64, total_played as f64);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.num_plays)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/monte_carlo.rs:242:66
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 let uct = ucb1(data.wins, data.num_plays as f64, total_played as f64);
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(total_played)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monte_carlo.rs:256:12
[INFO] [stderr]     |
[INFO] [stderr] 256 |     path : &Vec<game_state::GameState>){
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[game_state::GameState]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/monte_carlo.rs:255:65
[INFO] [stderr]     |
[INFO] [stderr] 255 | pub fn back_propogate(win_value : game_state::End, stats : &mut HashMap<game_state::GameState, UCTData>,
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 255 | pub fn back_propogate<S: ::std::hash::BuildHasher>(win_value : game_state::End, stats : &mut HashMap<game_state::GameState, UCTData, S>,
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/monte_carlo.rs:258:13
[INFO] [stderr]     |
[INFO] [stderr] 258 | /             match stats.get_mut(node){
[INFO] [stderr] 259 | |                 Some(ref mut stat) =>{
[INFO] [stderr] 260 | |                     stat.wins += get_result_value(win_value, state_previous_player(&node));
[INFO] [stderr] 261 | |                     stat.num_plays += 1;
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |                 None => ()
[INFO] [stderr] 265 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 258 |             if let Some(ref mut stat) = stats.get_mut(node) {
[INFO] [stderr] 259 |     stat.wins += get_result_value(win_value, state_previous_player(&node));
[INFO] [stderr] 260 |     stat.num_plays += 1;
[INFO] [stderr] 261 |     stat.win_tie += get_tie_or_win(win_value, state_previous_player(&node));
[INFO] [stderr] 262 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: variable `stepX` should have a snake case name such as `step_x`
[INFO] [stderr]    --> src/game_state.rs:109:62
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn linear_match(&self, start_x : i32, start_y : i32, stepX : i32, stepY : i32, color : Color) -> bool{
[INFO] [stderr]     |                                                              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `stepY` should have a snake case name such as `step_y`
[INFO] [stderr]    --> src/game_state.rs:109:75
[INFO] [stderr]     |
[INFO] [stderr] 109 |     pub fn linear_match(&self, start_x : i32, start_y : i32, stepX : i32, stepY : i32, color : Color) -> bool{
[INFO] [stderr]     |                                                                           ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: comparison is useless due to type limits
[INFO] [stderr]    --> src/game_state.rs:114:16
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/game_state.rs:114:16
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: because 0 is the minimum value for this type, this comparison is always false
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: comparison is useless due to type limits
[INFO] [stderr]    --> src/game_state.rs:114:46
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                                              ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
[INFO] [stderr]    --> src/game_state.rs:114:46
[INFO] [stderr]     |
[INFO] [stderr] 114 |             if x < 0 || x >= BOARD_HEIGHT || y < 0 || y >= BOARD_WIDTH{
[INFO] [stderr]     |                                              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: because 0 is the minimum value for this type, this comparison is always false
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/game_state.rs:133:18
[INFO] [stderr]     |
[INFO] [stderr] 133 |         for x in 0..BOARD_HEIGHT + 1{
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^ help: use: `0..=BOARD_HEIGHT`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/game_state.rs:134:22
[INFO] [stderr]     |
[INFO] [stderr] 134 |             for y in 0..BOARD_WIDTH + 1{
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^ help: use: `0..=BOARD_WIDTH`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/monte_carlo.rs:27:10
[INFO] [stderr]    |
[INFO] [stderr] 27 |         (self.win_tie as f64 / self.num_plays as f64)
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.win_tie)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/monte_carlo.rs:27:32
[INFO] [stderr]    |
[INFO] [stderr] 27 |         (self.win_tie as f64 / self.num_plays as f64)
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_plays)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/monte_carlo.rs:60:39
[INFO] [stderr]    |
[INFO] [stderr] 60 | pub fn choose_random(possible_moves : &Vec<game_state::Move>) -> game_state::Move{
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[game_state::Move]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/monte_carlo.rs:62:23
[INFO] [stderr]    |
[INFO] [stderr] 62 |     let random_move = possible_moves[random_number].clone();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possible_moves[random_number]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/monte_carlo.rs:72:12
[INFO] [stderr]    |
[INFO] [stderr] 72 |         if possible_moves.len() < 1{
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possible_moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `connect_three`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/monte_carlo.rs:154:80
[INFO] [stderr]     |
[INFO] [stderr] 154 |     let possible_moves = root.legal_moves(root.player).into_iter().map(|x| (x, statistics.get(&root.place(&x)).unwrap())).collect::<Vec<_>>();
[INFO] [stderr]     |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&statistics[&root.place(&x)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/monte_carlo.rs:156:16
[INFO] [stderr]     |
[INFO] [stderr] 156 |     let data = statistics.get(&root.place(&best_move)).unwrap();
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&statistics[&root.place(&best_move)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monte_carlo.rs:161:46
[INFO] [stderr]     |
[INFO] [stderr] 161 | fn optimal_move_highest_win(possible_moves : &Vec<(game_state::Move, &UCTData)>) -> game_state::Move{
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(game_state::Move, &UCTData)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monte_carlo.rs:174:48
[INFO] [stderr]     |
[INFO] [stderr] 174 | fn optimal_move_most_visisted(possible_moves : &Vec<(game_state::Move, &UCTData)>) -> game_state::Move{
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(game_state::Move, &UCTData)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/monte_carlo.rs:191:24
[INFO] [stderr]     |
[INFO] [stderr] 191 |     visisted_states : &HashSet<game_state::GameState>,
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 189 | pub fn tree_policy<S: ::std::hash::BuildHasher>(
[INFO] [stderr] 190 |     current_state : &game_state::GameState,
[INFO] [stderr] 191 |     visisted_states : &HashSet<game_state::GameState, S>,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/monte_carlo.rs:192:14
[INFO] [stderr]     |
[INFO] [stderr] 192 |     stats : &HashMap<game_state::GameState, UCTData>
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 189 | pub fn tree_policy<S: ::std::hash::BuildHasher>(
[INFO] [stderr] 190 |     current_state : &game_state::GameState,
[INFO] [stderr] 191 |     visisted_states : &HashSet<game_state::GameState>,
[INFO] [stderr] 192 |     stats : &HashMap<game_state::GameState, UCTData, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/monte_carlo.rs:199:28
[INFO] [stderr]     |
[INFO] [stderr] 199 |     let mut current_node = current_state.clone();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*current_state`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/monte_carlo.rs:207:12
[INFO] [stderr]     |
[INFO] [stderr] 207 |         if possible_moves.len() < 1 || victory(current_node.win()){
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `possible_moves.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/monte_carlo.rs:213:51
[INFO] [stderr]     |
[INFO] [stderr] 213 |           let fully_explored = possible_moves.iter().fold(true, 
[INFO] [stderr]     |  ___________________________________________________^
[INFO] [stderr] 214 | |             |acc, x| 
[INFO] [stderr] 215 | |             acc && visisted_states.contains(&current_node.place(x))
[INFO] [stderr] 216 | |         );
[INFO] [stderr]     | |_ help: try: `.all(|x| visisted_states.contains(&current_node.place(x)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/monte_carlo.rs:242:43
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 let uct = ucb1(data.wins, data.num_plays as f64, total_played as f64);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.num_plays)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/monte_carlo.rs:242:66
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 let uct = ucb1(data.wins, data.num_plays as f64, total_played as f64);
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(total_played)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monte_carlo.rs:256:12
[INFO] [stderr]     |
[INFO] [stderr] 256 |     path : &Vec<game_state::GameState>){
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[game_state::GameState]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/monte_carlo.rs:255:65
[INFO] [stderr]     |
[INFO] [stderr] 255 | pub fn back_propogate(win_value : game_state::End, stats : &mut HashMap<game_state::GameState, UCTData>,
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 255 | pub fn back_propogate<S: ::std::hash::BuildHasher>(win_value : game_state::End, stats : &mut HashMap<game_state::GameState, UCTData, S>,
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/monte_carlo.rs:258:13
[INFO] [stderr]     |
[INFO] [stderr] 258 | /             match stats.get_mut(node){
[INFO] [stderr] 259 | |                 Some(ref mut stat) =>{
[INFO] [stderr] 260 | |                     stat.wins += get_result_value(win_value, state_previous_player(&node));
[INFO] [stderr] 261 | |                     stat.num_plays += 1;
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |                 None => ()
[INFO] [stderr] 265 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 258 |             if let Some(ref mut stat) = stats.get_mut(node) {
[INFO] [stderr] 259 |     stat.wins += get_result_value(win_value, state_previous_player(&node));
[INFO] [stderr] 260 |     stat.num_plays += 1;
[INFO] [stderr] 261 |     stat.win_tie += get_tie_or_win(win_value, state_previous_player(&node));
[INFO] [stderr] 262 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `connect_three`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "079c56237647cb7ee7401231f3a0e307f611abf1f26003a472e1f0f2520a5fe1"`
[INFO] running `"docker" "rm" "-f" "079c56237647cb7ee7401231f3a0e307f611abf1f26003a472e1f0f2520a5fe1"`
[INFO] [stdout] 079c56237647cb7ee7401231f3a0e307f611abf1f26003a472e1f0f2520a5fe1