[INFO] updating cached repository staronj/Automata [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/staronj/Automata [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/staronj/Automata" "work/ex/clippy-test-run/sources/stable/gh/staronj/Automata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/staronj/Automata'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/staronj/Automata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/staronj/Automata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/staronj/Automata'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d4bae106f2000ec6c9d2f8580a6d7d3d7b4cae3b [INFO] sha for GitHub repo staronj/Automata: d4bae106f2000ec6c9d2f8580a6d7d3d7b4cae3b [INFO] validating manifest of staronj/Automata on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of staronj/Automata on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing staronj/Automata [INFO] finished frobbing staronj/Automata [INFO] frobbed toml for staronj/Automata written to work/ex/clippy-test-run/sources/stable/gh/staronj/Automata/Cargo.toml [INFO] started frobbing staronj/Automata [INFO] finished frobbing staronj/Automata [INFO] frobbed toml for staronj/Automata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/staronj/Automata/Cargo.toml [INFO] crate staronj/Automata has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting staronj/Automata against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/staronj/Automata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2d0bd27822483db8af409f451b895dc924289805b3f89674ed020a7f8d8e26e [INFO] running `"docker" "start" "-a" "f2d0bd27822483db8af409f451b895dc924289805b3f89674ed020a7f8d8e26e"` [INFO] [stderr] Checking bytesize v1.0.0 [INFO] [stderr] Checking colorify v0.2.3 [INFO] [stderr] Checking is_sorted v0.1.0 [INFO] [stderr] Checking multiset v0.0.4 [INFO] [stderr] Checking permutohedron v0.2.4 [INFO] [stderr] Checking qutex v0.2.1 [INFO] [stderr] Compiling ocl-core v0.10.0 [INFO] [stderr] Checking cl-sys v0.4.1 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking ocl-core-vector v0.1.0 [INFO] [stderr] Checking ocl v0.19.1 [INFO] [stderr] Checking automaton v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/generating_automata.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return Heap::new(&mut (0 .. k).collect::>()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Heap::new(&mut (0 .. k).collect::>()).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `max` [INFO] [stderr] --> src/lib/update_hashes.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::cmp::{min, max}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/update_hashes.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | const MULTIPLIER1: u64 = 0x7363081d681a33f1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7363_081d_681a_33f1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/update_hashes.rs:12:26 [INFO] [stderr] | [INFO] [stderr] 12 | const MULTIPLIER2: u64 = 0x64a2869eab18bf21; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x64a2_869e_ab18_bf21` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/update_hashes.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | const OPENCL_KERNEL_SRC_TEMPLATE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/update_hashes.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | kernel_src [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/update_hashes.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | let kernel_src = kernel_src.replace("[[compressed_automaton_transitions_limit]]", &COMPRESSED_AUTOMATON_TRANSITIONS_LIMIT.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib/generating_automata.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return Heap::new(&mut (0 .. k).collect::>()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Heap::new(&mut (0 .. k).collect::>()).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `max` [INFO] [stderr] --> src/lib/update_hashes.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::cmp::{min, max}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/update_hashes.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | const MULTIPLIER1: u64 = 0x7363081d681a33f1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7363_081d_681a_33f1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/update_hashes.rs:12:26 [INFO] [stderr] | [INFO] [stderr] 12 | const MULTIPLIER2: u64 = 0x64a2869eab18bf21; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x64a2_869e_ab18_bf21` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/update_hashes.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | const OPENCL_KERNEL_SRC_TEMPLATE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/update_hashes.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | kernel_src [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/update_hashes.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | let kernel_src = kernel_src.replace("[[compressed_automaton_transitions_limit]]", &COMPRESSED_AUTOMATON_TRANSITIONS_LIMIT.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `duplicates_threshold` [INFO] [stderr] --> src/lib/generating_words.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | let duplicates_threshold = (words_count as f64).sqrt() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_duplicates_threshold` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `context` [INFO] [stderr] --> src/lib/update_hashes.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | context: ocl::Context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `word`. [INFO] [stderr] --> src/lib/automaton.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | for i in 0 .. word.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for in &word { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait `Word` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/lib/word.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub trait Word: [INFO] [stderr] 5 | | Index + [INFO] [stderr] 6 | | Clone + [INFO] [stderr] 7 | | Eq + [INFO] [stderr] ... | [INFO] [stderr] 14 | | fn as_string(&self) -> String; [INFO] [stderr] 15 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/lib/word.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0 .. self.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in &self { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `duplicates_threshold` [INFO] [stderr] --> src/lib/generating_words.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | let duplicates_threshold = (words_count as f64).sqrt() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `_duplicates_threshold` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `f`. [INFO] [stderr] --> src/lib/generating_automata.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | for i in 0 .. size as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 19 | for in f.iter_mut().take(size as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/generating_automata.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | f[i] = f[i] + carry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `f[i] += carry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib/generating_automata.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | let iterations: u32 = u32::pow(k as u32, k as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib/generating_automata.rs:29:46 [INFO] [stderr] | [INFO] [stderr] 29 | let iterations: u32 = u32::pow(k as u32, k as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib/generating_words.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if abstraction_classes.contains_key(&signature) { [INFO] [stderr] 31 | | let list = abstraction_classes.get_mut(&signature).unwrap(); [INFO] [stderr] 32 | | list.push(word.clone()); [INFO] [stderr] 33 | | } else { [INFO] [stderr] 34 | | abstraction_classes.insert(signature, vec![word.clone()]); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: consider using: `abstraction_classes.entry(signature)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/generating_words.rs:41:95 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn find_indistinguishable_words, A: Automaton>(automata: &[A], words: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[W]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib/update_hashes.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | hash = mix_value(hash, value as u64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib/update_hashes.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn gpu_opencl_computation<'a>(words_length: u8, hashes_length: usize, automata_chunk_size: usize) -> Box { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib/update_hashes.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | .write(hashes_chunk.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `hashes_chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib/update_hashes.rs:295:22 [INFO] [stderr] | [INFO] [stderr] 295 | .arg(self.words_length as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.words_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `context` [INFO] [stderr] --> src/lib/update_hashes.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | context: ocl::Context, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `word`. [INFO] [stderr] --> src/lib/automaton.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | for i in 0 .. word.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for in &word { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: trait `Word` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/lib/word.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub trait Word: [INFO] [stderr] 5 | | Index + [INFO] [stderr] 6 | | Clone + [INFO] [stderr] 7 | | Eq + [INFO] [stderr] ... | [INFO] [stderr] 14 | | fn as_string(&self) -> String; [INFO] [stderr] 15 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/lib/word.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0 .. self.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in &self { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `f`. [INFO] [stderr] --> src/lib/generating_automata.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | for i in 0 .. size as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 19 | for in f.iter_mut().take(size as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/generating_automata.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | f[i] = f[i] + carry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `f[i] += carry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib/generating_automata.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | let iterations: u32 = u32::pow(k as u32, k as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib/generating_automata.rs:29:46 [INFO] [stderr] | [INFO] [stderr] 29 | let iterations: u32 = u32::pow(k as u32, k as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/lib/generating_words.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if abstraction_classes.contains_key(&signature) { [INFO] [stderr] 31 | | let list = abstraction_classes.get_mut(&signature).unwrap(); [INFO] [stderr] 32 | | list.push(word.clone()); [INFO] [stderr] 33 | | } else { [INFO] [stderr] 34 | | abstraction_classes.insert(signature, vec![word.clone()]); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: consider using: `abstraction_classes.entry(signature)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib/generating_words.rs:41:95 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn find_indistinguishable_words, A: Automaton>(automata: &[A], words: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[W]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib/update_hashes.rs:21:32 [INFO] [stderr] | [INFO] [stderr] 21 | hash = mix_value(hash, value as u64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib/update_hashes.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn gpu_opencl_computation<'a>(words_length: u8, hashes_length: usize, automata_chunk_size: usize) -> Box { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib/update_hashes.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | .write(hashes_chunk.as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `hashes_chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib/update_hashes.rs:295:22 [INFO] [stderr] | [INFO] [stderr] 295 | .arg(self.words_length as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.words_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/bin/device_info.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/bin/device_info.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p_idx` is only used to index `platforms`. [INFO] [stderr] --> src/bin/device_info.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | for p_idx in 0..platforms.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for in &platforms { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `d_idx` is used to index `devices` [INFO] [stderr] --> src/bin/device_info.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | for d_idx in 0..devices.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (d_idx, ) in devices.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/device_info.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | fn print_platform_info(platform: &Platform) -> OclResult<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Platform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/device_info.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | fn print_device_info(device: &Device) -> OclResult<()> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p_idx` is only used to index `platforms`. [INFO] [stderr] --> src/bin/device_info.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | for p_idx in 0..platforms.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for in &platforms { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `d_idx` is used to index `devices` [INFO] [stderr] --> src/bin/device_info.rs:58:22 [INFO] [stderr] | [INFO] [stderr] 58 | for d_idx in 0..devices.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (d_idx, ) in devices.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/device_info.rs:110:34 [INFO] [stderr] | [INFO] [stderr] 110 | fn print_platform_info(platform: &Platform) -> OclResult<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Platform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/device_info.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | fn print_device_info(device: &Device) -> OclResult<()> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.22s [INFO] running `"docker" "inspect" "f2d0bd27822483db8af409f451b895dc924289805b3f89674ed020a7f8d8e26e"` [INFO] running `"docker" "rm" "-f" "f2d0bd27822483db8af409f451b895dc924289805b3f89674ed020a7f8d8e26e"` [INFO] [stdout] f2d0bd27822483db8af409f451b895dc924289805b3f89674ed020a7f8d8e26e