[INFO] updating cached repository stanistan/reverse-proxy-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stanistan/reverse-proxy-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stanistan/reverse-proxy-rs" "work/ex/clippy-test-run/sources/stable/gh/stanistan/reverse-proxy-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stanistan/reverse-proxy-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stanistan/reverse-proxy-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stanistan/reverse-proxy-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stanistan/reverse-proxy-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fca1632bc22b249206804181ab5ea41a93757fb7 [INFO] sha for GitHub repo stanistan/reverse-proxy-rs: fca1632bc22b249206804181ab5ea41a93757fb7 [INFO] validating manifest of stanistan/reverse-proxy-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stanistan/reverse-proxy-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stanistan/reverse-proxy-rs [INFO] finished frobbing stanistan/reverse-proxy-rs [INFO] frobbed toml for stanistan/reverse-proxy-rs written to work/ex/clippy-test-run/sources/stable/gh/stanistan/reverse-proxy-rs/Cargo.toml [INFO] started frobbing stanistan/reverse-proxy-rs [INFO] finished frobbing stanistan/reverse-proxy-rs [INFO] frobbed toml for stanistan/reverse-proxy-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stanistan/reverse-proxy-rs/Cargo.toml [INFO] crate stanistan/reverse-proxy-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stanistan/reverse-proxy-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stanistan/reverse-proxy-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f99ab040ac80c75ec90dcb0cb6b026bd1edcb42507f8139d226078095b4be5a [INFO] running `"docker" "start" "-a" "8f99ab040ac80c75ec90dcb0cb6b026bd1edcb42507f8139d226078095b4be5a"` [INFO] [stderr] Checking base64 v0.9.1 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking openssl-sys v0.9.30 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio v0.1.5 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reverse-proxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:230:21 [INFO] [stderr] | [INFO] [stderr] 230 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:230:21 [INFO] [stderr] | [INFO] [stderr] 230 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/state.rs:89:48 [INFO] [stderr] | [INFO] [stderr] 89 | header::CacheDirective::MaxAge(31536000) [INFO] [stderr] | ^^^^^^^^ help: consider: `31_536_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/state.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | to: _, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Proxy { request, retries_remaining: 0, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/env_options.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | mime_types: ::mime_types::MIME_TYPES.iter().map(|s| *s).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `::mime_types::MIME_TYPES.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/state.rs:30:66 [INFO] [stderr] | [INFO] [stderr] 30 | to.set($from.headers().get().cloned().unwrap_or_else(|| $else)); [INFO] [stderr] | ^^ help: remove closure as shown: `header::Accept::image` [INFO] [stderr] ... [INFO] [stderr] 66 | *req.headers_mut() = copy_headers!(request, default_headers(), { [INFO] [stderr] | __________________________- [INFO] [stderr] 67 | | set [ header::UserAgent::new(opts.user_agent.clone()) ], [INFO] [stderr] 68 | | if_present [ header::AcceptEncoding ], [INFO] [stderr] 69 | | or_default [ header::Accept::image() ] [INFO] [stderr] 70 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/state.rs:89:48 [INFO] [stderr] | [INFO] [stderr] 89 | header::CacheDirective::MaxAge(31536000) [INFO] [stderr] | ^^^^^^^^ help: consider: `31_536_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/state.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | to: _, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Proxy { request, retries_remaining: 0, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | let mut core = Core::new().expect(&format!("thread-{}: error: no core for you", worker_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("thread-{}: error: no core for you", worker_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/env_options.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | mime_types: ::mime_types::MIME_TYPES.iter().map(|s| *s).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `::mime_types::MIME_TYPES.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/state.rs:30:66 [INFO] [stderr] | [INFO] [stderr] 30 | to.set($from.headers().get().cloned().unwrap_or_else(|| $else)); [INFO] [stderr] | ^^ help: remove closure as shown: `header::Accept::image` [INFO] [stderr] ... [INFO] [stderr] 66 | *req.headers_mut() = copy_headers!(request, default_headers(), { [INFO] [stderr] | __________________________- [INFO] [stderr] 67 | | set [ header::UserAgent::new(opts.user_agent.clone()) ], [INFO] [stderr] 68 | | if_present [ header::AcceptEncoding ], [INFO] [stderr] 69 | | or_default [ header::Accept::image() ] [INFO] [stderr] 70 | | }); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:87:32 [INFO] [stderr] | [INFO] [stderr] 87 | let mut core = Core::new().expect(&format!("thread-{}: error: no core for you", worker_id)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("thread-{}: error: no core for you", worker_id))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.45s [INFO] running `"docker" "inspect" "8f99ab040ac80c75ec90dcb0cb6b026bd1edcb42507f8139d226078095b4be5a"` [INFO] running `"docker" "rm" "-f" "8f99ab040ac80c75ec90dcb0cb6b026bd1edcb42507f8139d226078095b4be5a"` [INFO] [stdout] 8f99ab040ac80c75ec90dcb0cb6b026bd1edcb42507f8139d226078095b4be5a