[INFO] updating cached repository standbyme/jvm-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/standbyme/jvm-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/standbyme/jvm-rs" "work/ex/clippy-test-run/sources/stable/gh/standbyme/jvm-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/standbyme/jvm-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/standbyme/jvm-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/standbyme/jvm-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/standbyme/jvm-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fb31c77e0643ea7251e9f9574f479c68d72fef83 [INFO] sha for GitHub repo standbyme/jvm-rs: fb31c77e0643ea7251e9f9574f479c68d72fef83 [INFO] validating manifest of standbyme/jvm-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of standbyme/jvm-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing standbyme/jvm-rs [INFO] finished frobbing standbyme/jvm-rs [INFO] frobbed toml for standbyme/jvm-rs written to work/ex/clippy-test-run/sources/stable/gh/standbyme/jvm-rs/Cargo.toml [INFO] started frobbing standbyme/jvm-rs [INFO] finished frobbing standbyme/jvm-rs [INFO] frobbed toml for standbyme/jvm-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/standbyme/jvm-rs/Cargo.toml [INFO] crate standbyme/jvm-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting standbyme/jvm-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/standbyme/jvm-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b01311a8bf980d52d3891bdf42b1d2673e0a6e704f69f3a007f83c2f7a8601a9 [INFO] running `"docker" "start" "-a" "b01311a8bf980d52d3891bdf42b1d2673e0a6e704f69f3a007f83c2f7a8601a9"` [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Compiling crc32fast v1.0.3 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.5.0 [INFO] [stderr] Checking jvm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | operand_stack: operand_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operand_stack` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | operand_stack: operand_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operand_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let c = unsafe { char::from_u32_unchecked(q) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | let z = next!(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:90:37 [INFO] [stderr] | [INFO] [stderr] 90 | let q: u32 = 0x10000u32 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | let c = unsafe { char::from_u32_unchecked(q) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | operand_stack: operand_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operand_stack` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | operand_stack: operand_stack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operand_stack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let c = unsafe { char::from_u32_unchecked(q) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | let z = next!(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:90:37 [INFO] [stderr] | [INFO] [stderr] 90 | let q: u32 = 0x10000u32 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/util/modified_utf8.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | let c = unsafe { char::from_u32_unchecked(q) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/classfile/class_reader.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(magic, 0xCAFEBABE); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/classpath/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod classpath; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/instruction/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod instruction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/util/code_reader.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | let CodeReader { pc: _, code } = self; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `CodeReader { code, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/util/modified_utf8.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | if y < 0b1011_111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b101_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/classfile/class_reader.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(magic, 0xCAFEBABE); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/classfile/class_reader.rs:540:64 [INFO] [stderr] | [INFO] [stderr] 540 | ConstantInfo::Integer(value) => assert_eq!(*value, 999999i32), [INFO] [stderr] | ^^^^^^^^^ help: consider: `999_999i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/classfile/class_reader.rs:572:17 [INFO] [stderr] | [INFO] [stderr] 572 | access_flags: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/classfile/class_reader.rs:573:17 [INFO] [stderr] | [INFO] [stderr] 573 | name: _, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/classfile/class_reader.rs:574:17 [INFO] [stderr] | [INFO] [stderr] 574 | descriptor: _, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MemberInfo { name_index, descriptor_index, attributes, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/classfile/class_reader.rs:586:17 [INFO] [stderr] | [INFO] [stderr] 586 | access_flags: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/classfile/class_reader.rs:587:17 [INFO] [stderr] | [INFO] [stderr] 587 | name: _, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/classfile/class_reader.rs:588:17 [INFO] [stderr] | [INFO] [stderr] 588 | descriptor: _, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MemberInfo { name_index, descriptor_index, attributes, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/classpath/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod classpath; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:94:38 [INFO] [stderr] | [INFO] [stderr] 94 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:94:38 [INFO] [stderr] | [INFO] [stderr] 94 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:107:38 [INFO] [stderr] | [INFO] [stderr] 107 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:168:30 [INFO] [stderr] | [INFO] [stderr] 168 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:216:30 [INFO] [stderr] | [INFO] [stderr] 216 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:263:30 [INFO] [stderr] | [INFO] [stderr] 263 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:311:30 [INFO] [stderr] | [INFO] [stderr] 311 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:357:30 [INFO] [stderr] | [INFO] [stderr] 357 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:403:30 [INFO] [stderr] | [INFO] [stderr] 403 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:449:30 [INFO] [stderr] | [INFO] [stderr] 449 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:495:30 [INFO] [stderr] | [INFO] [stderr] 495 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:541:30 [INFO] [stderr] | [INFO] [stderr] 541 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:587:30 [INFO] [stderr] | [INFO] [stderr] 587 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:633:30 [INFO] [stderr] | [INFO] [stderr] 633 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/if_icmp.rs:679:30 [INFO] [stderr] | [INFO] [stderr] 679 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:162:30 [INFO] [stderr] | [INFO] [stderr] 162 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:206:30 [INFO] [stderr] | [INFO] [stderr] 206 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:251:30 [INFO] [stderr] | [INFO] [stderr] 251 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:295:30 [INFO] [stderr] | [INFO] [stderr] 295 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:340:30 [INFO] [stderr] | [INFO] [stderr] 340 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:384:30 [INFO] [stderr] | [INFO] [stderr] 384 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:429:30 [INFO] [stderr] | [INFO] [stderr] 429 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:473:30 [INFO] [stderr] | [INFO] [stderr] 473 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:518:30 [INFO] [stderr] | [INFO] [stderr] 518 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:562:30 [INFO] [stderr] | [INFO] [stderr] 562 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:607:30 [INFO] [stderr] | [INFO] [stderr] 607 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:651:30 [INFO] [stderr] | [INFO] [stderr] 651 | let (ExecuteResult { thread: _, offset }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { offset, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:57:34 [INFO] [stderr] | [INFO] [stderr] 57 | let frame = create_frame(9223372036854775807i64, 9223372036854775806i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:57:58 [INFO] [stderr] | [INFO] [stderr] 57 | let frame = create_frame(9223372036854775807i64, 9223372036854775806i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_806i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:59:38 [INFO] [stderr] | [INFO] [stderr] 59 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | let frame = create_frame(-9223372036854775806i64, 9223372036854775807i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_806i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:69:59 [INFO] [stderr] | [INFO] [stderr] 69 | let frame = create_frame(-9223372036854775806i64, 9223372036854775807i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:71:38 [INFO] [stderr] | [INFO] [stderr] 71 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | let frame = create_frame(-9223372036854775806i64, -9223372036854775806i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_806i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:81:60 [INFO] [stderr] | [INFO] [stderr] 81 | let frame = create_frame(-9223372036854775806i64, -9223372036854775806i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_806i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/comparison/lcmp.rs:83:38 [INFO] [stderr] | [INFO] [stderr] 83 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:384:38 [INFO] [stderr] | [INFO] [stderr] 384 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:417:38 [INFO] [stderr] | [INFO] [stderr] 417 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:450:38 [INFO] [stderr] | [INFO] [stderr] 450 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:483:38 [INFO] [stderr] | [INFO] [stderr] 483 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:516:38 [INFO] [stderr] | [INFO] [stderr] 516 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:549:38 [INFO] [stderr] | [INFO] [stderr] 549 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:582:38 [INFO] [stderr] | [INFO] [stderr] 582 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:615:38 [INFO] [stderr] | [INFO] [stderr] 615 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:648:38 [INFO] [stderr] | [INFO] [stderr] 648 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:681:38 [INFO] [stderr] | [INFO] [stderr] 681 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:714:38 [INFO] [stderr] | [INFO] [stderr] 714 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:747:38 [INFO] [stderr] | [INFO] [stderr] 747 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:780:38 [INFO] [stderr] | [INFO] [stderr] 780 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/constant/xconst.rs:813:38 [INFO] [stderr] | [INFO] [stderr] 813 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/instruction/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod instruction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/add.rs:175:38 [INFO] [stderr] | [INFO] [stderr] 175 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:214:55 [INFO] [stderr] | [INFO] [stderr] 214 | let operand_stack = operand_stack.push_double(2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_45f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:215:55 [INFO] [stderr] | [INFO] [stderr] 215 | let operand_stack = operand_stack.push_double(3.1415926535897926f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.141_592_653_589_792_6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/add.rs:224:38 [INFO] [stderr] | [INFO] [stderr] 224 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:228:25 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(val, 5.8598744820397926); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `5.859_874_482_039_792_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:263:54 [INFO] [stderr] | [INFO] [stderr] 263 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:264:54 [INFO] [stderr] | [INFO] [stderr] 264 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/add.rs:273:38 [INFO] [stderr] | [INFO] [stderr] 273 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | assert_eq!(val, 6.2831852); [INFO] [stderr] | ^^^^^^^^^ help: consider: `6.283_185_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:312:53 [INFO] [stderr] | [INFO] [stderr] 312 | let operand_stack = operand_stack.push_long(12345678969); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678_969` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:313:53 [INFO] [stderr] | [INFO] [stderr] 313 | let operand_stack = operand_stack.push_long(2997924580); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_997_924_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/add.rs:322:38 [INFO] [stderr] | [INFO] [stderr] 322 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/add.rs:326:25 [INFO] [stderr] | [INFO] [stderr] 326 | assert_eq!(val, 15343603549); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `15_343_603_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/and.rs:117:38 [INFO] [stderr] | [INFO] [stderr] 117 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/and.rs:156:53 [INFO] [stderr] | [INFO] [stderr] 156 | let operand_stack = operand_stack.push_long(12345678969); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_345_678_969` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/and.rs:157:53 [INFO] [stderr] | [INFO] [stderr] 157 | let operand_stack = operand_stack.push_long(2997924580); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_997_924_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/and.rs:166:38 [INFO] [stderr] | [INFO] [stderr] 166 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/and.rs:170:25 [INFO] [stderr] | [INFO] [stderr] 170 | assert_eq!(val, 2458914912); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_458_914_912` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:166:55 [INFO] [stderr] | [INFO] [stderr] 166 | let operand_stack = operand_stack.push_double(2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_45f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:167:55 [INFO] [stderr] | [INFO] [stderr] 167 | let operand_stack = operand_stack.push_double(3.1415926535897926f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.141_592_653_589_792_6f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/mul.rs:176:38 [INFO] [stderr] | [INFO] [stderr] 176 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:180:25 [INFO] [stderr] | [INFO] [stderr] 180 | assert_eq!(val, 8.53973422264514888498427947f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `8.539_734_222_645_148_884_984_279_47f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:215:54 [INFO] [stderr] | [INFO] [stderr] 215 | let operand_stack = operand_stack.push_float(2.71828182845f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_45f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:216:54 [INFO] [stderr] | [INFO] [stderr] 216 | let operand_stack = operand_stack.push_float(3.1415926535897926f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.141_592_653_589_792_6f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/mul.rs:225:38 [INFO] [stderr] | [INFO] [stderr] 225 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(val, 8.53973422264514888498427947f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `8.539_734_222_645_148_884_984_279_47f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/mul.rs:274:38 [INFO] [stderr] | [INFO] [stderr] 274 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:313:53 [INFO] [stderr] | [INFO] [stderr] 313 | let operand_stack = operand_stack.push_long(1234567890); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:314:53 [INFO] [stderr] | [INFO] [stderr] 314 | let operand_stack = operand_stack.push_long(2997924580); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_997_924_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/mul.rs:323:38 [INFO] [stderr] | [INFO] [stderr] 323 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/mul.rs:327:25 [INFO] [stderr] | [INFO] [stderr] 327 | assert_eq!(val, 3701141423109736200); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `3_701_141_423_109_736_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/neg.rs:160:38 [INFO] [stderr] | [INFO] [stderr] 160 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/neg.rs:208:38 [INFO] [stderr] | [INFO] [stderr] 208 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/neg.rs:256:38 [INFO] [stderr] | [INFO] [stderr] 256 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/neg.rs:304:38 [INFO] [stderr] | [INFO] [stderr] 304 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/neg.rs:352:38 [INFO] [stderr] | [INFO] [stderr] 352 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/neg.rs:390:52 [INFO] [stderr] | [INFO] [stderr] 390 | let operand_stack = operand_stack.push_int(234556); [INFO] [stderr] | ^^^^^^ help: consider: `234_556` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/neg.rs:399:38 [INFO] [stderr] | [INFO] [stderr] 399 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/neg.rs:403:26 [INFO] [stderr] | [INFO] [stderr] 403 | assert_eq!(val, -234556); [INFO] [stderr] | ^^^^^^ help: consider: `234_556` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/neg.rs:438:54 [INFO] [stderr] | [INFO] [stderr] 438 | let operand_stack = operand_stack.push_long(-54875845748435i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `54_875_845_748_435i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/instruction/math/neg.rs:447:38 [INFO] [stderr] | [INFO] [stderr] 447 | let (ExecuteResult { thread, offset: _ }, _) = [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `ExecuteResult { thread, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/instruction/math/neg.rs:451:25 [INFO] [stderr] | [INFO] [stderr] 451 | assert_eq!(val, 54875845748435i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `54_875_845_748_435i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rtda/frame.rs:83:55 [INFO] [stderr] | [INFO] [stderr] 83 | let operand_stack = operand_stack.push_double(2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_45f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rtda/frame.rs:85:53 [INFO] [stderr] | [INFO] [stderr] 85 | let operand_stack = operand_stack.push_long(2997924580); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_997_924_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rtda/frame.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rtda/frame.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(val, 3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rtda/frame.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(val, 2997924580); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_997_924_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rtda/frame.rs:94:25 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(val, 2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_45f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/util/code_reader.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | let CodeReader { pc: _, code } = self; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CodeReader { code, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/util/modified_utf8.rs:47:20 [INFO] [stderr] | [INFO] [stderr] 47 | if y < 0b1011_111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b101_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/vars.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | _ => panic!("get_int from wrong place"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/classpath/classpath.rs:98:23 [INFO] [stderr] | [INFO] [stderr] 98 | .or_else(|x| self.user.read_class(&class_file_name)) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ILOAD_0` [INFO] [stderr] --> src/instruction/load/iload.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn ILOAD_0(code_reader: CodeReader, thread: Thread) -> (ExecuteResult, CodeReader) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `DADD` [INFO] [stderr] --> src/instruction/math/add.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn DADD(code_reader: CodeReader, thread: Thread) -> (ExecuteResult, CodeReader) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `LADD` [INFO] [stderr] --> src/instruction/math/add.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn LADD(code_reader: CodeReader, thread: Thread) -> (ExecuteResult, CodeReader) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `FADD` [INFO] [stderr] --> src/instruction/math/add.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn FADD(code_reader: CodeReader, thread: Thread) -> (ExecuteResult, CodeReader) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PUBLIC` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub const ACC_PUBLIC: u16 = 0x0001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PRIVATE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub const ACC_PRIVATE: u16 = 0x0002; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PROTECTED` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const ACC_PROTECTED: u16 = 0x0004; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_SUPER` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub const ACC_SUPER: u16 = 0x0020; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_SYNCHRONIZED` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub const ACC_SYNCHRONIZED: u16 = 0x0020; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_VOLATILE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub const ACC_VOLATILE: u16 = 0x0040; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_BRIDGE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub const ACC_BRIDGE: u16 = 0x0040; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_TRANSIENT` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const ACC_TRANSIENT: u16 = 0x0080; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_VARARGS` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub const ACC_VARARGS: u16 = 0x0080; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_NATIVE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub const ACC_NATIVE: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_INTERFACE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub const ACC_INTERFACE: u16 = 0x0200; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_ABSTRACT` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub const ACC_ABSTRACT: u16 = 0x0400; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_STRICT` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub const ACC_STRICT: u16 = 0x0800; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_SYNTHETIC` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub const ACC_SYNTHETIC: u16 = 0x1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_ANNOTATION` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub const ACC_ANNOTATION: u16 = 0x2000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_ENUM` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub const ACC_ENUM: u16 = 0x4000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Object` [INFO] [stderr] --> src/rtda/heap/object.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | struct Object { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/classfile/class_file.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn main_method<'a>(&'a self) -> &'a MemberInfo { [INFO] [stderr] 21 | | self.methods [INFO] [stderr] 22 | | .iter() [INFO] [stderr] 23 | | .find(|x| x.name == "main" && x.descriptor == "([Ljava/lang/String;)V") [INFO] [stderr] 24 | | .expect("Main method not found") [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/classfile/class_reader.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | i = i + add; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += add` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/classpath/classpath.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | if path.ends_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/classpath/classpath.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | .unwrap_or(Err(Error::new(ErrorKind::Other, "Class not found"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Err(Error::new(ErrorKind::Other, "Class not found")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/classpath/classpath.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | file.read_to_end(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/classpath/classpath.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | let cp = cp_opt.unwrap_or(".".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(val1 - val2).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(val1 - val2).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/constant/xipush.rs:20:48 [INFO] [stderr] | [INFO] [stderr] 20 | let operand_stack = operand_stack.push_int(i as i32); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/math/inc.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let val_1 = val_1 as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(val_1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rtda/heap/class_loader.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / if self.class_map.contains_key(&name) { [INFO] [stderr] 38 | | let class = Rc::clone(self.class_map.get(&name).unwrap()); [INFO] [stderr] 39 | | (class, self) [INFO] [stderr] 40 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 45 | | (class_copy, class_loader) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ help: consider using: `self.class_map.entry(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rtda/heap/class_loader.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | let class = Rc::clone(self.class_map.get(&name).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_map[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rtda/heap/class_loader.rs:137:57 [INFO] [stderr] | [INFO] [stderr] 137 | let fields: Vec = fields.into_iter().map(|x| Field::new(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Field::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `rtda::thread::Thread` [INFO] [stderr] --> src/rtda/thread.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Thread { [INFO] [stderr] 12 | | Thread { [INFO] [stderr] 13 | | stack: Stack::new(STACK_SIZE), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for rtda::thread::Thread { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a `i32` to a `f32` [INFO] [stderr] --> src/util/converter.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | unsafe { std::mem::transmute::(val) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | let q: u32 = (((x & 0xf) as u32) << 12) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(x & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:63:28 [INFO] [stderr] | [INFO] [stderr] 63 | + (((y & 0x3f) as u32) << 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(y & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | + ((z & 0x3f) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(z & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | + (((v & 0x0f) as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v & 0x0f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:92:40 [INFO] [stderr] | [INFO] [stderr] 92 | + (((w & 0x3f) as u32) << 10) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(w & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:93:40 [INFO] [stderr] | [INFO] [stderr] 93 | + (((y & 0x0f) as u32) << 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(y & 0x0f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:94:39 [INFO] [stderr] | [INFO] [stderr] 94 | + ((z & 0x3f) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(z & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `jvm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/operand_stack.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | _ => panic!(), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/rtda/vars.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | _ => panic!("get_int from wrong place"), [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/classpath/classpath.rs:98:23 [INFO] [stderr] | [INFO] [stderr] 98 | .or_else(|x| self.user.read_class(&class_file_name)) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_IFEQ_fail` [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | fn test_IFEQ_fail() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_IFNE_fail` [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:257:5 [INFO] [stderr] | [INFO] [stderr] 257 | fn test_IFNE_fail() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_IFLT_fail` [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | fn test_IFLT_fail() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_IFGE_fail` [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | fn test_IFGE_fail() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_IFGT_fail` [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:524:5 [INFO] [stderr] | [INFO] [stderr] 524 | fn test_IFGT_fail() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_IFLE_fail` [INFO] [stderr] --> src/instruction/comparison/ifcond.rs:613:5 [INFO] [stderr] | [INFO] [stderr] 613 | fn test_IFLE_fail() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `ILOAD_0` [INFO] [stderr] --> src/instruction/load/iload.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn ILOAD_0(code_reader: CodeReader, thread: Thread) -> (ExecuteResult, CodeReader) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `LADD` [INFO] [stderr] --> src/instruction/math/add.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn LADD(code_reader: CodeReader, thread: Thread) -> (ExecuteResult, CodeReader) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PUBLIC` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub const ACC_PUBLIC: u16 = 0x0001; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PRIVATE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | pub const ACC_PRIVATE: u16 = 0x0002; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_PROTECTED` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const ACC_PROTECTED: u16 = 0x0004; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_SUPER` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub const ACC_SUPER: u16 = 0x0020; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_SYNCHRONIZED` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub const ACC_SYNCHRONIZED: u16 = 0x0020; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_VOLATILE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub const ACC_VOLATILE: u16 = 0x0040; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_BRIDGE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub const ACC_BRIDGE: u16 = 0x0040; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_TRANSIENT` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const ACC_TRANSIENT: u16 = 0x0080; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_VARARGS` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub const ACC_VARARGS: u16 = 0x0080; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_NATIVE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub const ACC_NATIVE: u16 = 0x0100; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_INTERFACE` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub const ACC_INTERFACE: u16 = 0x0200; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_ABSTRACT` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub const ACC_ABSTRACT: u16 = 0x0400; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_STRICT` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub const ACC_STRICT: u16 = 0x0800; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_SYNTHETIC` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub const ACC_SYNTHETIC: u16 = 0x1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_ANNOTATION` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub const ACC_ANNOTATION: u16 = 0x2000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ACC_ENUM` [INFO] [stderr] --> src/rtda/heap/access_flags.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub const ACC_ENUM: u16 = 0x4000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Object` [INFO] [stderr] --> src/rtda/heap/object.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | struct Object { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/classfile/class_file.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn main_method<'a>(&'a self) -> &'a MemberInfo { [INFO] [stderr] 21 | | self.methods [INFO] [stderr] 22 | | .iter() [INFO] [stderr] 23 | | .find(|x| x.name == "main" && x.descriptor == "([Ljava/lang/String;)V") [INFO] [stderr] 24 | | .expect("Main method not found") [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/classfile/class_reader.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | i = i + add; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `i += add` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> src/classfile/class_reader.rs:505:5 [INFO] [stderr] | [INFO] [stderr] 505 | / fn parse() { [INFO] [stderr] 506 | | // todo: assert access_flags [INFO] [stderr] 507 | | let path: &str = "src/test_data/Object.class"; [INFO] [stderr] 508 | | let input = File::open(path).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 631 | | } [INFO] [stderr] 632 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/classfile/class_reader.rs:567:15 [INFO] [stderr] | [INFO] [stderr] 567 | match methods.get(2).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&methods[2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/classfile/class_reader.rs:581:15 [INFO] [stderr] | [INFO] [stderr] 581 | match methods.get(13).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&methods[13]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/classfile/class_reader.rs:593:23 [INFO] [stderr] | [INFO] [stderr] 593 | match attributes.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&attributes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/classfile/class_reader.rs:606:31 [INFO] [stderr] | [INFO] [stderr] 606 | match attributes.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&attributes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/classfile/class_reader.rs:608:39 [INFO] [stderr] | [INFO] [stderr] 608 | match line_number_table.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&line_number_table[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/classfile/class_reader.rs:626:15 [INFO] [stderr] | [INFO] [stderr] 626 | match attributes.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&attributes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/classpath/classpath.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | if path.ends_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/classpath/classpath.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | .unwrap_or(Err(Error::new(ErrorKind::Other, "Class not found"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Err(Error::new(ErrorKind::Other, "Class not found")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/classpath/classpath.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | file.read_to_end(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/classpath/classpath.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | let cp = cp_opt.unwrap_or(".".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(val1 - val2).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/comparison/dcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(val1 - val2).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/comparison/fcmp.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | } else if val1 == val2 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/constant/xconst.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!(val, 0f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/constant/xconst.rs:388:9 [INFO] [stderr] | [INFO] [stderr] 388 | assert_eq!(val, 0f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/constant/xconst.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | assert_eq!(val, 1f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/constant/xconst.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | assert_eq!(val, 1f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/constant/xconst.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!(val, 0f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/constant/xconst.rs:454:9 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!(val, 0f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/constant/xconst.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | assert_eq!(val, 1f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/constant/xconst.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | assert_eq!(val, 1f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/constant/xconst.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | assert_eq!(val, 2f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/constant/xconst.rs:520:9 [INFO] [stderr] | [INFO] [stderr] 520 | assert_eq!(val, 2f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/constant/xipush.rs:20:48 [INFO] [stderr] | [INFO] [stderr] 20 | let operand_stack = operand_stack.push_int(i as i32); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::E` found. Consider using it directly [INFO] [stderr] --> src/instruction/math/add.rs:214:55 [INFO] [stderr] | [INFO] [stderr] 214 | let operand_stack = operand_stack.push_double(2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/add.rs:215:55 [INFO] [stderr] | [INFO] [stderr] 215 | let operand_stack = operand_stack.push_double(3.1415926535897926f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_653_589_792_7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/add.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(val, 5.8598744820397926); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/add.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(val, 5.8598744820397926); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/add.rs:263:54 [INFO] [stderr] | [INFO] [stderr] 263 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/instruction/math/add.rs:263:54 [INFO] [stderr] | [INFO] [stderr] 263 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/add.rs:264:54 [INFO] [stderr] | [INFO] [stderr] 264 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/instruction/math/add.rs:264:54 [INFO] [stderr] | [INFO] [stderr] 264 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/add.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | assert_eq!(val, 6.2831852); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `6.283_185` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/add.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | assert_eq!(val, 6.2831852); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/add.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | assert_eq!(val, 6.2831852); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/instruction/math/inc.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let val_1 = val_1 as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(val_1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::E` found. Consider using it directly [INFO] [stderr] --> src/instruction/math/mul.rs:166:55 [INFO] [stderr] | [INFO] [stderr] 166 | let operand_stack = operand_stack.push_double(2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/mul.rs:167:55 [INFO] [stderr] | [INFO] [stderr] 167 | let operand_stack = operand_stack.push_double(3.1415926535897926f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_653_589_792_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/mul.rs:180:25 [INFO] [stderr] | [INFO] [stderr] 180 | assert_eq!(val, 8.53973422264514888498427947f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `8.539_734_222_645_15` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/mul.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | assert_eq!(val, 8.53973422264514888498427947f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/mul.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | assert_eq!(val, 8.53973422264514888498427947f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/mul.rs:215:54 [INFO] [stderr] | [INFO] [stderr] 215 | let operand_stack = operand_stack.push_float(2.71828182845f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.718_281_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f32::consts::E` found. Consider using it directly [INFO] [stderr] --> src/instruction/math/mul.rs:215:54 [INFO] [stderr] | [INFO] [stderr] 215 | let operand_stack = operand_stack.push_float(2.71828182845f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/mul.rs:216:54 [INFO] [stderr] | [INFO] [stderr] 216 | let operand_stack = operand_stack.push_float(3.1415926535897926f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/instruction/math/mul.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(val, 8.53973422264514888498427947f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `8.539_734` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/mul.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(val, 8.53973422264514888498427947f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/mul.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(val, 8.53973422264514888498427947f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/neg.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | assert_eq!(val, -2f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/neg.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | assert_eq!(val, -2f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/neg.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | assert_eq!(val, 0f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/neg.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | assert_eq!(val, 0f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/neg.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | assert_eq!(val, f64::NEG_INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/neg.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | assert_eq!(val, f64::NEG_INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/neg.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | assert_eq!(val, 100.7678f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/neg.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | assert_eq!(val, 100.7678f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/instruction/math/neg.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | assert_eq!(val, f32::MIN); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/instruction/math/neg.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | assert_eq!(val, f32::MIN); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::E` found. Consider using it directly [INFO] [stderr] --> src/rtda/frame.rs:83:55 [INFO] [stderr] | [INFO] [stderr] 83 | let operand_stack = operand_stack.push_double(2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/rtda/frame.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/rtda/frame.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let operand_stack = operand_stack.push_float(3.1415926); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/rtda/frame.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(val, 3.1415926); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/rtda/frame.rs:88:25 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(val, 3.1415926); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rtda/frame.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(val, 3.1415926); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rtda/frame.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(val, 3.1415926); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::E` found. Consider using it directly [INFO] [stderr] --> src/rtda/frame.rs:94:25 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(val, 2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rtda/frame.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(val, 2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rtda/frame.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(val, 2.71828182845f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/rtda/heap/class_loader.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / if self.class_map.contains_key(&name) { [INFO] [stderr] 38 | | let class = Rc::clone(self.class_map.get(&name).unwrap()); [INFO] [stderr] 39 | | (class, self) [INFO] [stderr] 40 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 45 | | (class_copy, class_loader) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ help: consider using: `self.class_map.entry(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/rtda/heap/class_loader.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | let class = Rc::clone(self.class_map.get(&name).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.class_map[&name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rtda/heap/class_loader.rs:137:57 [INFO] [stderr] | [INFO] [stderr] 137 | let fields: Vec = fields.into_iter().map(|x| Field::new(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Field::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `rtda::thread::Thread` [INFO] [stderr] --> src/rtda/thread.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Thread { [INFO] [stderr] 12 | | Thread { [INFO] [stderr] 13 | | stack: Stack::new(STACK_SIZE), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for rtda::thread::Thread { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a `i32` to a `f32` [INFO] [stderr] --> src/util/converter.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | unsafe { std::mem::transmute::(val) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | let q: u32 = (((x & 0xf) as u32) << 12) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(x & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:63:28 [INFO] [stderr] | [INFO] [stderr] 63 | + (((y & 0x3f) as u32) << 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(y & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | + ((z & 0x3f) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(z & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:91:40 [INFO] [stderr] | [INFO] [stderr] 91 | + (((v & 0x0f) as u32) << 16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v & 0x0f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:92:40 [INFO] [stderr] | [INFO] [stderr] 92 | + (((w & 0x3f) as u32) << 10) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(w & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:93:40 [INFO] [stderr] | [INFO] [stderr] 93 | + (((y & 0x0f) as u32) << 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(y & 0x0f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/modified_utf8.rs:94:39 [INFO] [stderr] | [INFO] [stderr] 94 | + ((z & 0x3f) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(z & 0x3f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 27 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `jvm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b01311a8bf980d52d3891bdf42b1d2673e0a6e704f69f3a007f83c2f7a8601a9"` [INFO] running `"docker" "rm" "-f" "b01311a8bf980d52d3891bdf42b1d2673e0a6e704f69f3a007f83c2f7a8601a9"` [INFO] [stdout] b01311a8bf980d52d3891bdf42b1d2673e0a6e704f69f3a007f83c2f7a8601a9