[INFO] updating cached repository stallmanifold/sudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stallmanifold/sudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stallmanifold/sudoku" "work/ex/clippy-test-run/sources/stable/gh/stallmanifold/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stallmanifold/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stallmanifold/sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d02ef752646781f4d2a101022c2c066783c930ce [INFO] sha for GitHub repo stallmanifold/sudoku: d02ef752646781f4d2a101022c2c066783c930ce [INFO] validating manifest of stallmanifold/sudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stallmanifold/sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stallmanifold/sudoku [INFO] finished frobbing stallmanifold/sudoku [INFO] frobbed toml for stallmanifold/sudoku written to work/ex/clippy-test-run/sources/stable/gh/stallmanifold/sudoku/Cargo.toml [INFO] started frobbing stallmanifold/sudoku [INFO] finished frobbing stallmanifold/sudoku [INFO] frobbed toml for stallmanifold/sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/sudoku/Cargo.toml [INFO] crate stallmanifold/sudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stallmanifold/sudoku against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stallmanifold/sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35d40999b8619cef2d1fa4e77f2cacba563d2d6e195ddf4af9b1cb12f4884151 [INFO] running `"docker" "start" "-a" "35d40999b8619cef2d1fa4e77f2cacba563d2d6e195ddf4af9b1cb12f4884151"` [INFO] [stderr] Compiling libc v0.2.26 [INFO] [stderr] Checking odds v0.2.25 [INFO] [stderr] Checking adler32 v1.0.0 [INFO] [stderr] Checking linked-hash-map v0.0.10 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Compiling xml-rs v0.6.0 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking shared_library v0.1.6 [INFO] [stderr] Checking vecmath v0.3.0 [INFO] [stderr] Compiling wayland-scanner v0.9.9 [INFO] [stderr] Checking deflate v0.7.14 [INFO] [stderr] Checking pistoncore-input v0.18.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking piston2d-graphics v0.21.1 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling wayland-client v0.9.9 [INFO] [stderr] Checking arrayvec v0.3.23 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking pistoncore-window v0.27.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking pistoncore-event_loop v0.32.0 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Compiling gl v0.6.3 [INFO] [stderr] Compiling glutin v0.9.1 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking piston v0.32.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.45.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.9 [INFO] [stderr] Checking wayland-window v0.6.1 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking winit v0.7.5 [INFO] [stderr] Checking pistoncore-glutin_window v0.38.0 [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_controller.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_controller.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/gameboard_view.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | /// Draw characters. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/gameboard_view.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | /// Draw characters. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Gameboard { [INFO] [stderr] 16 | | Gameboard { [INFO] [stderr] 17 | | cells: [[0; SIZE]; SIZE], [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings` [INFO] [stderr] --> src/gameboard_view.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> GameboardViewSettings { [INFO] [stderr] 39 | | GameboardViewSettings { [INFO] [stderr] 40 | | position: [10.0; 2], [INFO] [stderr] 41 | | size: 400.0, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_view.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:134:44 [INFO] [stderr] | [INFO] [stderr] 134 | let x = settings.position[0] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | let y = settings.position[1] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:150:44 [INFO] [stderr] | [INFO] [stderr] 150 | let x = settings.position[0] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:151:44 [INFO] [stderr] | [INFO] [stderr] 151 | let y = settings.position[1] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Gameboard { [INFO] [stderr] 16 | | Gameboard { [INFO] [stderr] 17 | | cells: [[0; SIZE]; SIZE], [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings` [INFO] [stderr] --> src/gameboard_view.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> GameboardViewSettings { [INFO] [stderr] 39 | | GameboardViewSettings { [INFO] [stderr] 40 | | position: [10.0; 2], [INFO] [stderr] 41 | | size: 400.0, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_view.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:134:44 [INFO] [stderr] | [INFO] [stderr] 134 | let x = settings.position[0] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:135:44 [INFO] [stderr] | [INFO] [stderr] 135 | let y = settings.position[1] + i as f64 / 9.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:150:44 [INFO] [stderr] | [INFO] [stderr] 150 | let x = settings.position[0] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:151:44 [INFO] [stderr] | [INFO] [stderr] 151 | let y = settings.position[1] + i as f64 / 3.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.50s [INFO] running `"docker" "inspect" "35d40999b8619cef2d1fa4e77f2cacba563d2d6e195ddf4af9b1cb12f4884151"` [INFO] running `"docker" "rm" "-f" "35d40999b8619cef2d1fa4e77f2cacba563d2d6e195ddf4af9b1cb12f4884151"` [INFO] [stdout] 35d40999b8619cef2d1fa4e77f2cacba563d2d6e195ddf4af9b1cb12f4884151