[INFO] updating cached repository stallmanifold/rtfm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stallmanifold/rtfm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stallmanifold/rtfm" "work/ex/clippy-test-run/sources/stable/gh/stallmanifold/rtfm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stallmanifold/rtfm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stallmanifold/rtfm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/rtfm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/rtfm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 63eaeef0cd581d5f5620d1e79a5b8734d8f2257c [INFO] sha for GitHub repo stallmanifold/rtfm: 63eaeef0cd581d5f5620d1e79a5b8734d8f2257c [INFO] validating manifest of stallmanifold/rtfm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stallmanifold/rtfm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stallmanifold/rtfm [INFO] finished frobbing stallmanifold/rtfm [INFO] frobbed toml for stallmanifold/rtfm written to work/ex/clippy-test-run/sources/stable/gh/stallmanifold/rtfm/Cargo.toml [INFO] started frobbing stallmanifold/rtfm [INFO] finished frobbing stallmanifold/rtfm [INFO] frobbed toml for stallmanifold/rtfm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/rtfm/Cargo.toml [INFO] crate stallmanifold/rtfm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stallmanifold/rtfm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/stallmanifold/rtfm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eec5e5cfc0fd1bf102c72c49a268113d2c8f4e6372b3574d8df4af9ed2d9ca68 [INFO] running `"docker" "start" "-a" "eec5e5cfc0fd1bf102c72c49a268113d2c8f4e6372b3574d8df4af9ed2d9ca68"` [INFO] [stderr] Checking toml v0.4.8 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking rand v0.6.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking rtfm v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:186:20 [INFO] [stderr] | [INFO] [stderr] 186 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:186:20 [INFO] [stderr] | [INFO] [stderr] 186 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / match action { [INFO] [stderr] 234 | | &Action::DefaultMessage => { [INFO] [stderr] 235 | | run_default_message(config); [INFO] [stderr] 236 | | } [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 233 | match *action { [INFO] [stderr] 234 | Action::DefaultMessage => { [INFO] [stderr] 235 | run_default_message(config); [INFO] [stderr] 236 | } [INFO] [stderr] 237 | Action::FetchManual(ref program_name) => { [INFO] [stderr] 238 | run_fetch_manual(&program_name); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | config_file.write(b"# Place your insults here\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | config_file.write(b"insults = [\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | config_file.write(b" \"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | config_file.write(string.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | config_file.write(b"\",\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | config_file.write(b"]\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / if config_file.exists() { [INFO] [stderr] 277 | | return true; [INFO] [stderr] 278 | | } else { [INFO] [stderr] 279 | | return false; [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return config_file.exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / match action { [INFO] [stderr] 234 | | &Action::DefaultMessage => { [INFO] [stderr] 235 | | run_default_message(config); [INFO] [stderr] 236 | | } [INFO] [stderr] ... | [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 233 | match *action { [INFO] [stderr] 234 | Action::DefaultMessage => { [INFO] [stderr] 235 | run_default_message(config); [INFO] [stderr] 236 | } [INFO] [stderr] 237 | Action::FetchManual(ref program_name) => { [INFO] [stderr] 238 | run_fetch_manual(&program_name); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | config_file.write(b"# Place your insults here\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | config_file.write(b"insults = [\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | config_file.write(b" \"")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | config_file.write(string.as_ref())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | config_file.write(b"\",\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | config_file.write(b"]\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / if config_file.exists() { [INFO] [stderr] 277 | | return true; [INFO] [stderr] 278 | | } else { [INFO] [stderr] 279 | | return false; [INFO] [stderr] 280 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `return config_file.exists()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rtfm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rtfm`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eec5e5cfc0fd1bf102c72c49a268113d2c8f4e6372b3574d8df4af9ed2d9ca68"` [INFO] running `"docker" "rm" "-f" "eec5e5cfc0fd1bf102c72c49a268113d2c8f4e6372b3574d8df4af9ed2d9ca68"` [INFO] [stdout] eec5e5cfc0fd1bf102c72c49a268113d2c8f4e6372b3574d8df4af9ed2d9ca68