[INFO] updating cached repository sstelfox/stream_manager [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sstelfox/stream_manager [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sstelfox/stream_manager" "work/ex/clippy-test-run/sources/stable/gh/sstelfox/stream_manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sstelfox/stream_manager'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sstelfox/stream_manager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sstelfox/stream_manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sstelfox/stream_manager'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5f532895084af0ef98b593684aa8be14cd1ddc4 [INFO] sha for GitHub repo sstelfox/stream_manager: b5f532895084af0ef98b593684aa8be14cd1ddc4 [INFO] validating manifest of sstelfox/stream_manager on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sstelfox/stream_manager on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sstelfox/stream_manager [INFO] finished frobbing sstelfox/stream_manager [INFO] frobbed toml for sstelfox/stream_manager written to work/ex/clippy-test-run/sources/stable/gh/sstelfox/stream_manager/Cargo.toml [INFO] started frobbing sstelfox/stream_manager [INFO] finished frobbing sstelfox/stream_manager [INFO] frobbed toml for sstelfox/stream_manager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sstelfox/stream_manager/Cargo.toml [INFO] crate sstelfox/stream_manager has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sstelfox/stream_manager against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sstelfox/stream_manager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fe945ccf6fc7d7275d67a44dd301a10138c6e16a6ee82e5519ce666b41bc19f [INFO] running `"docker" "start" "-a" "8fe945ccf6fc7d7275d67a44dd301a10138c6e16a6ee82e5519ce666b41bc19f"` [INFO] [stderr] Compiling actix-web v0.6.14 [INFO] [stderr] Checking want v0.0.5 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.22 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Compiling backtrace v0.3.9 [INFO] [stderr] Checking mime v0.3.8 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.5 [INFO] [stderr] Compiling cargo_metadata v0.5.8 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking hyper v0.12.5 [INFO] [stderr] Compiling actix v0.5.8 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking stream_manager v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:22 [INFO] [stderr] | [INFO] [stderr] 206 | Ok(state) => return Ok(String::from(state)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from(state))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:207:19 [INFO] [stderr] | [INFO] [stderr] 207 | Err(_) => return Err(OAuthError::InvalidContent), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OAuthError::InvalidContent)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:206:22 [INFO] [stderr] | [INFO] [stderr] 206 | Ok(state) => return Ok(String::from(state)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from(state))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:207:19 [INFO] [stderr] | [INFO] [stderr] 207 | Err(_) => return Err(OAuthError::InvalidContent), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(OAuthError::InvalidContent)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:174:45 [INFO] [stderr] | [INFO] [stderr] 174 | let components: Vec<&str> = state.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:223:12 [INFO] [stderr] | [INFO] [stderr] 223 | if let Err(_) = seal_in_place(&sealing_key, &nonce, &[], &mut padded_state, CHACHA20_POLY1305.tag_len()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 224 | | return Err(OAuthError::EncryptionFailure); [INFO] [stderr] 225 | | }; [INFO] [stderr] | |_____- help: try this: `if seal_in_place(&sealing_key, &nonce, &[], &mut padded_state, CHACHA20_POLY1305.tag_len()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:174:45 [INFO] [stderr] | [INFO] [stderr] 174 | let components: Vec<&str> = state.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:223:12 [INFO] [stderr] | [INFO] [stderr] 223 | if let Err(_) = seal_in_place(&sealing_key, &nonce, &[], &mut padded_state, CHACHA20_POLY1305.tag_len()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 224 | | return Err(OAuthError::EncryptionFailure); [INFO] [stderr] 225 | | }; [INFO] [stderr] | |_____- help: try this: `if seal_in_place(&sealing_key, &nonce, &[], &mut padded_state, CHACHA20_POLY1305.tag_len()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `"docker" "inspect" "8fe945ccf6fc7d7275d67a44dd301a10138c6e16a6ee82e5519ce666b41bc19f"` [INFO] running `"docker" "rm" "-f" "8fe945ccf6fc7d7275d67a44dd301a10138c6e16a6ee82e5519ce666b41bc19f"` [INFO] [stdout] 8fe945ccf6fc7d7275d67a44dd301a10138c6e16a6ee82e5519ce666b41bc19f