[INFO] updating cached repository sstelfox/scout [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sstelfox/scout [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sstelfox/scout" "work/ex/clippy-test-run/sources/stable/gh/sstelfox/scout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sstelfox/scout'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sstelfox/scout" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sstelfox/scout"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sstelfox/scout'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 18f65cf358d120009554e2e333e17fe2c93fe1ff [INFO] sha for GitHub repo sstelfox/scout: 18f65cf358d120009554e2e333e17fe2c93fe1ff [INFO] validating manifest of sstelfox/scout on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sstelfox/scout on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sstelfox/scout [INFO] finished frobbing sstelfox/scout [INFO] frobbed toml for sstelfox/scout written to work/ex/clippy-test-run/sources/stable/gh/sstelfox/scout/Cargo.toml [INFO] started frobbing sstelfox/scout [INFO] finished frobbing sstelfox/scout [INFO] frobbed toml for sstelfox/scout written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sstelfox/scout/Cargo.toml [INFO] crate sstelfox/scout has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sstelfox/scout against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sstelfox/scout:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 284da268bafb0465ddb18b85305ac3a9666baf2aea0550fe6c20c938b4e4f39d [INFO] running `"docker" "start" "-a" "284da268bafb0465ddb18b85305ac3a9666baf2aea0550fe6c20c938b4e4f39d"` [INFO] [stderr] Compiling rustc-demangle v0.1.8 [INFO] [stderr] Checking smallvec v0.6.2 [INFO] [stderr] Compiling actix-web v0.6.13 [INFO] [stderr] Compiling syntex_fmt_macros v0.5.0 [INFO] [stderr] Checking futures-core v0.2.1 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking tokio-timer v0.2.4 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking http v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Compiling serde_json v1.0.21 [INFO] [stderr] Checking futures-channel v0.2.1 [INFO] [stderr] Checking futures-io v0.2.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Compiling backtrace v0.3.8 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking futures-sink v0.2.1 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking futures-util v0.2.1 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.9 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking futures-executor v0.2.1 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking futures-stable v0.2.1 [INFO] [stderr] Checking futures-async-runtime v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Compiling derive-error-chain v0.11.2 [INFO] [stderr] Checking futures v0.2.1 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Checking dotenv v0.12.0 [INFO] [stderr] Compiling cargo_metadata v0.5.6 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling actix v0.5.8 [INFO] [stderr] Checking scout v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / return App::new() [INFO] [stderr] 143 | | .middleware(middleware::Logger::default()) [INFO] [stderr] 144 | | .resource("/ana", |r| r.method(Method::POST).with(analytics_handling)) [INFO] [stderr] 145 | | .resource("/err", |r| r.method(Method::POST).with(error_report_handling)) [INFO] [stderr] ... | [INFO] [stderr] 149 | | r.route().filter(pred::Not(pred::Get())).f( |_req| HttpResponse::MethodNotAllowed()); [INFO] [stderr] 150 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 142 | App::new() [INFO] [stderr] 143 | .middleware(middleware::Logger::default()) [INFO] [stderr] 144 | .resource("/ana", |r| r.method(Method::POST).with(analytics_handling)) [INFO] [stderr] 145 | .resource("/err", |r| r.method(Method::POST).with(error_report_handling)) [INFO] [stderr] 146 | .resource("/t.js", |r| r.method(Method::GET).f(track_script)) [INFO] [stderr] 147 | .default_resource( |r| { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / return App::new() [INFO] [stderr] 179 | | .middleware(middleware::Logger::default()) [INFO] [stderr] 180 | | .resource("/", |r| r.method(Method::GET).f(index)) [INFO] [stderr] 181 | | .resource("/favicon.ico", |r| r.method(Method::GET).f(favicon)) [INFO] [stderr] ... | [INFO] [stderr] 186 | | r.route().filter(pred::Not(pred::Get())).f( |_req| HttpResponse::MethodNotAllowed() ); [INFO] [stderr] 187 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | App::new() [INFO] [stderr] 179 | .middleware(middleware::Logger::default()) [INFO] [stderr] 180 | .resource("/", |r| r.method(Method::GET).f(index)) [INFO] [stderr] 181 | .resource("/favicon.ico", |r| r.method(Method::GET).f(favicon)) [INFO] [stderr] 182 | .resource("/page1.html", |r| r.method(Method::GET).f(page_one)) [INFO] [stderr] 183 | .resource("/page2.html", |r| r.method(Method::GET).f(page_two)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | / return App::new() [INFO] [stderr] 143 | | .middleware(middleware::Logger::default()) [INFO] [stderr] 144 | | .resource("/ana", |r| r.method(Method::POST).with(analytics_handling)) [INFO] [stderr] 145 | | .resource("/err", |r| r.method(Method::POST).with(error_report_handling)) [INFO] [stderr] ... | [INFO] [stderr] 149 | | r.route().filter(pred::Not(pred::Get())).f( |_req| HttpResponse::MethodNotAllowed()); [INFO] [stderr] 150 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 142 | App::new() [INFO] [stderr] 143 | .middleware(middleware::Logger::default()) [INFO] [stderr] 144 | .resource("/ana", |r| r.method(Method::POST).with(analytics_handling)) [INFO] [stderr] 145 | .resource("/err", |r| r.method(Method::POST).with(error_report_handling)) [INFO] [stderr] 146 | .resource("/t.js", |r| r.method(Method::GET).f(track_script)) [INFO] [stderr] 147 | .default_resource( |r| { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / return App::new() [INFO] [stderr] 179 | | .middleware(middleware::Logger::default()) [INFO] [stderr] 180 | | .resource("/", |r| r.method(Method::GET).f(index)) [INFO] [stderr] 181 | | .resource("/favicon.ico", |r| r.method(Method::GET).f(favicon)) [INFO] [stderr] ... | [INFO] [stderr] 186 | | r.route().filter(pred::Not(pred::Get())).f( |_req| HttpResponse::MethodNotAllowed() ); [INFO] [stderr] 187 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | App::new() [INFO] [stderr] 179 | .middleware(middleware::Logger::default()) [INFO] [stderr] 180 | .resource("/", |r| r.method(Method::GET).f(index)) [INFO] [stderr] 181 | .resource("/favicon.ico", |r| r.method(Method::GET).f(favicon)) [INFO] [stderr] 182 | .resource("/page1.html", |r| r.method(Method::GET).f(page_one)) [INFO] [stderr] 183 | .resource("/page2.html", |r| r.method(Method::GET).f(page_two)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 33s [INFO] running `"docker" "inspect" "284da268bafb0465ddb18b85305ac3a9666baf2aea0550fe6c20c938b4e4f39d"` [INFO] running `"docker" "rm" "-f" "284da268bafb0465ddb18b85305ac3a9666baf2aea0550fe6c20c938b4e4f39d"` [INFO] [stdout] 284da268bafb0465ddb18b85305ac3a9666baf2aea0550fe6c20c938b4e4f39d