[INFO] updating cached repository sssilver/chest [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sssilver/chest [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sssilver/chest" "work/ex/clippy-test-run/sources/stable/gh/sssilver/chest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sssilver/chest'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sssilver/chest" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sssilver/chest"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sssilver/chest'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb7bf937571a76ed47f18f6c5e5b9f7de5900f22 [INFO] sha for GitHub repo sssilver/chest: cb7bf937571a76ed47f18f6c5e5b9f7de5900f22 [INFO] validating manifest of sssilver/chest on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sssilver/chest on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sssilver/chest [INFO] finished frobbing sssilver/chest [INFO] frobbed toml for sssilver/chest written to work/ex/clippy-test-run/sources/stable/gh/sssilver/chest/Cargo.toml [INFO] started frobbing sssilver/chest [INFO] finished frobbing sssilver/chest [INFO] frobbed toml for sssilver/chest written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sssilver/chest/Cargo.toml [INFO] crate sssilver/chest has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sssilver/chest against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sssilver/chest:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 172f3eeb05fcb4d13bc28a15b5b9bcea2888b84b059522db9f9a229c3d291f12 [INFO] running `"docker" "start" "-a" "172f3eeb05fcb4d13bc28a15b5b9bcea2888b84b059522db9f9a229c3d291f12"` [INFO] [stderr] Checking chest v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/args.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/args.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/args.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/args.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message` [INFO] [stderr] --> src/error.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | ChestError::Generic(ref message) => None, [INFO] [stderr] | ^^^^^^^ help: consider using `_message` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/command/create.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | Err(err) => return Err(Box::new(ChestError::Generic("Error with the filesystem".to_string()))) [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/command/add.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/command/add.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/command/update.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/command/update.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/command/remove.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/command/remove.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `message` [INFO] [stderr] --> src/error.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | ChestError::Generic(ref message) => None, [INFO] [stderr] | ^^^^^^^ help: consider using `_message` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/command/create.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | Err(err) => return Err(Box::new(ChestError::Generic("Error with the filesystem".to_string()))) [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/command/add.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/command/add.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/command/update.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/command/update.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/command/remove.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `params` [INFO] [stderr] --> src/command/remove.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | fn run(&self, filename: String, params: Vec) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^ help: consider using `_params` instead [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Err` [INFO] [stderr] --> src/command/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | type Err = String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Err` [INFO] [stderr] --> src/command/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | type Err = String; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/create.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | if params.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/command/create.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | if params.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "172f3eeb05fcb4d13bc28a15b5b9bcea2888b84b059522db9f9a229c3d291f12"` [INFO] running `"docker" "rm" "-f" "172f3eeb05fcb4d13bc28a15b5b9bcea2888b84b059522db9f9a229c3d291f12"` [INFO] [stdout] 172f3eeb05fcb4d13bc28a15b5b9bcea2888b84b059522db9f9a229c3d291f12