[INFO] updating cached repository sscdotopen/puppies
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sscdotopen/puppies
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sscdotopen/puppies" "work/ex/clippy-test-run/sources/stable/gh/sscdotopen/puppies"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sscdotopen/puppies'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sscdotopen/puppies" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sscdotopen/puppies"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sscdotopen/puppies'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c51e6a702c8cdbe4d8d271cce9687174af290b8f
[INFO] sha for GitHub repo sscdotopen/puppies: c51e6a702c8cdbe4d8d271cce9687174af290b8f
[INFO] validating manifest of sscdotopen/puppies on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sscdotopen/puppies on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sscdotopen/puppies
[INFO] finished frobbing sscdotopen/puppies
[INFO] frobbed toml for sscdotopen/puppies written to work/ex/clippy-test-run/sources/stable/gh/sscdotopen/puppies/Cargo.toml
[INFO] started frobbing sscdotopen/puppies
[INFO] finished frobbing sscdotopen/puppies
[INFO] frobbed toml for sscdotopen/puppies written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sscdotopen/puppies/Cargo.toml
[INFO] crate sscdotopen/puppies has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sscdotopen/puppies against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sscdotopen/puppies:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6f6b73e340745ff13c7bc1fee86286be745d9aafa0a057fbc5731d94b60c5856
[INFO] running `"docker" "start" "-a" "6f6b73e340745ff13c7bc1fee86286be745d9aafa0a057fbc5731d94b60c5856"`
[INFO] [stderr]     Checking scopeguard v0.1.2
[INFO] [stderr]     Checking variance v0.1.3
[INFO] [stderr]     Checking bencher v0.1.3
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking csv v0.15.0
[INFO] [stderr]     Checking scoped-pool v1.0.0
[INFO] [stderr]     Checking puppies v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/llr.rs:44:81
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn log_likelihood_ratio(k11: u64, k12: u64, k21: u64, k22: u64, logarithms: &Vec<f64>) -> f64 {
[INFO] [stderr]    |                                                                                 ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]  --> src/utils.rs:6:37
[INFO] [stderr]   |
[INFO] [stderr] 6 |      (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64
[INFO] [stderr]   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1_000_000)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation
[INFO] [stderr]  --> src/utils.rs:6:37
[INFO] [stderr]   |
[INFO] [stderr] 6 |      (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64
[INFO] [stderr]   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::duration_subsec)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/lib.rs:83:40
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 let mut user_history = samples_of_a.get_mut(user_idx).unwrap();
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `samples_of_a[user_idx]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:178:74
[INFO] [stderr]     |
[INFO] [stderr] 178 | fn rescore(item: u32, cooccurrence_counts: &SparseVector, row_sums_of_c: &DenseVector,
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:180:33
[INFO] [stderr]     |
[INFO] [stderr] 180 |     k: usize, logarithms_table: &Vec<f64>) {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:179:33
[INFO] [stderr]     |
[INFO] [stderr] 179 |     num_cooccurrences_observed: &u64, indicators: &Mutex<BinaryHeap<ScoredItem>>,
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:187:19
[INFO] [stderr]     |
[INFO] [stderr] 187 |         let k11 = *num_cooccurrences as u64;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(*num_cooccurrences)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:188:19
[INFO] [stderr]     |
[INFO] [stderr] 188 |         let k12 = row_sums_of_c[item as usize] as u64 - k11;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(row_sums_of_c[item as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:189:19
[INFO] [stderr]     |
[INFO] [stderr] 189 |         let k21 = row_sums_of_c[*other_item as usize] as u64 - k11;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(row_sums_of_c[*other_item as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/llr.rs:44:81
[INFO] [stderr]    |
[INFO] [stderr] 44 | pub fn log_likelihood_ratio(k11: u64, k12: u64, k21: u64, k22: u64, logarithms: &Vec<f64>) -> f64 {
[INFO] [stderr]    |                                                                                 ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/llr.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         assert_eq!(top_k[0].score, 3.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/llr.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         assert_eq!(top_k[0].score, 3.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/llr.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         assert_eq!(top_k[1].score, 2.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/llr.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         assert_eq!(top_k[1].score, 2.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/llr.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 |         assert_eq!(top_k[2].score, 1.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/llr.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 |         assert_eq!(top_k[2].score, 1.5);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]  --> src/utils.rs:6:37
[INFO] [stderr]   |
[INFO] [stderr] 6 |      (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64
[INFO] [stderr]   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos() / 1_000_000)`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation
[INFO] [stderr]  --> src/utils.rs:6:37
[INFO] [stderr]   |
[INFO] [stderr] 6 |      (duration.as_secs() * 1_000) + (duration.subsec_nanos() / 1_000_000) as u64
[INFO] [stderr]   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `duration.subsec_millis()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::duration_subsec)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/lib.rs:83:40
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 let mut user_history = samples_of_a.get_mut(user_idx).unwrap();
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `samples_of_a[user_idx]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:178:74
[INFO] [stderr]     |
[INFO] [stderr] 178 | fn rescore(item: u32, cooccurrence_counts: &SparseVector, row_sums_of_c: &DenseVector,
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:180:33
[INFO] [stderr]     |
[INFO] [stderr] 180 |     k: usize, logarithms_table: &Vec<f64>) {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: change this to: `&[f64]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:179:33
[INFO] [stderr]     |
[INFO] [stderr] 179 |     num_cooccurrences_observed: &u64, indicators: &Mutex<BinaryHeap<ScoredItem>>,
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:187:19
[INFO] [stderr]     |
[INFO] [stderr] 187 |         let k11 = *num_cooccurrences as u64;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(*num_cooccurrences)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:188:19
[INFO] [stderr]     |
[INFO] [stderr] 188 |         let k12 = row_sums_of_c[item as usize] as u64 - k11;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(row_sums_of_c[item as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:189:19
[INFO] [stderr]     |
[INFO] [stderr] 189 |         let k21 = row_sums_of_c[*other_item as usize] as u64 - k11;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(row_sums_of_c[*other_item as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `puppies`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "6f6b73e340745ff13c7bc1fee86286be745d9aafa0a057fbc5731d94b60c5856"`
[INFO] running `"docker" "rm" "-f" "6f6b73e340745ff13c7bc1fee86286be745d9aafa0a057fbc5731d94b60c5856"`
[INFO] [stdout] 6f6b73e340745ff13c7bc1fee86286be745d9aafa0a057fbc5731d94b60c5856