[INFO] updating cached repository srusskih/karacybi [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/srusskih/karacybi [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/srusskih/karacybi" "work/ex/clippy-test-run/sources/stable/gh/srusskih/karacybi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/srusskih/karacybi'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/srusskih/karacybi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srusskih/karacybi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srusskih/karacybi'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a6ecd8a6022f62f807f1bbfe0f2bf297c6797996 [INFO] sha for GitHub repo srusskih/karacybi: a6ecd8a6022f62f807f1bbfe0f2bf297c6797996 [INFO] validating manifest of srusskih/karacybi on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srusskih/karacybi on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srusskih/karacybi [INFO] finished frobbing srusskih/karacybi [INFO] frobbed toml for srusskih/karacybi written to work/ex/clippy-test-run/sources/stable/gh/srusskih/karacybi/Cargo.toml [INFO] started frobbing srusskih/karacybi [INFO] finished frobbing srusskih/karacybi [INFO] frobbed toml for srusskih/karacybi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srusskih/karacybi/Cargo.toml [INFO] crate srusskih/karacybi has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srusskih/karacybi against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/srusskih/karacybi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e2d49779f6556ad94d5904081fbef84b82f4b1ebbeb4faabacbd2ff571b0a73d [INFO] running `"docker" "start" "-a" "e2d49779f6556ad94d5904081fbef84b82f4b1ebbeb4faabacbd2ff571b0a73d"` [INFO] [stderr] Checking karacybi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | let (a, b) = x.split_at(x.len() - n / 2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:174:10 [INFO] [stderr] | [INFO] [stderr] 174 | let (c, d) = y.split_at(y.len() - n / 2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | let (c, d) = y.split_at(y.len() - n / 2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | let (a, b) = x.split_at(x.len() - n / 2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:174:10 [INFO] [stderr] | [INFO] [stderr] 174 | let (c, d) = y.split_at(y.len() - n / 2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | let (c, d) = y.split_at(y.len() - n / 2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return if x.len() > y.len() { [INFO] [stderr] 17 | | (Box::new(x.to_string()), [INFO] [stderr] 18 | | Box::new(filler.chain(y.chars()).collect::())) [INFO] [stderr] 19 | | } [INFO] [stderr] ... | [INFO] [stderr] 22 | | Box::new(y.to_string())) [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | if x.len() > y.len() { [INFO] [stderr] 17 | (Box::new(x.to_string()), [INFO] [stderr] 18 | Box::new(filler.chain(y.chars()).collect::())) [INFO] [stderr] 19 | } [INFO] [stderr] 20 | else { [INFO] [stderr] 21 | (Box::new(filler.chain(x.chars()).collect::()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return (new_x, new_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(new_x, new_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return new_x; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `new_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return Box::new(result.trim_left_matches('0').to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(result.trim_left_matches('0').to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / return sum( [INFO] [stderr] 191 | | &sum( [INFO] [stderr] 192 | | &mul_10n(&ac, (n / 2) * 2), [INFO] [stderr] 193 | | &mul_10n(&ad_bc, n / 2) [INFO] [stderr] 194 | | ), [INFO] [stderr] 195 | | &bd [INFO] [stderr] 196 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 190 | sum( [INFO] [stderr] 191 | &sum( [INFO] [stderr] 192 | &mul_10n(&ac, (n / 2) * 2), [INFO] [stderr] 193 | &mul_10n(&ad_bc, n / 2) [INFO] [stderr] 194 | ), [INFO] [stderr] 195 | &bd [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / return if x.len() > y.len() { [INFO] [stderr] 17 | | (Box::new(x.to_string()), [INFO] [stderr] 18 | | Box::new(filler.chain(y.chars()).collect::())) [INFO] [stderr] 19 | | } [INFO] [stderr] ... | [INFO] [stderr] 22 | | Box::new(y.to_string())) [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | if x.len() > y.len() { [INFO] [stderr] 17 | (Box::new(x.to_string()), [INFO] [stderr] 18 | Box::new(filler.chain(y.chars()).collect::())) [INFO] [stderr] 19 | } [INFO] [stderr] 20 | else { [INFO] [stderr] 21 | (Box::new(filler.chain(x.chars()).collect::()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return (new_x, new_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(new_x, new_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return new_x; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `new_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return Box::new(result.trim_left_matches('0').to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(result.trim_left_matches('0').to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / return sum( [INFO] [stderr] 191 | | &sum( [INFO] [stderr] 192 | | &mul_10n(&ac, (n / 2) * 2), [INFO] [stderr] 193 | | &mul_10n(&ad_bc, n / 2) [INFO] [stderr] 194 | | ), [INFO] [stderr] 195 | | &bd [INFO] [stderr] 196 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 190 | sum( [INFO] [stderr] 191 | &sum( [INFO] [stderr] 192 | &mul_10n(&ac, (n / 2) * 2), [INFO] [stderr] 193 | &mul_10n(&ad_bc, n / 2) [INFO] [stderr] 194 | ), [INFO] [stderr] 195 | &bd [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: function is never used: `mod2length` [INFO] [stderr] --> src/main.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | fn mod2length(x: &str, y:&str) -> (Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "e2d49779f6556ad94d5904081fbef84b82f4b1ebbeb4faabacbd2ff571b0a73d"` [INFO] running `"docker" "rm" "-f" "e2d49779f6556ad94d5904081fbef84b82f4b1ebbeb4faabacbd2ff571b0a73d"` [INFO] [stdout] e2d49779f6556ad94d5904081fbef84b82f4b1ebbeb4faabacbd2ff571b0a73d