[INFO] updating cached repository srttk/piston_sample [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/srttk/piston_sample [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/srttk/piston_sample" "work/ex/clippy-test-run/sources/stable/gh/srttk/piston_sample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/srttk/piston_sample'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/srttk/piston_sample" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srttk/piston_sample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srttk/piston_sample'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2dea0d084c898d7de0fba5496c3ff97df7341849 [INFO] sha for GitHub repo srttk/piston_sample: 2dea0d084c898d7de0fba5496c3ff97df7341849 [INFO] validating manifest of srttk/piston_sample on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srttk/piston_sample on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srttk/piston_sample [INFO] finished frobbing srttk/piston_sample [INFO] frobbed toml for srttk/piston_sample written to work/ex/clippy-test-run/sources/stable/gh/srttk/piston_sample/Cargo.toml [INFO] started frobbing srttk/piston_sample [INFO] finished frobbing srttk/piston_sample [INFO] frobbed toml for srttk/piston_sample written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srttk/piston_sample/Cargo.toml [INFO] crate srttk/piston_sample has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srttk/piston_sample against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/srttk/piston_sample:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 293dc5f4173460a52c26f0933be9ecb454ead643848b5b34dc23d3c5de44a157 [INFO] running `"docker" "start" "-a" "293dc5f4173460a52c26f0933be9ecb454ead643848b5b34dc23d3c5de44a157"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Compiling serde v1.0.67 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.67 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston_sample v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | (args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | (args.height / 2) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | (args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | (args.height / 2) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.60s [INFO] running `"docker" "inspect" "293dc5f4173460a52c26f0933be9ecb454ead643848b5b34dc23d3c5de44a157"` [INFO] running `"docker" "rm" "-f" "293dc5f4173460a52c26f0933be9ecb454ead643848b5b34dc23d3c5de44a157"` [INFO] [stdout] 293dc5f4173460a52c26f0933be9ecb454ead643848b5b34dc23d3c5de44a157