[INFO] updating cached repository srishanbhattarai/srt-skew [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/srishanbhattarai/srt-skew [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/srishanbhattarai/srt-skew" "work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/srt-skew"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/srt-skew'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/srishanbhattarai/srt-skew" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srishanbhattarai/srt-skew"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srishanbhattarai/srt-skew'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff15e438553fc869b8145eeaca97f117c4ea5881 [INFO] sha for GitHub repo srishanbhattarai/srt-skew: ff15e438553fc869b8145eeaca97f117c4ea5881 [INFO] validating manifest of srishanbhattarai/srt-skew on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srishanbhattarai/srt-skew on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srishanbhattarai/srt-skew [INFO] finished frobbing srishanbhattarai/srt-skew [INFO] frobbed toml for srishanbhattarai/srt-skew written to work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/srt-skew/Cargo.toml [INFO] started frobbing srishanbhattarai/srt-skew [INFO] finished frobbing srishanbhattarai/srt-skew [INFO] frobbed toml for srishanbhattarai/srt-skew written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srishanbhattarai/srt-skew/Cargo.toml [INFO] crate srishanbhattarai/srt-skew has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srishanbhattarai/srt-skew against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/srt-skew:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33f5f9d2e0072d0d49ec0b8fb3b55b27768df67524a3f4e564132590f73e1b85 [INFO] running `"docker" "start" "-a" "33f5f9d2e0072d0d49ec0b8fb3b55b27768df67524a3f4e564132590f73e1b85"` [INFO] [stderr] Checking colored v1.6.1 [INFO] [stderr] Checking srt-skew v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:55:43 [INFO] [stderr] | [INFO] [stderr] 55 | let lines: Vec<&str> = contents.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:79:54 [INFO] [stderr] | [INFO] [stderr] 79 | let mut duration_vec: Vec<&str> = duration.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:80:77 [INFO] [stderr] | [INFO] [stderr] 80 | let mut secs_with_millis: Vec<&str> = duration_vec.pop().unwrap().split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | millis = millis % 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `millis %= 1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | seconds = seconds % 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds %= 60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | minutes = minutes % 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minutes %= 60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:55:43 [INFO] [stderr] | [INFO] [stderr] 55 | let lines: Vec<&str> = contents.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:79:54 [INFO] [stderr] | [INFO] [stderr] 79 | let mut duration_vec: Vec<&str> = duration.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:80:77 [INFO] [stderr] | [INFO] [stderr] 80 | let mut secs_with_millis: Vec<&str> = duration_vec.pop().unwrap().split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | millis = millis % 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `millis %= 1000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | seconds = seconds % 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `seconds %= 60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | minutes = minutes % 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minutes %= 60` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.67s [INFO] running `"docker" "inspect" "33f5f9d2e0072d0d49ec0b8fb3b55b27768df67524a3f4e564132590f73e1b85"` [INFO] running `"docker" "rm" "-f" "33f5f9d2e0072d0d49ec0b8fb3b55b27768df67524a3f4e564132590f73e1b85"` [INFO] [stdout] 33f5f9d2e0072d0d49ec0b8fb3b55b27768df67524a3f4e564132590f73e1b85