[INFO] updating cached repository srishanbhattarai/rogan [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/srishanbhattarai/rogan [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/srishanbhattarai/rogan" "work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/rogan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/rogan'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/srishanbhattarai/rogan" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srishanbhattarai/rogan"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srishanbhattarai/rogan'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a01f4ef7056be67f41c68edabfc1267dd1d4d40 [INFO] sha for GitHub repo srishanbhattarai/rogan: 6a01f4ef7056be67f41c68edabfc1267dd1d4d40 [INFO] validating manifest of srishanbhattarai/rogan on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srishanbhattarai/rogan on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srishanbhattarai/rogan [INFO] finished frobbing srishanbhattarai/rogan [INFO] frobbed toml for srishanbhattarai/rogan written to work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/rogan/Cargo.toml [INFO] started frobbing srishanbhattarai/rogan [INFO] finished frobbing srishanbhattarai/rogan [INFO] frobbed toml for srishanbhattarai/rogan written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srishanbhattarai/rogan/Cargo.toml [INFO] crate srishanbhattarai/rogan has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srishanbhattarai/rogan against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/srishanbhattarai/rogan:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 882873fd64a33a548ffd7bf88b20aa11163a13e797327522c31e6fa32f784c60 [INFO] running `"docker" "start" "-a" "882873fd64a33a548ffd7bf88b20aa11163a13e797327522c31e6fa32f784c60"` [INFO] [stderr] Compiling openssl v0.10.12 [INFO] [stderr] Compiling openssl-sys v0.9.36 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking encoding_rs v0.8.10 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking mime v0.3.9 [INFO] [stderr] Checking libflate v0.1.18 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking rogan v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Rogan` [INFO] [stderr] --> src/lib.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Rogan { [INFO] [stderr] 7 | | Rogan {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | let url = format!("https://www.gitignore.io/api/list"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"https://www.gitignore.io/api/list".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Rogan` [INFO] [stderr] --> src/lib.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Rogan { [INFO] [stderr] 7 | | Rogan {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | let url = format!("https://www.gitignore.io/api/list"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"https://www.gitignore.io/api/list".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | let langs: Vec<&str> = lang.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | let err = format!("Could not get the list of languages"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not get the list of languages".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | let langs: Vec<&str> = lang.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | let err = format!("Could not get the list of languages"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Could not get the list of languages".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.46s [INFO] running `"docker" "inspect" "882873fd64a33a548ffd7bf88b20aa11163a13e797327522c31e6fa32f784c60"` [INFO] running `"docker" "rm" "-f" "882873fd64a33a548ffd7bf88b20aa11163a13e797327522c31e6fa32f784c60"` [INFO] [stdout] 882873fd64a33a548ffd7bf88b20aa11163a13e797327522c31e6fa32f784c60