[INFO] updating cached repository srijs/cargo-cross [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/srijs/cargo-cross [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/srijs/cargo-cross" "work/ex/clippy-test-run/sources/stable/gh/srijs/cargo-cross"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/srijs/cargo-cross'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/srijs/cargo-cross" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srijs/cargo-cross"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srijs/cargo-cross'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cbb792e7ba4d8d0ce1cf67e764f0df3fd394ecc6 [INFO] sha for GitHub repo srijs/cargo-cross: cbb792e7ba4d8d0ce1cf67e764f0df3fd394ecc6 [INFO] validating manifest of srijs/cargo-cross on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of srijs/cargo-cross on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing srijs/cargo-cross [INFO] finished frobbing srijs/cargo-cross [INFO] frobbed toml for srijs/cargo-cross written to work/ex/clippy-test-run/sources/stable/gh/srijs/cargo-cross/Cargo.toml [INFO] started frobbing srijs/cargo-cross [INFO] finished frobbing srijs/cargo-cross [INFO] frobbed toml for srijs/cargo-cross written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/srijs/cargo-cross/Cargo.toml [INFO] crate srijs/cargo-cross has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting srijs/cargo-cross against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/srijs/cargo-cross:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d3e3190cd8c50b60c7a42e9a74ee5cf6d6ce0710be384b77d1f8c4a980c8003 [INFO] running `"docker" "start" "-a" "3d3e3190cd8c50b60c7a42e9a74ee5cf6d6ce0710be384b77d1f8c4a980c8003"` [INFO] [stderr] Compiling cc v1.0.22 [INFO] [stderr] Compiling serde v1.0.75 [INFO] [stderr] Checking ascii v0.7.1 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking predicates-core v0.9.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking unicode-segmentation v1.2.1 [INFO] [stderr] Checking ringtail v0.1.1 [INFO] [stderr] Checking try_from v0.2.2 [INFO] [stderr] Checking termcolor v1.0.2 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Checking platforms v0.1.4 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking directories v1.0.1 [INFO] [stderr] Compiling filetime v0.2.1 [INFO] [stderr] Checking socket2 v0.3.7 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking predicates-tree v0.9.0 [INFO] [stderr] Checking aho-corasick v0.6.7 [INFO] [stderr] Checking combine v3.5.1 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking heck v0.3.0 [INFO] [stderr] Checking tar v0.4.16 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling libz-sys v1.0.20 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling curl-sys v0.4.8 [INFO] [stderr] Compiling lzma-sys v0.1.10 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking regex v1.0.4 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking http v0.1.10 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking predicates v0.9.0 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Checking xz2 v0.1.5 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking toml_edit v0.1.3 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Checking assert_cmd v0.9.1 [INFO] [stderr] Checking cargo-toml-builder v0.1.0 [INFO] [stderr] Checking curl v0.4.14 [INFO] [stderr] Checking chttp v0.1.5 [INFO] [stderr] Checking cargo-cross v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/toolchains.rs:201:11 [INFO] [stderr] | [INFO] [stderr] 201 | size: 26366476, [INFO] [stderr] | ^^^^^^^^ help: consider: `26_366_476` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/toolchains.rs:221:15 [INFO] [stderr] | [INFO] [stderr] 221 | size: 1437664, [INFO] [stderr] | ^^^^^^^ help: consider: `1_437_664` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/toolchains.rs:233:15 [INFO] [stderr] | [INFO] [stderr] 233 | size: 532560, [INFO] [stderr] | ^^^^^^ help: consider: `532_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/progress.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/progress.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/toolchains.rs:201:11 [INFO] [stderr] | [INFO] [stderr] 201 | size: 26366476, [INFO] [stderr] | ^^^^^^^^ help: consider: `26_366_476` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/toolchains.rs:221:15 [INFO] [stderr] | [INFO] [stderr] 221 | size: 1437664, [INFO] [stderr] | ^^^^^^^ help: consider: `1_437_664` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/toolchains.rs:233:15 [INFO] [stderr] | [INFO] [stderr] 233 | size: 532560, [INFO] [stderr] | ^^^^^^ help: consider: `532_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/progress.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | return Ok(n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/progress.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return Ok(0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 07s [INFO] running `"docker" "inspect" "3d3e3190cd8c50b60c7a42e9a74ee5cf6d6ce0710be384b77d1f8c4a980c8003"` [INFO] running `"docker" "rm" "-f" "3d3e3190cd8c50b60c7a42e9a74ee5cf6d6ce0710be384b77d1f8c4a980c8003"` [INFO] [stdout] 3d3e3190cd8c50b60c7a42e9a74ee5cf6d6ce0710be384b77d1f8c4a980c8003