[INFO] updating cached repository squidpickles/joy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/squidpickles/joy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/squidpickles/joy" "work/ex/clippy-test-run/sources/stable/gh/squidpickles/joy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/squidpickles/joy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/squidpickles/joy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/squidpickles/joy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/squidpickles/joy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9515357298ef30d83c0605f71fe3f5858682c2ee [INFO] sha for GitHub repo squidpickles/joy: 9515357298ef30d83c0605f71fe3f5858682c2ee [INFO] validating manifest of squidpickles/joy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of squidpickles/joy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing squidpickles/joy [INFO] finished frobbing squidpickles/joy [INFO] frobbed toml for squidpickles/joy written to work/ex/clippy-test-run/sources/stable/gh/squidpickles/joy/Cargo.toml [INFO] started frobbing squidpickles/joy [INFO] finished frobbing squidpickles/joy [INFO] frobbed toml for squidpickles/joy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/squidpickles/joy/Cargo.toml [INFO] crate squidpickles/joy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting squidpickles/joy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/squidpickles/joy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79efbdfed7e116b135691b9d4e0d2e3c1d49b3987b23048a6773abd4296e961a [INFO] running `"docker" "start" "-a" "79efbdfed7e116b135691b9d4e0d2e3c1d49b3987b23048a6773abd4296e961a"` [INFO] [stderr] Compiling gcc v0.3.49 [INFO] [stderr] Checking unicode-normalization v0.1.4 [INFO] [stderr] Checking quick-error v1.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.3 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.1.0 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking num_cpus v1.5.0 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking conduit-mime-types v0.7.3 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Compiling unicase v1.4.0 [INFO] [stderr] Compiling hyper v0.10.11 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking url v1.4.1 [INFO] [stderr] Checking handlebars v0.26.2 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking handlebars-iron v0.24.1 [INFO] [stderr] Checking logger v0.3.0 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking joy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(WebServer { chain: chain }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(WebServer { chain: chain }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const JOY_URL: &'static str = "https://raw.githubusercontent.com/squidpickles/slippybot/master/joy.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | const LISTEN_ADDR: &'static str = "127.0.0.1:8707"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const JOY_URL: &'static str = "https://raw.githubusercontent.com/squidpickles/slippybot/master/joy.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | const LISTEN_ADDR: &'static str = "127.0.0.1:8707"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.12s [INFO] running `"docker" "inspect" "79efbdfed7e116b135691b9d4e0d2e3c1d49b3987b23048a6773abd4296e961a"` [INFO] running `"docker" "rm" "-f" "79efbdfed7e116b135691b9d4e0d2e3c1d49b3987b23048a6773abd4296e961a"` [INFO] [stdout] 79efbdfed7e116b135691b9d4e0d2e3c1d49b3987b23048a6773abd4296e961a