[INFO] updating cached repository sputnick1124/projecteuler.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sputnick1124/projecteuler.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sputnick1124/projecteuler.rs" "work/ex/clippy-test-run/sources/stable/gh/sputnick1124/projecteuler.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sputnick1124/projecteuler.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sputnick1124/projecteuler.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sputnick1124/projecteuler.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sputnick1124/projecteuler.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 68096c84561359a166e509887aa625d849398bf3 [INFO] sha for GitHub repo sputnick1124/projecteuler.rs: 68096c84561359a166e509887aa625d849398bf3 [INFO] validating manifest of sputnick1124/projecteuler.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sputnick1124/projecteuler.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sputnick1124/projecteuler.rs [INFO] finished frobbing sputnick1124/projecteuler.rs [INFO] frobbed toml for sputnick1124/projecteuler.rs written to work/ex/clippy-test-run/sources/stable/gh/sputnick1124/projecteuler.rs/Cargo.toml [INFO] started frobbing sputnick1124/projecteuler.rs [INFO] finished frobbing sputnick1124/projecteuler.rs [INFO] frobbed toml for sputnick1124/projecteuler.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sputnick1124/projecteuler.rs/Cargo.toml [INFO] crate sputnick1124/projecteuler.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sputnick1124/projecteuler.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sputnick1124/projecteuler.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 58ac1f1eeb714e7780ba6e586121bbe2621a275bfb7ebb1d0132067883adf345 [INFO] running `"docker" "start" "-a" "58ac1f1eeb714e7780ba6e586121bbe2621a275bfb7ebb1d0132067883adf345"` [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Checking num-bigint v0.2.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | return Some(two.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(two.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return a + b + c == n [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b + c == n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:538:5 [INFO] [stderr] | [INFO] [stderr] 538 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | return Some(two.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(two.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return a + b + c == n [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b + c == n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:353:37 [INFO] [stderr] | [INFO] [stderr] 353 | assert_eq!(Some(6857), euler003(600851475143)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:380:16 [INFO] [stderr] | [INFO] [stderr] 380 | assert_eq!(906609, euler004(3)); [INFO] [stderr] | ^^^^^^ help: consider: `906_609` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:395:16 [INFO] [stderr] | [INFO] [stderr] 395 | assert_eq!(232792560, euler005(20)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `232_792_560` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:538:5 [INFO] [stderr] | [INFO] [stderr] 538 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:545:21 [INFO] [stderr] | [INFO] [stderr] 545 | assert_eq!(Some(31875000), euler009(1000)); [INFO] [stderr] | ^^^^^^^^ help: consider: `31_875_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:559:16 [INFO] [stderr] | [INFO] [stderr] 559 | assert_eq!(142913828922, euler010(2_000_000)); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `142_913_828_922` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:615:16 [INFO] [stderr] | [INFO] [stderr] 615 | assert_eq!(76576500, euler012(500)); [INFO] [stderr] | ^^^^^^^^ help: consider: `76_576_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:656:36 [INFO] [stderr] | [INFO] [stderr] 656 | assert_eq!(BigUint::from_usize(5537376230).unwrap(), euler013(10)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5_537_376_230` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:679:16 [INFO] [stderr] | [INFO] [stderr] 679 | assert_eq!(837799, euler014(1_000_000)); [INFO] [stderr] | ^^^^^^ help: consider: `837_799` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:701:36 [INFO] [stderr] | [INFO] [stderr] 701 | assert_eq!(BigUint::from_usize(137846528820).unwrap(), euler015(BigUint::from_usize(20).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `137_846_528_820` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | let mut primes: Vec = (0..n + 1) [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:148:40 [INFO] [stderr] | [INFO] [stderr] 148 | let mut res = primes.iter().skip(1).fold(1, |acc, x| acc * x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | (1..n+1).fold(0, |acc, x| acc + x.pow(2)) [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | (1..n+1).fold(0, |acc, x| acc + x).pow(2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | (1..n+1).fold(0, |acc, x| acc + x).pow(2) [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | counts.values().map(|&x| x).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `counts.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:211:42 [INFO] [stderr] | [INFO] [stderr] 211 | count_factors(find_factors(n)).iter() [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 212 | | .fold(1, |acc, x| acc*(x)) [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:286:69 [INFO] [stderr] | [INFO] [stderr] 286 | .filter_map(|x| if x%3==0 || x%5 == 0 {Some(x)} else {None}) [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 287 | | .fold(0usize, |acc, x| acc + x) [INFO] [stderr] | |_______________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | / (1..n) [INFO] [stderr] 286 | | .filter_map(|x| if x%3==0 || x%5 == 0 {Some(x)} else {None}) [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:323:62 [INFO] [stderr] | [INFO] [stderr] 323 | .filter_map(|x| if x%2 == 0 { Some(x) } else { None}) [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 324 | | .fold(0, |acc, x| acc + x) [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:321:5 [INFO] [stderr] | [INFO] [stderr] 321 | / fibs [INFO] [stderr] 322 | | .take_while(|x| x <= &n) [INFO] [stderr] 323 | | .filter_map(|x| if x%2 == 0 { Some(x) } else { None}) [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:322:25 [INFO] [stderr] | [INFO] [stderr] 322 | .take_while(|x| x <= &n) [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:553:33 [INFO] [stderr] | [INFO] [stderr] 553 | s.take_while(|x| x < &limit).fold(0usize, |acc, x| acc + x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:553:22 [INFO] [stderr] | [INFO] [stderr] 553 | s.take_while(|x| x < &limit).fold(0usize, |acc, x| acc + x) [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:608:33 [INFO] [stderr] | [INFO] [stderr] 608 | let num_factors = (2..).map(|x| tri_number(x)).filter(|x| number_of_factors(*x) > n).nth(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `tri_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | let mut primes: Vec = (0..n + 1) [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:148:40 [INFO] [stderr] | [INFO] [stderr] 148 | let mut res = primes.iter().skip(1).fold(1, |acc, x| acc * x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | (1..n+1).fold(0, |acc, x| acc + x.pow(2)) [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | (1..n+1).fold(0, |acc, x| acc + x).pow(2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | (1..n+1).fold(0, |acc, x| acc + x).pow(2) [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | counts.values().map(|&x| x).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `counts.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:211:42 [INFO] [stderr] | [INFO] [stderr] 211 | count_factors(find_factors(n)).iter() [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 212 | | .fold(1, |acc, x| acc*(x)) [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:286:69 [INFO] [stderr] | [INFO] [stderr] 286 | .filter_map(|x| if x%3==0 || x%5 == 0 {Some(x)} else {None}) [INFO] [stderr] | _____________________________________________________________________^ [INFO] [stderr] 287 | | .fold(0usize, |acc, x| acc + x) [INFO] [stderr] | |_______________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | / (1..n) [INFO] [stderr] 286 | | .filter_map(|x| if x%3==0 || x%5 == 0 {Some(x)} else {None}) [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:323:62 [INFO] [stderr] | [INFO] [stderr] 323 | .filter_map(|x| if x%2 == 0 { Some(x) } else { None}) [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 324 | | .fold(0, |acc, x| acc + x) [INFO] [stderr] | |__________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:321:5 [INFO] [stderr] | [INFO] [stderr] 321 | / fibs [INFO] [stderr] 322 | | .take_while(|x| x <= &n) [INFO] [stderr] 323 | | .filter_map(|x| if x%2 == 0 { Some(x) } else { None}) [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:322:25 [INFO] [stderr] | [INFO] [stderr] 322 | .take_while(|x| x <= &n) [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:553:33 [INFO] [stderr] | [INFO] [stderr] 553 | s.take_while(|x| x < &limit).fold(0usize, |acc, x| acc + x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:553:22 [INFO] [stderr] | [INFO] [stderr] 553 | s.take_while(|x| x < &limit).fold(0usize, |acc, x| acc + x) [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:608:33 [INFO] [stderr] | [INFO] [stderr] 608 | let num_factors = (2..).map(|x| tri_number(x)).filter(|x| number_of_factors(*x) > n).nth(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `tri_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | println!("{}", euler003(600851475143).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | println!("{}", euler003(600851475143).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.81s [INFO] running `"docker" "inspect" "58ac1f1eeb714e7780ba6e586121bbe2621a275bfb7ebb1d0132067883adf345"` [INFO] running `"docker" "rm" "-f" "58ac1f1eeb714e7780ba6e586121bbe2621a275bfb7ebb1d0132067883adf345"` [INFO] [stdout] 58ac1f1eeb714e7780ba6e586121bbe2621a275bfb7ebb1d0132067883adf345