[INFO] updating cached repository spheric/git-jira [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/spheric/git-jira [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/spheric/git-jira" "work/ex/clippy-test-run/sources/stable/gh/spheric/git-jira"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/spheric/git-jira'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/spheric/git-jira" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spheric/git-jira"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spheric/git-jira'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 83c2684245ad0bcd2acb8ecf784a9200ce8eb520 [INFO] sha for GitHub repo spheric/git-jira: 83c2684245ad0bcd2acb8ecf784a9200ce8eb520 [INFO] validating manifest of spheric/git-jira on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spheric/git-jira on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spheric/git-jira [INFO] finished frobbing spheric/git-jira [INFO] frobbed toml for spheric/git-jira written to work/ex/clippy-test-run/sources/stable/gh/spheric/git-jira/Cargo.toml [INFO] started frobbing spheric/git-jira [INFO] finished frobbing spheric/git-jira [INFO] frobbed toml for spheric/git-jira written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spheric/git-jira/Cargo.toml [INFO] crate spheric/git-jira has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spheric/git-jira against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/spheric/git-jira:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5199cc5b189ddbe092d07e5c2b092782327b123efa74343c43c5a401d1e5a7c1 [INFO] running `"docker" "start" "-a" "5199cc5b189ddbe092d07e5c2b092782327b123efa74343c43c5a401d1e5a7c1"` [INFO] [stderr] Compiling libc v0.2.41 [INFO] [stderr] Compiling serde v1.0.59 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Compiling openssl-sys v0.9.31 [INFO] [stderr] Compiling proc-macro2 v0.4.3 [INFO] [stderr] Checking base64 v0.9.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling quote v0.6.2 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking backtrace v0.3.7 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Compiling syn v0.14.0 [INFO] [stderr] Checking rayon v0.9.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling structopt-derive v0.2.8 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking structopt v0.2.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.59 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking quicli v0.2.0 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking git-jira v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | / return match env::var(env_var) { [INFO] [stderr] 78 | | Ok(r) => r, [INFO] [stderr] 79 | | Err(e) => { [INFO] [stderr] 80 | | eprintln!("Couldn't read {} ({})", env_var, e); [INFO] [stderr] 81 | | ::std::process::exit(1); [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | }; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 77 | match env::var(env_var) { [INFO] [stderr] 78 | Ok(r) => r, [INFO] [stderr] 79 | Err(e) => { [INFO] [stderr] 80 | eprintln!("Couldn't read {} ({})", env_var, e); [INFO] [stderr] 81 | ::std::process::exit(1); [INFO] [stderr] 82 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:3 [INFO] [stderr] | [INFO] [stderr] 77 | / return match env::var(env_var) { [INFO] [stderr] 78 | | Ok(r) => r, [INFO] [stderr] 79 | | Err(e) => { [INFO] [stderr] 80 | | eprintln!("Couldn't read {} ({})", env_var, e); [INFO] [stderr] 81 | | ::std::process::exit(1); [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | }; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 77 | match env::var(env_var) { [INFO] [stderr] 78 | Ok(r) => r, [INFO] [stderr] 79 | Err(e) => { [INFO] [stderr] 80 | eprintln!("Couldn't read {} ({})", env_var, e); [INFO] [stderr] 81 | ::std::process::exit(1); [INFO] [stderr] 82 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "5199cc5b189ddbe092d07e5c2b092782327b123efa74343c43c5a401d1e5a7c1"` [INFO] running `"docker" "rm" "-f" "5199cc5b189ddbe092d07e5c2b092782327b123efa74343c43c5a401d1e5a7c1"` [INFO] [stdout] 5199cc5b189ddbe092d07e5c2b092782327b123efa74343c43c5a401d1e5a7c1