[INFO] updating cached repository spacelis/vec2bin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/spacelis/vec2bin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/spacelis/vec2bin" "work/ex/clippy-test-run/sources/stable/gh/spacelis/vec2bin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/spacelis/vec2bin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/spacelis/vec2bin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacelis/vec2bin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacelis/vec2bin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b80d4e4f59d1b8efe8204ecdf20ec0685f33d75 [INFO] sha for GitHub repo spacelis/vec2bin: 3b80d4e4f59d1b8efe8204ecdf20ec0685f33d75 [INFO] validating manifest of spacelis/vec2bin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spacelis/vec2bin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spacelis/vec2bin [INFO] finished frobbing spacelis/vec2bin [INFO] frobbed toml for spacelis/vec2bin written to work/ex/clippy-test-run/sources/stable/gh/spacelis/vec2bin/Cargo.toml [INFO] started frobbing spacelis/vec2bin [INFO] finished frobbing spacelis/vec2bin [INFO] frobbed toml for spacelis/vec2bin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacelis/vec2bin/Cargo.toml [INFO] crate spacelis/vec2bin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spacelis/vec2bin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/spacelis/vec2bin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7fbe58065a837669ea5d5b884638b837fa0b2a82c83f7d17897a69d57d699b44 [INFO] running `"docker" "start" "-a" "7fbe58065a837669ea5d5b884638b837fa0b2a82c83f7d17897a69d57d699b44"` [INFO] [stderr] Compiling hdf5-sys v0.4.1 [INFO] [stderr] Checking hdf5 v0.4.1 [INFO] [stderr] Checking vec2bin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:73:78 [INFO] [stderr] | [INFO] [stderr] 73 | fn write_vec(dst_filename: &String, vec: &Vec>, m: usize, n: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:73:78 [INFO] [stderr] | [INFO] [stderr] 73 | fn write_vec(dst_filename: &String, vec: &Vec>, m: usize, n: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | fn parse_vec(src_filename: &String) -> (Vec, Vec>, usize, usize) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | let parts: Vec = line.split(" ").map(|x| x.parse().unwrap()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:60 [INFO] [stderr] | [INFO] [stderr] 50 | let mut parts: Vec = line.rsplitn(301, " ").map(String::from).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | fn write_voc(dst_filename: &String, voc: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:42 [INFO] [stderr] | [INFO] [stderr] 66 | fn write_voc(dst_filename: &String, voc: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | fn write_vec(dst_filename: &String, vec: &Vec>, m: usize, n: usize) -> () { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:73:42 [INFO] [stderr] | [INFO] [stderr] 73 | fn write_vec(dst_filename: &String, vec: &Vec>, m: usize, n: usize) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | fn parse_vec(src_filename: &String) -> (Vec, Vec>, usize, usize) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:43:48 [INFO] [stderr] | [INFO] [stderr] 43 | let parts: Vec = line.split(" ").map(|x| x.parse().unwrap()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:50:60 [INFO] [stderr] | [INFO] [stderr] 50 | let mut parts: Vec = line.rsplitn(301, " ").map(String::from).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | fn write_voc(dst_filename: &String, voc: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:66:42 [INFO] [stderr] | [INFO] [stderr] 66 | fn write_voc(dst_filename: &String, voc: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | fn write_vec(dst_filename: &String, vec: &Vec>, m: usize, n: usize) -> () { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:73:42 [INFO] [stderr] | [INFO] [stderr] 73 | fn write_vec(dst_filename: &String, vec: &Vec>, m: usize, n: usize) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 31s [INFO] running `"docker" "inspect" "7fbe58065a837669ea5d5b884638b837fa0b2a82c83f7d17897a69d57d699b44"` [INFO] running `"docker" "rm" "-f" "7fbe58065a837669ea5d5b884638b837fa0b2a82c83f7d17897a69d57d699b44"` [INFO] [stdout] 7fbe58065a837669ea5d5b884638b837fa0b2a82c83f7d17897a69d57d699b44