[INFO] updating cached repository spacekookie/just-do-it [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/spacekookie/just-do-it [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/spacekookie/just-do-it" "work/ex/clippy-test-run/sources/stable/gh/spacekookie/just-do-it"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/spacekookie/just-do-it'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/spacekookie/just-do-it" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacekookie/just-do-it"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacekookie/just-do-it'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ddd941b62680f1c9db9eaf64a757f5c129ed5a14 [INFO] sha for GitHub repo spacekookie/just-do-it: ddd941b62680f1c9db9eaf64a757f5c129ed5a14 [INFO] validating manifest of spacekookie/just-do-it on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spacekookie/just-do-it on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spacekookie/just-do-it [INFO] finished frobbing spacekookie/just-do-it [INFO] frobbed toml for spacekookie/just-do-it written to work/ex/clippy-test-run/sources/stable/gh/spacekookie/just-do-it/Cargo.toml [INFO] started frobbing spacekookie/just-do-it [INFO] finished frobbing spacekookie/just-do-it [INFO] frobbed toml for spacekookie/just-do-it written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacekookie/just-do-it/Cargo.toml [INFO] crate spacekookie/just-do-it has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spacekookie/just-do-it against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/spacekookie/just-do-it:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 797895c765610c527ddc4a459fc0197a255f2b3253dde587a9d83f9ce6c16f12 [INFO] running `"docker" "start" "-a" "797895c765610c527ddc4a459fc0197a255f2b3253dde587a9d83f9ce6c16f12"` [INFO] [stderr] Checking serde v1.0.39 [INFO] [stderr] Checking question v0.2.1 [INFO] [stderr] Checking users v0.6.1 [INFO] [stderr] Checking regex-syntax v0.5.5 [INFO] [stderr] Checking uuid v0.6.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Checking backtrace v0.3.6 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.39 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking os_type v2.0.0 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking human-panic v0.2.0 [INFO] [stderr] Checking doit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const DELETE_QUESTION: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const DELETE_QUESTION: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:107:10 [INFO] [stderr] | [INFO] [stderr] 107 | .expect(&format!("docker list failed for {:?}", &args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("docker list failed for {:?}", &args))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:128:10 [INFO] [stderr] | [INFO] [stderr] 128 | .expect(&format!("docker create failed for {:?}", &args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("docker create failed for {:?}", &args))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | .expect(&format!("docker start failed for {:?}", &args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("docker start failed for {:?}", &args))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:183:10 [INFO] [stderr] | [INFO] [stderr] 183 | .expect(&format!("Failed to run set sudo to NOPASSWD. Try running the command yourself!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to run set sudo to NOPASSWD. Try running the command yourself!"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:183:18 [INFO] [stderr] | [INFO] [stderr] 183 | .expect(&format!("Failed to run set sudo to NOPASSWD. Try running the command yourself!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to run set sudo to NOPASSWD. Try running the command yourself!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:193:32 [INFO] [stderr] | [INFO] [stderr] 193 | let splice = command.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:200:10 [INFO] [stderr] | [INFO] [stderr] 200 | .expect(&format!("Failed to run {}", command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to run {}", command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:107:10 [INFO] [stderr] | [INFO] [stderr] 107 | .expect(&format!("docker list failed for {:?}", &args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("docker list failed for {:?}", &args))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:128:10 [INFO] [stderr] | [INFO] [stderr] 128 | .expect(&format!("docker create failed for {:?}", &args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("docker create failed for {:?}", &args))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | .expect(&format!("docker start failed for {:?}", &args)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("docker start failed for {:?}", &args))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:183:10 [INFO] [stderr] | [INFO] [stderr] 183 | .expect(&format!("Failed to run set sudo to NOPASSWD. Try running the command yourself!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to run set sudo to NOPASSWD. Try running the command yourself!"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:183:18 [INFO] [stderr] | [INFO] [stderr] 183 | .expect(&format!("Failed to run set sudo to NOPASSWD. Try running the command yourself!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to run set sudo to NOPASSWD. Try running the command yourself!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:193:32 [INFO] [stderr] | [INFO] [stderr] 193 | let splice = command.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:200:10 [INFO] [stderr] | [INFO] [stderr] 200 | .expect(&format!("Failed to run {}", command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to run {}", command))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.25s [INFO] running `"docker" "inspect" "797895c765610c527ddc4a459fc0197a255f2b3253dde587a9d83f9ce6c16f12"` [INFO] running `"docker" "rm" "-f" "797895c765610c527ddc4a459fc0197a255f2b3253dde587a9d83f9ce6c16f12"` [INFO] [stdout] 797895c765610c527ddc4a459fc0197a255f2b3253dde587a9d83f9ce6c16f12