[INFO] updating cached repository spacekookie/cargo-ws-release [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/spacekookie/cargo-ws-release [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/spacekookie/cargo-ws-release" "work/ex/clippy-test-run/sources/stable/gh/spacekookie/cargo-ws-release"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/spacekookie/cargo-ws-release'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/spacekookie/cargo-ws-release" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacekookie/cargo-ws-release"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacekookie/cargo-ws-release'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41fc7e3e4ec6c4e636dc8a24100fa2f0c967b801 [INFO] sha for GitHub repo spacekookie/cargo-ws-release: 41fc7e3e4ec6c4e636dc8a24100fa2f0c967b801 [INFO] validating manifest of spacekookie/cargo-ws-release on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spacekookie/cargo-ws-release on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spacekookie/cargo-ws-release [INFO] finished frobbing spacekookie/cargo-ws-release [INFO] frobbed toml for spacekookie/cargo-ws-release written to work/ex/clippy-test-run/sources/stable/gh/spacekookie/cargo-ws-release/Cargo.toml [INFO] started frobbing spacekookie/cargo-ws-release [INFO] finished frobbing spacekookie/cargo-ws-release [INFO] frobbed toml for spacekookie/cargo-ws-release written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spacekookie/cargo-ws-release/Cargo.toml [INFO] crate spacekookie/cargo-ws-release has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spacekookie/cargo-ws-release against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/spacekookie/cargo-ws-release:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8478575d6b5d5c5e24b1edb9fc16fd97cbacb71f90b1836d2f21032069d2c072 [INFO] running `"docker" "start" "-a" "8478575d6b5d5c5e24b1edb9fc16fd97cbacb71f90b1836d2f21032069d2c072"` [INFO] [stderr] Checking ascii v0.7.1 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking combine v3.3.6 [INFO] [stderr] Checking toml_edit v0.1.3 [INFO] [stderr] Checking cargo-ws-release v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `lvl` [INFO] [stderr] --> src/lib.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn do_batch_release(f: File, lvl: &Level) -> DepGraph { [INFO] [stderr] | ^^^ help: consider using `_lvl` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lvl` [INFO] [stderr] --> src/lib.rs:14:34 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn do_batch_release(f: File, lvl: &Level) -> DepGraph { [INFO] [stderr] | ^^^ help: consider using `_lvl` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data_models::graph::DepGraph` [INFO] [stderr] --> src/data_models/graph.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | Self { [INFO] [stderr] 29 | | nodes: HashMap::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/data_models/level.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 20 | | match s { [INFO] [stderr] 21 | | "major" => Some(Level::Major), [INFO] [stderr] 22 | | "minor" => Some(Level::Minor), [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utilities/cargo_utils.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn batch_load_configs(members: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utilities/cargo_utils.rs:46:46 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn parse_config(doc: &Document, members: &Vec) -> (String, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data_models::graph::DepGraph` [INFO] [stderr] --> src/data_models/graph.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | Self { [INFO] [stderr] 29 | | nodes: HashMap::new(), [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utilities/cargo_utils.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | name: format!("{}", n), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `n.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utilities/cargo_utils.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | version: format!("{}", v), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `v.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/utilities/cargo_utils.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | Identifier::AlphaNumeric(s) => *s == prerelease_label.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/utilities/utils.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | self.iter().find(|x| x == &&t).map(|t| t.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.iter().find(|x| x == &&t).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/data_models/level.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 20 | | match s { [INFO] [stderr] 21 | | "major" => Some(Level::Major), [INFO] [stderr] 22 | | "minor" => Some(Level::Minor), [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utilities/cargo_utils.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn batch_load_configs(members: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utilities/cargo_utils.rs:46:46 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn parse_config(doc: &Document, members: &Vec) -> (String, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utilities/cargo_utils.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | name: format!("{}", n), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `n.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/utilities/cargo_utils.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | version: format!("{}", v), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `v.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/utilities/cargo_utils.rs:98:44 [INFO] [stderr] | [INFO] [stderr] 98 | Identifier::AlphaNumeric(s) => *s == prerelease_label.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/utilities/utils.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | self.iter().find(|x| x == &&t).map(|t| t.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.iter().find(|x| x == &&t).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/tests.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / dep_graph [INFO] [stderr] 23 | | .nodes [INFO] [stderr] 24 | | .get("lockchain-http") [INFO] [stderr] 25 | | .unwrap() [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | &dep_graph [INFO] [stderr] 23 | .nodes["lockchain-http"] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.06s [INFO] running `"docker" "inspect" "8478575d6b5d5c5e24b1edb9fc16fd97cbacb71f90b1836d2f21032069d2c072"` [INFO] running `"docker" "rm" "-f" "8478575d6b5d5c5e24b1edb9fc16fd97cbacb71f90b1836d2f21032069d2c072"` [INFO] [stdout] 8478575d6b5d5c5e24b1edb9fc16fd97cbacb71f90b1836d2f21032069d2c072