[INFO] updating cached repository soyuka/read-metadata [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/soyuka/read-metadata [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/soyuka/read-metadata" "work/ex/clippy-test-run/sources/stable/gh/soyuka/read-metadata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/soyuka/read-metadata'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/soyuka/read-metadata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soyuka/read-metadata"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soyuka/read-metadata'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 081328bab25b0a195b1905b28c8ea6ea342ddc0d [INFO] sha for GitHub repo soyuka/read-metadata: 081328bab25b0a195b1905b28c8ea6ea342ddc0d [INFO] validating manifest of soyuka/read-metadata on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of soyuka/read-metadata on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing soyuka/read-metadata [INFO] finished frobbing soyuka/read-metadata [INFO] frobbed toml for soyuka/read-metadata written to work/ex/clippy-test-run/sources/stable/gh/soyuka/read-metadata/Cargo.toml [INFO] started frobbing soyuka/read-metadata [INFO] finished frobbing soyuka/read-metadata [INFO] frobbed toml for soyuka/read-metadata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soyuka/read-metadata/Cargo.toml [INFO] crate soyuka/read-metadata has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting soyuka/read-metadata against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/soyuka/read-metadata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb048aba455f702947c87cf00f0f7086bbf4b22bfb5753c6c28b84e4b6e3c4a0 [INFO] running `"docker" "start" "-a" "cb048aba455f702947c87cf00f0f7086bbf4b22bfb5753c6c28b84e4b6e3c4a0"` [INFO] [stderr] Compiling procedural-masquerade v0.1.6 [INFO] [stderr] Checking ego-tree v0.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.33 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking new_debug_unreachable v1.0.1 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Compiling serde_json v1.0.21 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking futf v0.1.4 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking libflate v0.1.15 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking tendril v0.4.0 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling selectors v0.19.0 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling markup5ever v0.7.2 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Compiling cssparser v0.23.10 [INFO] [stderr] Compiling html5ever v0.22.3 [INFO] [stderr] Compiling cssparser-macros v0.3.3 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking scraper v0.7.0 [INFO] [stderr] Checking read-metadata v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / let mut value = "".to_string(); [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | if element != None { [INFO] [stderr] 62 | | value = element.unwrap().value().attr("content").unwrap().trim().to_string(); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let value = if element != None { element.unwrap().value().attr("content").unwrap().trim().to_string() } else { "".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / let mut title_value: String = "".to_string(); [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | if title != None { [INFO] [stderr] 119 | | title_value = title.unwrap().text().map(|x| x.trim()).collect(); [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let title_value = if title != None { title.unwrap().text().map(|x| x.trim()).collect() } else { "".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | io::stdout().write(&serde_json::to_vec(&o).unwrap())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `read-metadata`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / let mut value = "".to_string(); [INFO] [stderr] 60 | | [INFO] [stderr] 61 | | if element != None { [INFO] [stderr] 62 | | value = element.unwrap().value().attr("content").unwrap().trim().to_string(); [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let value = if element != None { element.unwrap().value().attr("content").unwrap().trim().to_string() } else { "".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / let mut title_value: String = "".to_string(); [INFO] [stderr] 117 | | [INFO] [stderr] 118 | | if title != None { [INFO] [stderr] 119 | | title_value = title.unwrap().text().map(|x| x.trim()).collect(); [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let title_value = if title != None { title.unwrap().text().map(|x| x.trim()).collect() } else { "".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | io::stdout().write(&serde_json::to_vec(&o).unwrap())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `read-metadata`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cb048aba455f702947c87cf00f0f7086bbf4b22bfb5753c6c28b84e4b6e3c4a0"` [INFO] running `"docker" "rm" "-f" "cb048aba455f702947c87cf00f0f7086bbf4b22bfb5753c6c28b84e4b6e3c4a0"` [INFO] [stdout] cb048aba455f702947c87cf00f0f7086bbf4b22bfb5753c6c28b84e4b6e3c4a0