[INFO] updating cached repository sourcepirate/release [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sourcepirate/release [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sourcepirate/release" "work/ex/clippy-test-run/sources/stable/gh/sourcepirate/release"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sourcepirate/release'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sourcepirate/release" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/release"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/release'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 20ce8c6f17e299676ec609b85685e7c148a0a3e3 [INFO] sha for GitHub repo sourcepirate/release: 20ce8c6f17e299676ec609b85685e7c148a0a3e3 [INFO] validating manifest of sourcepirate/release on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sourcepirate/release on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sourcepirate/release [INFO] finished frobbing sourcepirate/release [INFO] frobbed toml for sourcepirate/release written to work/ex/clippy-test-run/sources/stable/gh/sourcepirate/release/Cargo.toml [INFO] started frobbing sourcepirate/release [INFO] finished frobbing sourcepirate/release [INFO] frobbed toml for sourcepirate/release written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/release/Cargo.toml [INFO] crate sourcepirate/release has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sourcepirate/release against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sourcepirate/release:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed8af0c25c62641ff235c771dc98a883b67f8d2400fcb5c47be510994d8f7d76 [INFO] running `"docker" "start" "-a" "ed8af0c25c62641ff235c771dc98a883b67f8d2400fcb5c47be510994d8f7d76"` [INFO] [stderr] Compiling openssl-sys v0.9.22 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling cmake v0.1.28 [INFO] [stderr] Compiling curl-sys v0.3.15 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.6.16 [INFO] [stderr] Checking git2 v0.6.8 [INFO] [stderr] Checking release v0.8.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::env::current_dir` [INFO] [stderr] --> src/tags.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env::current_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env::current_dir` [INFO] [stderr] --> src/tags.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::env::current_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `E` [INFO] [stderr] --> src/main.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | Err(E) => { [INFO] [stderr] | ^ help: consider using `_E` instead [INFO] [stderr] warning: unused variable: `E` [INFO] [stderr] --> src/main.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | Err(E) => { [INFO] [stderr] | ^ help: consider using `_E` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tags.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let mut versions = self.get_tags().versions(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tags.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let mut val; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tags.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let mut obj; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/tags.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn iter(&self) -> Iter{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tags.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | let mut versions = self.get_tags().versions(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tags.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let mut val; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tags.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if !versions.is_none(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `versions.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/tags.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | Err(E) => Err(E) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/tags.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / let mut val; [INFO] [stderr] 85 | | if self.versions.is_empty(){ [INFO] [stderr] 86 | | let initial = Release::get_initial_version(); [INFO] [stderr] 87 | | val = initial.incr(vtype); [INFO] [stderr] ... | [INFO] [stderr] 90 | | val = latest.incr(vtype); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let val = if self.versions.is_empty() { ..; initial.incr(vtype) } else { ..; latest.incr(vtype) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tags.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let mut obj; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/tags.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn iter(&self) -> Iter{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | release.make_release(vtype); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/main.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | Err(E) => { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tags.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if !versions.is_none(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `versions.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/tags.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | Err(E) => Err(E) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/tags.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / let mut val; [INFO] [stderr] 85 | | if self.versions.is_empty(){ [INFO] [stderr] 86 | | let initial = Release::get_initial_version(); [INFO] [stderr] 87 | | val = initial.incr(vtype); [INFO] [stderr] ... | [INFO] [stderr] 90 | | val = latest.incr(vtype); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let val = if self.versions.is_empty() { ..; initial.incr(vtype) } else { ..; latest.incr(vtype) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | release.make_release(vtype); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `E` should have a snake case name such as `e` [INFO] [stderr] --> src/main.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | Err(E) => { [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 21s [INFO] running `"docker" "inspect" "ed8af0c25c62641ff235c771dc98a883b67f8d2400fcb5c47be510994d8f7d76"` [INFO] running `"docker" "rm" "-f" "ed8af0c25c62641ff235c771dc98a883b67f8d2400fcb5c47be510994d8f7d76"` [INFO] [stdout] ed8af0c25c62641ff235c771dc98a883b67f8d2400fcb5c47be510994d8f7d76