[INFO] updating cached repository sourcepirate/pichu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sourcepirate/pichu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sourcepirate/pichu" "work/ex/clippy-test-run/sources/stable/gh/sourcepirate/pichu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sourcepirate/pichu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sourcepirate/pichu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/pichu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/pichu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d58b90e27b87ea5dc1d778d8238a2287e6e29db0 [INFO] sha for GitHub repo sourcepirate/pichu: d58b90e27b87ea5dc1d778d8238a2287e6e29db0 [INFO] validating manifest of sourcepirate/pichu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sourcepirate/pichu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sourcepirate/pichu [INFO] finished frobbing sourcepirate/pichu [INFO] frobbed toml for sourcepirate/pichu written to work/ex/clippy-test-run/sources/stable/gh/sourcepirate/pichu/Cargo.toml [INFO] started frobbing sourcepirate/pichu [INFO] finished frobbing sourcepirate/pichu [INFO] frobbed toml for sourcepirate/pichu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/pichu/Cargo.toml [INFO] crate sourcepirate/pichu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sourcepirate/pichu against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sourcepirate/pichu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2f9abb182cade85393928695c0f17a6cebd1600af511c9abfbbbe5d528e2bb6 [INFO] running `"docker" "start" "-a" "c2f9abb182cade85393928695c0f17a6cebd1600af511c9abfbbbe5d528e2bb6"` [INFO] [stderr] Checking futures-core v0.2.1 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking futures-channel v0.2.1 [INFO] [stderr] Checking futures-io v0.2.1 [INFO] [stderr] Checking futures-sink v0.2.1 [INFO] [stderr] Checking futures-util v0.2.1 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking futures-executor v0.2.1 [INFO] [stderr] Checking futures-stable v0.2.1 [INFO] [stderr] Checking futures-async-runtime v0.2.1 [INFO] [stderr] Checking futures v0.2.1 [INFO] [stderr] Checking pichu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | shipper: shipper [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shipper` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | shipper: shipper [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `shipper` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/core.rs:2:33 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Error, BufReader, Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/core.rs:2:33 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Error, BufReader, Read, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/core.rs:2:39 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Error, BufReader, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `written` [INFO] [stderr] --> src/core.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let written = self.shipper.send(sop.unwrap())?; [INFO] [stderr] | ^^^^^^^ help: consider using `_written` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Write` [INFO] [stderr] --> src/core.rs:2:39 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Error, BufReader, Read, Write}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let mut lresult = core::LogListener::new(file_path_input.to_str().unwrap(), address); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `written` [INFO] [stderr] --> src/core.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let written = self.shipper.send(sop.unwrap())?; [INFO] [stderr] | ^^^^^^^ help: consider using `_written` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let mut lresult = core::LogListener::new(file_path_input.to_str().unwrap(), address); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut file = File::open(fp)?; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut reader = BufReader::new(file); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut shipper = TcpShipper::new(url.to_owned())?; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let mut file = File::open(fp)?; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut reader = BufReader::new(file); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut shipper = TcpShipper::new(url.to_owned())?; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.92s [INFO] running `"docker" "inspect" "c2f9abb182cade85393928695c0f17a6cebd1600af511c9abfbbbe5d528e2bb6"` [INFO] running `"docker" "rm" "-f" "c2f9abb182cade85393928695c0f17a6cebd1600af511c9abfbbbe5d528e2bb6"` [INFO] [stdout] c2f9abb182cade85393928695c0f17a6cebd1600af511c9abfbbbe5d528e2bb6