[INFO] updating cached repository sourcepirate/covert_tcp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sourcepirate/covert_tcp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sourcepirate/covert_tcp" "work/ex/clippy-test-run/sources/stable/gh/sourcepirate/covert_tcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sourcepirate/covert_tcp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sourcepirate/covert_tcp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/covert_tcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/covert_tcp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] af27373d3c5f086d7c0e10a57d93615fcf992dfd [INFO] sha for GitHub repo sourcepirate/covert_tcp: af27373d3c5f086d7c0e10a57d93615fcf992dfd [INFO] validating manifest of sourcepirate/covert_tcp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sourcepirate/covert_tcp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sourcepirate/covert_tcp [INFO] finished frobbing sourcepirate/covert_tcp [INFO] frobbed toml for sourcepirate/covert_tcp written to work/ex/clippy-test-run/sources/stable/gh/sourcepirate/covert_tcp/Cargo.toml [INFO] started frobbing sourcepirate/covert_tcp [INFO] finished frobbing sourcepirate/covert_tcp [INFO] frobbed toml for sourcepirate/covert_tcp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sourcepirate/covert_tcp/Cargo.toml [INFO] crate sourcepirate/covert_tcp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sourcepirate/covert_tcp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sourcepirate/covert_tcp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f53637e2390c4ca9a5e4dccd69d3b17c4962045ab4e65e8b0e9dc30104501d88 [INFO] running `"docker" "start" "-a" "f53637e2390c4ca9a5e4dccd69d3b17c4962045ab4e65e8b0e9dc30104501d88"` [INFO] [stderr] Compiling ucd-util v0.1.2 [INFO] [stderr] Compiling utf8-ranges v1.0.2 [INFO] [stderr] Checking pnet_base v0.21.0 [INFO] [stderr] Checking ipnetwork v0.12.8 [INFO] [stderr] Compiling pnet v0.21.0 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Compiling syntex_pos v0.42.0 [INFO] [stderr] Checking pnet_sys v0.21.0 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Compiling regex-syntax v0.5.6 [INFO] [stderr] Checking pnet_macros_support v0.21.0 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Checking pnet_datalink v0.21.0 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Compiling aho-corasick v0.6.9 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking pnet_transport v0.21.0 [INFO] [stderr] Checking covert_tcp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/packet.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | /// Building an IPV4 packet. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/packet.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | /// Building an TCP packet [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/packet.rs:97:28 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn recv(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `EtherTypes` [INFO] [stderr] --> src/sniffer.rs:3:30 [INFO] [stderr] | [INFO] [stderr] 3 | use pnet::packet::ethernet::{EtherTypes, EthernetPacket, MutableEthernetPacket}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::icmpv6::Icmpv6Packet` [INFO] [stderr] --> src/sniffer.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use pnet::packet::icmpv6::Icmpv6Packet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `IpNextHeaderProtocol`, `IpNextHeaderProtocols` [INFO] [stderr] --> src/sniffer.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use pnet::packet::ip::{IpNextHeaderProtocol, IpNextHeaderProtocols}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::ipv6::Ipv6Packet` [INFO] [stderr] --> src/sniffer.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use pnet::packet::ipv6::Ipv6Packet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::tcp::TcpPacket` [INFO] [stderr] --> src/sniffer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use pnet::packet::tcp::TcpPacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::util::MacAddr` [INFO] [stderr] --> src/sniffer.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use pnet::util::MacAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/sniffer.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::IpAddr` [INFO] [stderr] --> src/sniffer.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::net::IpAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/packet.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | /// Building an IPV4 packet. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/packet.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | /// Building an TCP packet [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/packet.rs:97:28 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn recv(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `EtherTypes` [INFO] [stderr] --> src/sniffer.rs:3:30 [INFO] [stderr] | [INFO] [stderr] 3 | use pnet::packet::ethernet::{EtherTypes, EthernetPacket, MutableEthernetPacket}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::icmpv6::Icmpv6Packet` [INFO] [stderr] --> src/sniffer.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use pnet::packet::icmpv6::Icmpv6Packet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `IpNextHeaderProtocol`, `IpNextHeaderProtocols` [INFO] [stderr] --> src/sniffer.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | use pnet::packet::ip::{IpNextHeaderProtocol, IpNextHeaderProtocols}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::ipv6::Ipv6Packet` [INFO] [stderr] --> src/sniffer.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use pnet::packet::ipv6::Ipv6Packet; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::packet::tcp::TcpPacket` [INFO] [stderr] --> src/sniffer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use pnet::packet::tcp::TcpPacket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `pnet::util::MacAddr` [INFO] [stderr] --> src/sniffer.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use pnet::util::MacAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Write` [INFO] [stderr] --> src/sniffer.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::io::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::net::IpAddr` [INFO] [stderr] --> src/sniffer.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::net::IpAddr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:15 [INFO] [stderr] | [INFO] [stderr] 28 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/sniffer.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(()) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/sniffer.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | Err(e) => return Err(ReciverError::PacketError), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fake_ethernet_frame` [INFO] [stderr] --> src/sniffer.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | let mut fake_ethernet_frame = MutableEthernetPacket::new(&mut buf[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_fake_ethernet_frame` instead [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/sniffer.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(()) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/sniffer.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | Err(e) => return Err(ReciverError::PacketError), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fake_ethernet_frame` [INFO] [stderr] --> src/sniffer.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | let mut fake_ethernet_frame = MutableEthernetPacket::new(&mut buf[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using `_fake_ethernet_frame` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let mut relative_path: PathBuf; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut file = File::open(relative_path).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let mut relative_path: PathBuf; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let mut file = File::open(relative_path).unwrap(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sniffer.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let mut fake_ethernet_frame = MutableEthernetPacket::new(&mut buf[..]).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `rx` [INFO] [stderr] --> src/packet.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | rx: TransportReceiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `packets` [INFO] [stderr] --> src/packet.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn packets(&mut self) -> Ipv4TransportChannelIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `recv` [INFO] [stderr] --> src/packet.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn recv(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/packet.rs:33:44 [INFO] [stderr] | [INFO] [stderr] 33 | self.tx.send_to(packet, IpAddr::V4(addr.ip().clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*addr.ip()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sniffer.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | match char::from_u32(header.get_identification() as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.get_identification())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sniffer.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | let mut fake_ethernet_frame = MutableEthernetPacket::new(&mut buf[..]).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `rx` [INFO] [stderr] --> src/packet.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | rx: TransportReceiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `packets` [INFO] [stderr] --> src/packet.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn packets(&mut self) -> Ipv4TransportChannelIterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `recv` [INFO] [stderr] --> src/packet.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn recv(&mut self) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/sniffer.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | let interface = interfaces.into_iter().filter(interface_names_match).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(interface_names_match).next()` with `find(interface_names_match)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/packet.rs:33:44 [INFO] [stderr] | [INFO] [stderr] 33 | self.tx.send_to(packet, IpAddr::V4(addr.ip().clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*addr.ip()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / let mut relative_path: PathBuf; [INFO] [stderr] 62 | | if filepath.is_relative() { [INFO] [stderr] 63 | | relative_path = canonicalize(filepath).unwrap(); [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | relative_path = filepath; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let relative_path = if filepath.is_relative() { canonicalize(filepath).unwrap() } else { filepath };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:56 [INFO] [stderr] | [INFO] [stderr] 73 | match connection.send(destip, seq, byte as u16) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | sniff.recv(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sniffer.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | match char::from_u32(header.get_identification() as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header.get_identification())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/sniffer.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | let interface = interfaces.into_iter().filter(interface_names_match).next(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(interface_names_match).next()` with `find(interface_names_match)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / let mut relative_path: PathBuf; [INFO] [stderr] 62 | | if filepath.is_relative() { [INFO] [stderr] 63 | | relative_path = canonicalize(filepath).unwrap(); [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | relative_path = filepath; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let relative_path = if filepath.is_relative() { canonicalize(filepath).unwrap() } else { filepath };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:56 [INFO] [stderr] | [INFO] [stderr] 73 | match connection.send(destip, seq, byte as u16) { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | sniff.recv(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "f53637e2390c4ca9a5e4dccd69d3b17c4962045ab4e65e8b0e9dc30104501d88"` [INFO] running `"docker" "rm" "-f" "f53637e2390c4ca9a5e4dccd69d3b17c4962045ab4e65e8b0e9dc30104501d88"` [INFO] [stdout] f53637e2390c4ca9a5e4dccd69d3b17c4962045ab4e65e8b0e9dc30104501d88