[INFO] updating cached repository sorah/imoni [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sorah/imoni [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sorah/imoni" "work/ex/clippy-test-run/sources/stable/gh/sorah/imoni"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sorah/imoni'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sorah/imoni" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sorah/imoni"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sorah/imoni'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c44fe6083940a2b8ef49bb971fdddebb158003b [INFO] sha for GitHub repo sorah/imoni: 3c44fe6083940a2b8ef49bb971fdddebb158003b [INFO] validating manifest of sorah/imoni on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sorah/imoni on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sorah/imoni [INFO] finished frobbing sorah/imoni [INFO] frobbed toml for sorah/imoni written to work/ex/clippy-test-run/sources/stable/gh/sorah/imoni/Cargo.toml [INFO] started frobbing sorah/imoni [INFO] finished frobbing sorah/imoni [INFO] frobbed toml for sorah/imoni written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sorah/imoni/Cargo.toml [INFO] crate sorah/imoni has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sorah/imoni against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sorah/imoni:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f343dbd4bb0c7f044c2ee0cf7676afe7daeed21b5cbc19fd18bbdbed8958a95 [INFO] running `"docker" "start" "-a" "5f343dbd4bb0c7f044c2ee0cf7676afe7daeed21b5cbc19fd18bbdbed8958a95"` [INFO] [stderr] Checking serde v1.0.23 [INFO] [stderr] Compiling backtrace-sys v0.1.14 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking serde_json v1.0.6 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking imoni v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tag.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aggregators/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return self.aggregate(record); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.aggregate(record)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aggregators/mod.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return self.aggregate_merge(state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.aggregate_merge(state)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aggregators/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return self.aggregate(record); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.aggregate(record)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aggregators/mod.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return self.aggregate_merge(state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.aggregate_merge(state)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tag.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn parse(string: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tag.rs:25:60 [INFO] [stderr] | [INFO] [stderr] 25 | let namewindow_group: Vec<&str> = string.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tag.rs:27:68 [INFO] [stderr] | [INFO] [stderr] 27 | let name_window: Vec<&str> = namewindow_group[0].splitn(2, "@").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tag.rs:38:60 [INFO] [stderr] | [INFO] [stderr] 38 | let group_key: Vec<&str> = group_str.splitn(2, "/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tag_matcher/rules/mod.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | fn parse(rule_str: &String) -> Result [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tag_matcher/mod.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | .map(|x| self::rules::parse(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `self::rules::parse` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tag.rs:24:26 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn parse(string: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tag.rs:25:60 [INFO] [stderr] | [INFO] [stderr] 25 | let namewindow_group: Vec<&str> = string.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tag.rs:27:68 [INFO] [stderr] | [INFO] [stderr] 27 | let name_window: Vec<&str> = namewindow_group[0].splitn(2, "@").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tag.rs:38:60 [INFO] [stderr] | [INFO] [stderr] 38 | let group_key: Vec<&str> = group_str.splitn(2, "/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tag_matcher/rules/mod.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | fn parse(rule_str: &String) -> Result [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tag_matcher/mod.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | .map(|x| self::rules::parse(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `self::rules::parse` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.61s [INFO] running `"docker" "inspect" "5f343dbd4bb0c7f044c2ee0cf7676afe7daeed21b5cbc19fd18bbdbed8958a95"` [INFO] running `"docker" "rm" "-f" "5f343dbd4bb0c7f044c2ee0cf7676afe7daeed21b5cbc19fd18bbdbed8958a95"` [INFO] [stdout] 5f343dbd4bb0c7f044c2ee0cf7676afe7daeed21b5cbc19fd18bbdbed8958a95