[INFO] updating cached repository solarsail/learnopengl-gfxrs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/solarsail/learnopengl-gfxrs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/solarsail/learnopengl-gfxrs" "work/ex/clippy-test-run/sources/stable/gh/solarsail/learnopengl-gfxrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/solarsail/learnopengl-gfxrs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/solarsail/learnopengl-gfxrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarsail/learnopengl-gfxrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarsail/learnopengl-gfxrs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 349073d65434ac49dc044f75b30b33b318511a70 [INFO] sha for GitHub repo solarsail/learnopengl-gfxrs: 349073d65434ac49dc044f75b30b33b318511a70 [INFO] validating manifest of solarsail/learnopengl-gfxrs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solarsail/learnopengl-gfxrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solarsail/learnopengl-gfxrs [INFO] finished frobbing solarsail/learnopengl-gfxrs [INFO] frobbed toml for solarsail/learnopengl-gfxrs written to work/ex/clippy-test-run/sources/stable/gh/solarsail/learnopengl-gfxrs/Cargo.toml [INFO] started frobbing solarsail/learnopengl-gfxrs [INFO] finished frobbing solarsail/learnopengl-gfxrs [INFO] frobbed toml for solarsail/learnopengl-gfxrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarsail/learnopengl-gfxrs/Cargo.toml [INFO] crate solarsail/learnopengl-gfxrs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solarsail/learnopengl-gfxrs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/solarsail/learnopengl-gfxrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2ff26a2bbd1aeae17a4bcb34a4ab6dda0796ec2970a396656d2abba22418310 [INFO] running `"docker" "start" "-a" "b2ff26a2bbd1aeae17a4bcb34a4ab6dda0796ec2970a396656d2abba22418310"` [INFO] [stderr] Compiling libc v0.2.29 [INFO] [stderr] Compiling either v1.1.0 [INFO] [stderr] Checking spin_sleep v0.3.1 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling x11-dl v2.15.0 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking deflate v0.7.16 [INFO] [stderr] Compiling wayland-scanner v0.9.9 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Compiling structopt-derive v0.1.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Compiling rand v0.3.16 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling wayland-client v0.9.9 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking gfx_core v0.7.1 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking structopt v0.1.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.9 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.6.1 [INFO] [stderr] Checking winit v0.7.5 [INFO] [stderr] Checking gfx_device_gl v0.14.2 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_window_glutin v0.17.0 [INFO] [stderr] Checking learnopengl-gfxrs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/105-shaders/render.rs:27:48 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new(x: f32, y: f32, z: f32, r: f32, g: f32, b: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/105-shaders/render.rs:27:56 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new(x: f32, y: f32, z: f32, r: f32, g: f32, b: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/108-coordinate/render.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn new(x: f32, y: f32, z: f32, u: f32, v: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main_view.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main_view.rs:131:37 [INFO] [stderr] | [INFO] [stderr] 131 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/201-colors/main.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/201-colors/main.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/108-coordinate/render.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn new(x: f32, y: f32, z: f32, u: f32, v: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/107-transformations/render.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new(x: f32, y: f32, z: f32, u: f32, v: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/107-transformations/render.rs:32:48 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn new(x: f32, y: f32, z: f32, u: f32, v: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/105-shaders/render.rs:27:48 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new(x: f32, y: f32, z: f32, r: f32, g: f32, b: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/105-shaders/render.rs:27:56 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn new(x: f32, y: f32, z: f32, r: f32, g: f32, b: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:96:57 [INFO] [stderr] | [INFO] [stderr] 96 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main_view.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/202-basic-lighting/main_view.rs:131:37 [INFO] [stderr] | [INFO] [stderr] 131 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/109-camera/render.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn new(x: f32, y: f32, z: f32, u: f32, v: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/01-getting-started/109-camera/render.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn new(x: f32, y: f32, z: f32, u: f32, v: f32) -> Vertex { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: variable `current_fps` is assigned to, but never used [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | let mut current_fps = None; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_current_fps` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_fps` is never read [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | current_fps = Some(fps); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `projection_matrix` [INFO] [stderr] --> src/02-lighting/206-multiple-lights/system/camera.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn projection_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `view_matrix` [INFO] [stderr] --> src/02-lighting/206-multiple-lights/system/camera.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn view_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spot` [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | spot: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | dir_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirLight]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | point_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PointLight]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn draw( [INFO] [stderr] 170 | | &self, [INFO] [stderr] 171 | | object: &Object, [INFO] [stderr] 172 | | dir_lights: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 213 | | ); [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | light_args: &LightArgs, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `LightArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/01-getting-started/109-camera/main.rs:120:37 [INFO] [stderr] | [INFO] [stderr] 120 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/01-getting-started/109-camera/main.rs:121:37 [INFO] [stderr] | [INFO] [stderr] 121 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/01-getting-started/109-camera/main.rs:120:37 [INFO] [stderr] | [INFO] [stderr] 120 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/01-getting-started/109-camera/main.rs:121:37 [INFO] [stderr] | [INFO] [stderr] 121 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:96:57 [INFO] [stderr] | [INFO] [stderr] 96 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/201-colors/main.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | x = width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/02-lighting/201-colors/main.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | y = height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `current_fps` is assigned to, but never used [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | let mut current_fps = None; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_current_fps` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_fps` is never read [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | current_fps = Some(fps); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `projection_matrix` [INFO] [stderr] --> src/02-lighting/206-multiple-lights/system/camera.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn projection_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `view_matrix` [INFO] [stderr] --> src/02-lighting/206-multiple-lights/system/camera.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn view_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spot` [INFO] [stderr] --> src/02-lighting/206-multiple-lights/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | spot: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | dir_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirLight]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | point_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PointLight]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn draw( [INFO] [stderr] 170 | | &self, [INFO] [stderr] 171 | | object: &Object, [INFO] [stderr] 172 | | dir_lights: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 213 | | ); [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/02-lighting/206-multiple-lights/render.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | light_args: &LightArgs, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `LightArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 03s [INFO] running `"docker" "inspect" "b2ff26a2bbd1aeae17a4bcb34a4ab6dda0796ec2970a396656d2abba22418310"` [INFO] running `"docker" "rm" "-f" "b2ff26a2bbd1aeae17a4bcb34a4ab6dda0796ec2970a396656d2abba22418310"` [INFO] [stdout] b2ff26a2bbd1aeae17a4bcb34a4ab6dda0796ec2970a396656d2abba22418310