[INFO] updating cached repository solarsail/gfxrs-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/solarsail/gfxrs-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/solarsail/gfxrs-playground" "work/ex/clippy-test-run/sources/stable/gh/solarsail/gfxrs-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/solarsail/gfxrs-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/solarsail/gfxrs-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarsail/gfxrs-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarsail/gfxrs-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ddf7f82db43c2f684fe8ce99f09829fb27bcae5 [INFO] sha for GitHub repo solarsail/gfxrs-playground: 7ddf7f82db43c2f684fe8ce99f09829fb27bcae5 [INFO] validating manifest of solarsail/gfxrs-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of solarsail/gfxrs-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing solarsail/gfxrs-playground [INFO] finished frobbing solarsail/gfxrs-playground [INFO] frobbed toml for solarsail/gfxrs-playground written to work/ex/clippy-test-run/sources/stable/gh/solarsail/gfxrs-playground/Cargo.toml [INFO] started frobbing solarsail/gfxrs-playground [INFO] finished frobbing solarsail/gfxrs-playground [INFO] frobbed toml for solarsail/gfxrs-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarsail/gfxrs-playground/Cargo.toml [INFO] crate solarsail/gfxrs-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting solarsail/gfxrs-playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/solarsail/gfxrs-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a40f375d49b51e7b8bad3f3befe1d51c436b6d385f2cae960e2005ac7abda3fd [INFO] running `"docker" "start" "-a" "a40f375d49b51e7b8bad3f3befe1d51c436b6d385f2cae960e2005ac7abda3fd"` [INFO] [stderr] Compiling libc v0.2.30 [INFO] [stderr] Compiling num-traits v0.1.40 [INFO] [stderr] Compiling itoa v0.3.3 [INFO] [stderr] Checking futures v0.1.15 [INFO] [stderr] Checking spin_sleep v0.3.1 [INFO] [stderr] Compiling x11-dl v2.15.0 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking deflate v0.7.16 [INFO] [stderr] Compiling wayland-scanner v0.9.9 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Compiling structopt-derive v0.1.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Compiling wayland-client v0.9.9 [INFO] [stderr] Compiling wayland-protocols v0.9.9 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking structopt v0.1.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.9 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking gfx_device_gl v0.14.3 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking gfx_window_glutin v0.17.0 [INFO] [stderr] Checking light-casters v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:85:57 [INFO] [stderr] | [INFO] [stderr] 85 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:85:57 [INFO] [stderr] | [INFO] [stderr] 85 | render::DirLight::new((light_color * 0.05), (light_color * 0.3), light_color, dir) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: variable `current_fps` is assigned to, but never used [INFO] [stderr] --> src/main.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | let mut current_fps = None; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_current_fps` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_fps` is never read [INFO] [stderr] --> src/main.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | current_fps = Some(fps); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `current_fps` is assigned to, but never used [INFO] [stderr] --> src/main.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | let mut current_fps = None; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_current_fps` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `current_fps` is never read [INFO] [stderr] --> src/main.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | current_fps = Some(fps); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `projection_matrix` [INFO] [stderr] --> src/system/camera.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn projection_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `view_matrix` [INFO] [stderr] --> src/system/camera.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn view_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spot` [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | spot: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `projection_matrix` [INFO] [stderr] --> src/system/camera.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn projection_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `view_matrix` [INFO] [stderr] --> src/system/camera.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn view_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `spot` [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | spot: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | dir_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirLight]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | point_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PointLight]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/render.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn draw( [INFO] [stderr] 170 | | &self, [INFO] [stderr] 171 | | object: &Object, [INFO] [stderr] 172 | | dir_lights: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 213 | | ); [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | light_args: &LightArgs, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `LightArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render.rs:172:21 [INFO] [stderr] | [INFO] [stderr] 172 | dir_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[DirLight]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | point_lights: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[PointLight]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/render.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn draw( [INFO] [stderr] 170 | | &self, [INFO] [stderr] 171 | | object: &Object, [INFO] [stderr] 172 | | dir_lights: &Vec, [INFO] [stderr] ... | [INFO] [stderr] 213 | | ); [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | light_args: &LightArgs, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `LightArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 38s [INFO] running `"docker" "inspect" "a40f375d49b51e7b8bad3f3befe1d51c436b6d385f2cae960e2005ac7abda3fd"` [INFO] running `"docker" "rm" "-f" "a40f375d49b51e7b8bad3f3befe1d51c436b6d385f2cae960e2005ac7abda3fd"` [INFO] [stdout] a40f375d49b51e7b8bad3f3befe1d51c436b6d385f2cae960e2005ac7abda3fd