[INFO] updating cached repository solarnz/ec2-ip
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/solarnz/ec2-ip
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/solarnz/ec2-ip" "work/ex/clippy-test-run/sources/stable/gh/solarnz/ec2-ip"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/solarnz/ec2-ip'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/solarnz/ec2-ip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarnz/ec2-ip"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarnz/ec2-ip'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 232f27244044a17e9ecebcdc2e5b06eee809c2be
[INFO] sha for GitHub repo solarnz/ec2-ip: 232f27244044a17e9ecebcdc2e5b06eee809c2be
[INFO] validating manifest of solarnz/ec2-ip on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of solarnz/ec2-ip on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing solarnz/ec2-ip
[INFO] finished frobbing solarnz/ec2-ip
[INFO] frobbed toml for solarnz/ec2-ip written to work/ex/clippy-test-run/sources/stable/gh/solarnz/ec2-ip/Cargo.toml
[INFO] started frobbing solarnz/ec2-ip
[INFO] finished frobbing solarnz/ec2-ip
[INFO] frobbed toml for solarnz/ec2-ip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/solarnz/ec2-ip/Cargo.toml
[INFO] crate solarnz/ec2-ip has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting solarnz/ec2-ip against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/solarnz/ec2-ip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b51f326e91c0bb8479c510ffb105d49e5690c8db030f9ec0761f851279b07bc6
[INFO] running `"docker" "start" "-a" "b51f326e91c0bb8479c510ffb105d49e5690c8db030f9ec0761f851279b07bc6"`
[INFO] [stderr]     Checking md5 v0.3.8
[INFO] [stderr]     Checking shlex v0.1.1
[INFO] [stderr]     Checking dirs v1.0.4
[INFO] [stderr]     Checking termion v1.5.1
[INFO] [stderr]    Compiling openssl-sys v0.9.36
[INFO] [stderr]     Checking want v0.0.6
[INFO] [stderr]     Checking mio v0.6.15
[INFO] [stderr]     Checking aho-corasick v0.6.6
[INFO] [stderr]     Checking tokio-timer v0.2.7
[INFO] [stderr]     Checking thread_local v0.3.5
[INFO] [stderr]     Checking idna v0.1.5
[INFO] [stderr]     Checking tokio-io v0.1.7
[INFO] [stderr]     Checking http v0.1.13
[INFO] [stderr]    Compiling rusoto_core v0.34.0
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking tokio-threadpool v0.1.5
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]     Checking hmac v0.5.0
[INFO] [stderr]    Compiling openssl v0.10.12
[INFO] [stderr]    Compiling native-tls v0.2.1
[INFO] [stderr]     Checking tokio-reactor v0.1.2
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking url v1.7.1
[INFO] [stderr]     Checking rayon v1.0.2
[INFO] [stderr]     Checking tokio-fs v0.1.2
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio-udp v0.1.1
[INFO] [stderr]     Checking env_logger v0.4.3
[INFO] [stderr]     Checking tokio v0.1.7
[INFO] [stderr]     Checking skim v0.5.2
[INFO] [stderr]     Checking serde_urlencoded v0.5.3
[INFO] [stderr]     Checking h2 v0.1.12
[INFO] [stderr]     Checking hyper v0.12.11
[INFO] [stderr]     Checking rusoto_credential v0.13.0
[INFO] [stderr]     Checking hyper-tls v0.3.0
[INFO] [stderr]     Checking rusoto_ec2 v0.34.0
[INFO] [stderr]     Checking ec2-ip v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         filters: filters,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `filters`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:116:34
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                  name: name,
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:117:34
[INFO] [stderr]     |
[INFO] [stderr] 117 |                                  values: values,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^ help: replace it with: `values`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         filters: filters,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `filters`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:116:34
[INFO] [stderr]     |
[INFO] [stderr] 116 |                                  name: name,
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:117:34
[INFO] [stderr]     |
[INFO] [stderr] 117 |                                  values: values,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^ help: replace it with: `values`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return Ok(region_instances);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(region_instances)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:96:65
[INFO] [stderr]    |
[INFO] [stderr] 96 |             let filter_options: Vec<&str> = filter_string.split(";").collect();
[INFO] [stderr]    |                                                                 ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:105:59
[INFO] [stderr]     |
[INFO] [stderr] 105 |                 let mut parts: Vec<String> = filter.split("=").map(String::from).collect();
[INFO] [stderr]     |                                                           ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:109:54
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 let values: Option<Vec<String>> = if parts.len() > 0 {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parts.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:185:25
[INFO] [stderr]     |
[INFO] [stderr] 185 |         .unwrap_or_else(|| Vec::new());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     return Ok(region_instances);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(region_instances)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:96:65
[INFO] [stderr]    |
[INFO] [stderr] 96 |             let filter_options: Vec<&str> = filter_string.split(";").collect();
[INFO] [stderr]    |                                                                 ^^^ help: try using a char instead: `';'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:105:59
[INFO] [stderr]     |
[INFO] [stderr] 105 |                 let mut parts: Vec<String> = filter.split("=").map(String::from).collect();
[INFO] [stderr]     |                                                           ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:109:54
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 let values: Option<Vec<String>> = if parts.len() > 0 {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parts.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:185:25
[INFO] [stderr]     |
[INFO] [stderr] 185 |         .unwrap_or_else(|| Vec::new());
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 26s
[INFO] running `"docker" "inspect" "b51f326e91c0bb8479c510ffb105d49e5690c8db030f9ec0761f851279b07bc6"`
[INFO] running `"docker" "rm" "-f" "b51f326e91c0bb8479c510ffb105d49e5690c8db030f9ec0761f851279b07bc6"`
[INFO] [stdout] b51f326e91c0bb8479c510ffb105d49e5690c8db030f9ec0761f851279b07bc6