[INFO] updating cached repository sogbesano/advent_of_code2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sogbesano/advent_of_code2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sogbesano/advent_of_code2018" "work/ex/clippy-test-run/sources/stable/gh/sogbesano/advent_of_code2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sogbesano/advent_of_code2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sogbesano/advent_of_code2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sogbesano/advent_of_code2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sogbesano/advent_of_code2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a33c8165e65cb8015fb4c0207d2a22531456236a [INFO] sha for GitHub repo sogbesano/advent_of_code2018: a33c8165e65cb8015fb4c0207d2a22531456236a [INFO] validating manifest of sogbesano/advent_of_code2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sogbesano/advent_of_code2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sogbesano/advent_of_code2018 [INFO] finished frobbing sogbesano/advent_of_code2018 [INFO] frobbed toml for sogbesano/advent_of_code2018 written to work/ex/clippy-test-run/sources/stable/gh/sogbesano/advent_of_code2018/Cargo.toml [INFO] started frobbing sogbesano/advent_of_code2018 [INFO] finished frobbing sogbesano/advent_of_code2018 [INFO] frobbed toml for sogbesano/advent_of_code2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sogbesano/advent_of_code2018/Cargo.toml [INFO] crate sogbesano/advent_of_code2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sogbesano/advent_of_code2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sogbesano/advent_of_code2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 484354add22c2e44757ef33a209faa41f26e053edc4cee9c331304c98018ad55 [INFO] running `"docker" "start" "-a" "484354add22c2e44757ef33a209faa41f26e053edc4cee9c331304c98018ad55"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | return vec_contents; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec_contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | return number * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `number * -1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | return number; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_one.rs:9:39 [INFO] [stderr] | [INFO] [stderr] 9 | let contents_split = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/day_one.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | return number * -1; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day_one.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let sum = vec_nums.iter().fold(0, |a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | return vec_contents; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec_contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | return number * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `number * -1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | return number; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_one.rs:9:39 [INFO] [stderr] | [INFO] [stderr] 9 | let contents_split = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/day_one.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | return number * -1; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day_one.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let sum = vec_nums.iter().fold(0, |a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "484354add22c2e44757ef33a209faa41f26e053edc4cee9c331304c98018ad55"` [INFO] running `"docker" "rm" "-f" "484354add22c2e44757ef33a209faa41f26e053edc4cee9c331304c98018ad55"` [INFO] [stdout] 484354add22c2e44757ef33a209faa41f26e053edc4cee9c331304c98018ad55