[INFO] updating cached repository softwaremill/rustmill
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/softwaremill/rustmill
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/softwaremill/rustmill" "work/ex/clippy-test-run/sources/stable/gh/softwaremill/rustmill"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/softwaremill/rustmill'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/softwaremill/rustmill" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/softwaremill/rustmill"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/softwaremill/rustmill'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d8a0b4456d38ddb1fe16c682b2abf96846c6c0b7
[INFO] sha for GitHub repo softwaremill/rustmill: d8a0b4456d38ddb1fe16c682b2abf96846c6c0b7
[INFO] validating manifest of softwaremill/rustmill on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of softwaremill/rustmill on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing softwaremill/rustmill
[INFO] finished frobbing softwaremill/rustmill
[INFO] frobbed toml for softwaremill/rustmill written to work/ex/clippy-test-run/sources/stable/gh/softwaremill/rustmill/Cargo.toml
[INFO] started frobbing softwaremill/rustmill
[INFO] finished frobbing softwaremill/rustmill
[INFO] frobbed toml for softwaremill/rustmill written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/softwaremill/rustmill/Cargo.toml
[INFO] crate softwaremill/rustmill has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting softwaremill/rustmill against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/softwaremill/rustmill:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0dc3ca2b7808554fa47059843f90872d237fc0ff6d7a9613685d655b8c109e77
[INFO] running `"docker" "start" "-a" "0dc3ca2b7808554fa47059843f90872d237fc0ff6d7a9613685d655b8c109e77"`
[INFO] [stderr]    Compiling libc v0.2.33
[INFO] [stderr]    Compiling matrixmultiply v0.1.14
[INFO] [stderr]     Checking rawpointer v0.1.0
[INFO] [stderr]    Compiling either v1.4.0
[INFO] [stderr]    Compiling khronos_api v2.0.0
[INFO] [stderr]     Checking serde v1.0.21
[INFO] [stderr]     Checking linked-hash-map v0.5.0
[INFO] [stderr]     Checking num_cpus v1.7.0
[INFO] [stderr]     Checking shared_library v0.1.7
[INFO] [stderr]     Checking arrayvec v0.4.6
[INFO] [stderr]    Compiling x11-dl v2.17.0
[INFO] [stderr]     Checking tempfile v2.2.0
[INFO] [stderr]    Compiling itertools v0.5.10
[INFO] [stderr]     Checking alga v0.5.2
[INFO] [stderr]     Checking num-rational v0.1.40
[INFO] [stderr]     Checking rayon-core v1.3.0
[INFO] [stderr]    Compiling gl_generator v0.6.1
[INFO] [stderr]    Compiling serde_derive_internals v0.17.0
[INFO] [stderr]     Checking generic-array v0.8.3
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking fs2 v0.2.5
[INFO] [stderr]    Compiling rand v0.3.18
[INFO] [stderr]     Checking rusttype v0.2.3
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]    Compiling derivative v1.0.0
[INFO] [stderr]    Compiling serde_derive v1.0.21
[INFO] [stderr]    Compiling gl v0.6.5
[INFO] [stderr]    Compiling glutin v0.10.1
[INFO] [stderr]    Compiling phf_generator v0.7.21
[INFO] [stderr]     Checking nalgebra v0.13.1
[INFO] [stderr]     Checking piston2d-graphics v0.23.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]    Compiling phf_codegen v0.7.21
[INFO] [stderr]     Checking gfx_core v0.7.2
[INFO] [stderr]    Compiling target_build_utils v0.3.1
[INFO] [stderr]     Checking image v0.17.0
[INFO] [stderr]     Checking pistoncore-input v0.20.0
[INFO] [stderr]     Checking pistoncore-window v0.30.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.35.0
[INFO] [stderr]     Checking piston v0.35.0
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.9.10
[INFO] [stderr]     Checking wayland-client v0.9.10
[INFO] [stderr]     Checking wayland-protocols v0.9.10
[INFO] [stderr]     Checking wayland-kbd v0.9.1
[INFO] [stderr]     Checking wayland-window v0.8.0
[INFO] [stderr]     Checking winit v0.8.3
[INFO] [stderr]     Checking gfx v0.16.1
[INFO] [stderr]     Checking gfx_device_gl v0.14.4
[INFO] [stderr]     Checking pistoncore-glutin_window v0.42.1
[INFO] [stderr]     Checking piston-gfx_texture v0.29.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.46.0
[INFO] [stderr]     Checking ncollide_math v0.8.0
[INFO] [stderr]     Checking piston_window v0.73.0
[INFO] [stderr]     Checking ncollide_utils v0.8.0
[INFO] [stderr]     Checking ncollide_geometry v0.5.1
[INFO] [stderr]     Checking ncollide_procedural v0.8.0
[INFO] [stderr]     Checking ncollide_pipeline v0.12.1
[INFO] [stderr]     Checking ncollide_transformation v0.8.0
[INFO] [stderr]     Checking ncollide v0.13.0
[INFO] [stderr]     Checking rustmill v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/polygon.rs:19:45
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn contains_neighbour(&self, coord: &Coord) -> bool {
[INFO] [stderr]    |                                             ^^^^^^ help: consider passing by value instead: `Coord`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/polygon.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         self.pixels.iter().find(|&&c| {
[INFO] [stderr] 22 | |             (y > 0 && c == (x, y - 1)) || ( x > 0 && c == (x - 1, y))
[INFO] [stderr] 23 | |         }).is_some()
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:28:21
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let min_x = *xs.iter().min().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*xs.iter().min().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:29:21
[INFO] [stderr]    |
[INFO] [stderr] 29 |         let max_x = *xs.iter().max().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*xs.iter().max().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let min_y = *ys.iter().min().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*ys.iter().min().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 |         let max_y = *ys.iter().max().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*ys.iter().max().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/app.rs:36:39
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn on_update(&mut self, _upd: &UpdateArgs, rx: &Receiver<Vec<Boundaries>>) {
[INFO] [stderr]    |                                       ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/polygon.rs:19:45
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn contains_neighbour(&self, coord: &Coord) -> bool {
[INFO] [stderr]    |                                             ^^^^^^ help: consider passing by value instead: `Coord`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/polygon.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         self.pixels.iter().find(|&&c| {
[INFO] [stderr] 22 | |             (y > 0 && c == (x, y - 1)) || ( x > 0 && c == (x - 1, y))
[INFO] [stderr] 23 | |         }).is_some()
[INFO] [stderr]    | |____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:28:21
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let min_x = *xs.iter().min().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*xs.iter().min().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:29:21
[INFO] [stderr]    |
[INFO] [stderr] 29 |         let max_x = *xs.iter().max().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*xs.iter().max().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |         let min_y = *ys.iter().min().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*ys.iter().min().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/polygon.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 |         let max_y = *ys.iter().max().unwrap() as f64;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*ys.iter().max().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/app.rs:36:39
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn on_update(&mut self, _upd: &UpdateArgs, rx: &Receiver<Vec<Boundaries>>) {
[INFO] [stderr]    |                                       ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2m 19s
[INFO] running `"docker" "inspect" "0dc3ca2b7808554fa47059843f90872d237fc0ff6d7a9613685d655b8c109e77"`
[INFO] running `"docker" "rm" "-f" "0dc3ca2b7808554fa47059843f90872d237fc0ff6d7a9613685d655b8c109e77"`
[INFO] [stdout] 0dc3ca2b7808554fa47059843f90872d237fc0ff6d7a9613685d655b8c109e77