[INFO] updating cached repository soebosi/turtle_parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/soebosi/turtle_parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/soebosi/turtle_parser" "work/ex/clippy-test-run/sources/stable/gh/soebosi/turtle_parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/soebosi/turtle_parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/soebosi/turtle_parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soebosi/turtle_parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soebosi/turtle_parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2b3cedccdd7f69bb0c32225403c638f0239f50f [INFO] sha for GitHub repo soebosi/turtle_parser: a2b3cedccdd7f69bb0c32225403c638f0239f50f [INFO] validating manifest of soebosi/turtle_parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of soebosi/turtle_parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing soebosi/turtle_parser [INFO] finished frobbing soebosi/turtle_parser [INFO] frobbed toml for soebosi/turtle_parser written to work/ex/clippy-test-run/sources/stable/gh/soebosi/turtle_parser/Cargo.toml [INFO] started frobbing soebosi/turtle_parser [INFO] finished frobbing soebosi/turtle_parser [INFO] frobbed toml for soebosi/turtle_parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soebosi/turtle_parser/Cargo.toml [INFO] crate soebosi/turtle_parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting soebosi/turtle_parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/soebosi/turtle_parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c549ec64dcd3157f8f65e43e87e16a11c4f0452586dacd9ed26819184f5f4dfe [INFO] running `"docker" "start" "-a" "c549ec64dcd3157f8f65e43e87e16a11c4f0452586dacd9ed26819184f5f4dfe"` [INFO] [stderr] Compiling pest v1.0.0-rc.1 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling pest_derive v1.0.0-rc.1 [INFO] [stderr] Checking turtle_parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/grammar.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const _GRAMMER: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/grammar.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const _GRAMMER: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/grammar.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const _GRAMMER: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/grammar.rs:2:18 [INFO] [stderr] | [INFO] [stderr] 2 | const _GRAMMER: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | fn parse(contents: &String, result: &mut Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | text: if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 68 [INFO] [stderr] --> src/grammar.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / fn subject_test() { [INFO] [stderr] 28 | | parses_to! { [INFO] [stderr] 29 | | parser: TurtleParser, [INFO] [stderr] 30 | | input: "", [INFO] [stderr] ... | [INFO] [stderr] 72 | | }; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 170 [INFO] [stderr] --> src/grammar.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / fn object_test() { [INFO] [stderr] 93 | | parses_to! { [INFO] [stderr] 94 | | parser: TurtleParser, [INFO] [stderr] 95 | | input: "", [INFO] [stderr] ... | [INFO] [stderr] 178 | | }; [INFO] [stderr] 179 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/grammar.rs:182:1 [INFO] [stderr] | [INFO] [stderr] 182 | / fn literal_test() { [INFO] [stderr] 183 | | parses_to! { [INFO] [stderr] 184 | | parser: TurtleParser, [INFO] [stderr] 185 | | input: r#""test"@en"#, [INFO] [stderr] ... | [INFO] [stderr] 221 | | }; [INFO] [stderr] 222 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 74 [INFO] [stderr] --> src/grammar.rs:225:1 [INFO] [stderr] | [INFO] [stderr] 225 | / fn blank_node_property_list_test() { [INFO] [stderr] 226 | | parses_to! { [INFO] [stderr] 227 | | parser: TurtleParser, [INFO] [stderr] 228 | | input: "[ , ; a ]", [INFO] [stderr] ... | [INFO] [stderr] 245 | | }; [INFO] [stderr] 246 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/grammar.rs:249:1 [INFO] [stderr] | [INFO] [stderr] 249 | / fn collection_test() { [INFO] [stderr] 250 | | parses_to! { [INFO] [stderr] 251 | | parser: TurtleParser, [INFO] [stderr] 252 | | input: "( ([ ]))", [INFO] [stderr] ... | [INFO] [stderr] 266 | | }; [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/grammar.rs:270:1 [INFO] [stderr] | [INFO] [stderr] 270 | / fn numeric_literal_test() { [INFO] [stderr] 271 | | parses_to! { [INFO] [stderr] 272 | | parser: TurtleParser, [INFO] [stderr] 273 | | input: "+10", [INFO] [stderr] ... | [INFO] [stderr] 302 | | }; [INFO] [stderr] 303 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/grammar.rs:306:1 [INFO] [stderr] | [INFO] [stderr] 306 | / fn rdf_literal_test() { [INFO] [stderr] 307 | | parses_to! { [INFO] [stderr] 308 | | parser: TurtleParser, [INFO] [stderr] 309 | | input: r#""test"@en"#, [INFO] [stderr] ... | [INFO] [stderr] 335 | | }; [INFO] [stderr] 336 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 68 [INFO] [stderr] --> src/grammar.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / fn subject_test() { [INFO] [stderr] 28 | | parses_to! { [INFO] [stderr] 29 | | parser: TurtleParser, [INFO] [stderr] 30 | | input: "", [INFO] [stderr] ... | [INFO] [stderr] 72 | | }; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/grammar.rs:360:1 [INFO] [stderr] | [INFO] [stderr] 360 | / fn string_test() { [INFO] [stderr] 361 | | parses_to! { [INFO] [stderr] 362 | | parser: TurtleParser, [INFO] [stderr] 363 | | input: r#""test""#, [INFO] [stderr] ... | [INFO] [stderr] 403 | | }; [INFO] [stderr] 404 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 170 [INFO] [stderr] --> src/grammar.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | / fn object_test() { [INFO] [stderr] 93 | | parses_to! { [INFO] [stderr] 94 | | parser: TurtleParser, [INFO] [stderr] 95 | | input: "", [INFO] [stderr] ... | [INFO] [stderr] 178 | | }; [INFO] [stderr] 179 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/grammar.rs:182:1 [INFO] [stderr] | [INFO] [stderr] 182 | / fn literal_test() { [INFO] [stderr] 183 | | parses_to! { [INFO] [stderr] 184 | | parser: TurtleParser, [INFO] [stderr] 185 | | input: r#""test"@en"#, [INFO] [stderr] ... | [INFO] [stderr] 221 | | }; [INFO] [stderr] 222 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 74 [INFO] [stderr] --> src/grammar.rs:225:1 [INFO] [stderr] | [INFO] [stderr] 225 | / fn blank_node_property_list_test() { [INFO] [stderr] 226 | | parses_to! { [INFO] [stderr] 227 | | parser: TurtleParser, [INFO] [stderr] 228 | | input: "[ , ; a ]", [INFO] [stderr] ... | [INFO] [stderr] 245 | | }; [INFO] [stderr] 246 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/grammar.rs:249:1 [INFO] [stderr] | [INFO] [stderr] 249 | / fn collection_test() { [INFO] [stderr] 250 | | parses_to! { [INFO] [stderr] 251 | | parser: TurtleParser, [INFO] [stderr] 252 | | input: "( ([ ]))", [INFO] [stderr] ... | [INFO] [stderr] 266 | | }; [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/grammar.rs:270:1 [INFO] [stderr] | [INFO] [stderr] 270 | / fn numeric_literal_test() { [INFO] [stderr] 271 | | parses_to! { [INFO] [stderr] 272 | | parser: TurtleParser, [INFO] [stderr] 273 | | input: "+10", [INFO] [stderr] ... | [INFO] [stderr] 302 | | }; [INFO] [stderr] 303 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/grammar.rs:306:1 [INFO] [stderr] | [INFO] [stderr] 306 | / fn rdf_literal_test() { [INFO] [stderr] 307 | | parses_to! { [INFO] [stderr] 308 | | parser: TurtleParser, [INFO] [stderr] 309 | | input: r#""test"@en"#, [INFO] [stderr] ... | [INFO] [stderr] 335 | | }; [INFO] [stderr] 336 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/grammar.rs:360:1 [INFO] [stderr] | [INFO] [stderr] 360 | / fn string_test() { [INFO] [stderr] 361 | | parses_to! { [INFO] [stderr] 362 | | parser: TurtleParser, [INFO] [stderr] 363 | | input: r#""test""#, [INFO] [stderr] ... | [INFO] [stderr] 403 | | }; [INFO] [stderr] 404 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | fn parse(contents: &String, result: &mut Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | text: if children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.00s [INFO] running `"docker" "inspect" "c549ec64dcd3157f8f65e43e87e16a11c4f0452586dacd9ed26819184f5f4dfe"` [INFO] running `"docker" "rm" "-f" "c549ec64dcd3157f8f65e43e87e16a11c4f0452586dacd9ed26819184f5f4dfe"` [INFO] [stdout] c549ec64dcd3157f8f65e43e87e16a11c4f0452586dacd9ed26819184f5f4dfe