[INFO] updating cached repository sodiumjoe/jxr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sodiumjoe/jxr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sodiumjoe/jxr" "work/ex/clippy-test-run/sources/stable/gh/sodiumjoe/jxr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sodiumjoe/jxr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sodiumjoe/jxr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sodiumjoe/jxr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sodiumjoe/jxr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5878d74bd7741028999b781598bda1668e87cdf1 [INFO] sha for GitHub repo sodiumjoe/jxr: 5878d74bd7741028999b781598bda1668e87cdf1 [INFO] validating manifest of sodiumjoe/jxr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sodiumjoe/jxr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sodiumjoe/jxr [INFO] finished frobbing sodiumjoe/jxr [INFO] frobbed toml for sodiumjoe/jxr written to work/ex/clippy-test-run/sources/stable/gh/sodiumjoe/jxr/Cargo.toml [INFO] started frobbing sodiumjoe/jxr [INFO] finished frobbing sodiumjoe/jxr [INFO] frobbed toml for sodiumjoe/jxr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sodiumjoe/jxr/Cargo.toml [INFO] crate sodiumjoe/jxr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sodiumjoe/jxr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sodiumjoe/jxr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78dae5acebbebcbb58de94d7c7ac1f7b55e0fc553a0e581a6228c6a2c49f5bcc [INFO] running `"docker" "start" "-a" "78dae5acebbebcbb58de94d7c7ac1f7b55e0fc553a0e581a6228c6a2c49f5bcc"` [INFO] [stderr] Checking num-traits v0.1.41 [INFO] [stderr] Checking serde v1.0.24 [INFO] [stderr] Compiling pulldown-cmark v0.0.11 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking yaml-rust v0.4.0 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Compiling serde_derive_internals v0.18.0 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Compiling serde_derive v1.0.24 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking serde_json v1.0.8 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking handlebars v0.29.1 [INFO] [stderr] Checking jxr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/error.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | HandlebarsTemplate(handlebars::TemplateError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 20 | HandlebarsTemplate(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/render.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | .ok_or(Error::from(format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 89 | | "missing layout: {:?} for path {:?}", [INFO] [stderr] 90 | | file_context.layout, file_context.input_file_path [INFO] [stderr] 91 | | )))?; [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | .ok_or_else(|| Error::from(format!( [INFO] [stderr] 89 | "missing layout: {:?} for path {:?}", [INFO] [stderr] 90 | file_context.layout, file_context.input_file_path [INFO] [stderr] 91 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/render.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | .map_err(|e| Error::from(e))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/render.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | .map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:43:59 [INFO] [stderr] | [INFO] [stderr] 43 | get_default_layout(&default_layout_file_path).unwrap_or("default".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "default".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:105:67 [INFO] [stderr] | [INFO] [stderr] 105 | .map(|f| f.to_str().map(|f| f.starts_with(".")).unwrap_or(false)) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/error.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | HandlebarsTemplate(handlebars::TemplateError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 20 | HandlebarsTemplate(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:195:44 [INFO] [stderr] | [INFO] [stderr] 195 | let front_matter = contents.next().ok_or(format!( [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 196 | | "Error parsing yaml front matter: {:?}", [INFO] [stderr] 197 | | &input_file_path [INFO] [stderr] 198 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 195 | let front_matter = contents.next().ok_or_else(|| format!( [INFO] [stderr] 196 | "Error parsing yaml front matter: {:?}", [INFO] [stderr] 197 | &input_file_path [INFO] [stderr] 198 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/render.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | .ok_or(Error::from(format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 89 | | "missing layout: {:?} for path {:?}", [INFO] [stderr] 90 | | file_context.layout, file_context.input_file_path [INFO] [stderr] 91 | | )))?; [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | .ok_or_else(|| Error::from(format!( [INFO] [stderr] 89 | "missing layout: {:?} for path {:?}", [INFO] [stderr] 90 | file_context.layout, file_context.input_file_path [INFO] [stderr] 91 | )))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/render.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | .map_err(|e| Error::from(e))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/render.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | .map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:43:59 [INFO] [stderr] | [INFO] [stderr] 43 | get_default_layout(&default_layout_file_path).unwrap_or("default".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "default".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:105:67 [INFO] [stderr] | [INFO] [stderr] 105 | .map(|f| f.to_str().map(|f| f.starts_with(".")).unwrap_or(false)) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:195:44 [INFO] [stderr] | [INFO] [stderr] 195 | let front_matter = contents.next().ok_or(format!( [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 196 | | "Error parsing yaml front matter: {:?}", [INFO] [stderr] 197 | | &input_file_path [INFO] [stderr] 198 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 195 | let front_matter = contents.next().ok_or_else(|| format!( [INFO] [stderr] 196 | "Error parsing yaml front matter: {:?}", [INFO] [stderr] 197 | &input_file_path [INFO] [stderr] 198 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.49s [INFO] running `"docker" "inspect" "78dae5acebbebcbb58de94d7c7ac1f7b55e0fc553a0e581a6228c6a2c49f5bcc"` [INFO] running `"docker" "rm" "-f" "78dae5acebbebcbb58de94d7c7ac1f7b55e0fc553a0e581a6228c6a2c49f5bcc"` [INFO] [stdout] 78dae5acebbebcbb58de94d7c7ac1f7b55e0fc553a0e581a6228c6a2c49f5bcc