[INFO] updating cached repository snoopcheri/advent-of-code-2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/snoopcheri/advent-of-code-2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/snoopcheri/advent-of-code-2016" "work/ex/clippy-test-run/sources/stable/gh/snoopcheri/advent-of-code-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/snoopcheri/advent-of-code-2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/snoopcheri/advent-of-code-2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snoopcheri/advent-of-code-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snoopcheri/advent-of-code-2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4fe78ea951dbef660f1856b702d76b2119159657 [INFO] sha for GitHub repo snoopcheri/advent-of-code-2016: 4fe78ea951dbef660f1856b702d76b2119159657 [INFO] validating manifest of snoopcheri/advent-of-code-2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of snoopcheri/advent-of-code-2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing snoopcheri/advent-of-code-2016 [INFO] finished frobbing snoopcheri/advent-of-code-2016 [INFO] frobbed toml for snoopcheri/advent-of-code-2016 written to work/ex/clippy-test-run/sources/stable/gh/snoopcheri/advent-of-code-2016/Cargo.toml [INFO] started frobbing snoopcheri/advent-of-code-2016 [INFO] finished frobbing snoopcheri/advent-of-code-2016 [INFO] frobbed toml for snoopcheri/advent-of-code-2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snoopcheri/advent-of-code-2016/Cargo.toml [INFO] crate snoopcheri/advent-of-code-2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting snoopcheri/advent-of-code-2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/snoopcheri/advent-of-code-2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0abf5e5f1d4531e6ca8622ca1d0881000e0749883ca4ec955eb30a7886ef603d [INFO] running `"docker" "start" "-a" "0abf5e5f1d4531e6ca8622ca1d0881000e0749883ca4ec955eb30a7886ef603d"` [INFO] [stderr] Checking either v1.0.2 [INFO] [stderr] Checking nom v2.0.1 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking itertools v0.5.6 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking advent-of-code-2016 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | length1: length1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `length1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | length2: length2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `length2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | length3: length3 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `length3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_4/room.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | sector_id: sector_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] extern crate itertools; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_example/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_example; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_1/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_2/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_3/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_4/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return input_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `input_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/puzzle_example/puzzle_example.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | '(' => floor = floor + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `floor += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/puzzle_example/puzzle_example.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | ')' => floor = floor - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `floor -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/puzzle_day_1/position.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn distance_from_origin(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | self.x = match is_in_distance(self.x + 1, self.y) { [INFO] [stderr] | __________________^ [INFO] [stderr] 20 | | true => self.x + 1, [INFO] [stderr] 21 | | false => self.x, [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x + 1, self.y) { self.x + 1 } else { self.x }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | self.x = match is_in_distance(self.x - 1, self.y) { [INFO] [stderr] | __________________^ [INFO] [stderr] 27 | | true => self.x - 1, [INFO] [stderr] 28 | | false => self.x, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x - 1, self.y) { self.x - 1 } else { self.x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | self.y = match is_in_distance(self.x, self.y - 1) { [INFO] [stderr] | __________________^ [INFO] [stderr] 34 | | true => self.y - 1, [INFO] [stderr] 35 | | false => self.y, [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x, self.y - 1) { self.y - 1 } else { self.y }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | self.y = match is_in_distance(self.x, self.y + 1) { [INFO] [stderr] | __________________^ [INFO] [stderr] 41 | | true => self.y + 1, [INFO] [stderr] 42 | | false => self.y, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x, self.y + 1) { self.y + 1 } else { self.y }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / true [INFO] [stderr] 19 | | && self.length1 + self.length2 > self.length3 [INFO] [stderr] 20 | | && self.length1 + self.length3 > self.length2 [INFO] [stderr] 21 | | && self.length2 + self.length3 > self.length1 [INFO] [stderr] | |_________________________________________________________^ help: try: `self.length1 + self.length2 > self.length3 && self.length1 + self.length3 > self.length2 && self.length2 + self.length3 > self.length1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/puzzle_day_4/puzzle_day_4.rs:17:42 [INFO] [stderr] | [INFO] [stderr] 17 | .map(|room| room.sector_id()) [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 18 | | .fold(0, |total, next| total + next) [INFO] [stderr] | |________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Checking hamcrest v0.1.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | length1: length1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `length1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | length2: length2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `length2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | length3: length3 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `length3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/puzzle_day_4/room.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | sector_id: sector_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] extern crate itertools; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_example/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_example; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_1/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_2/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_3/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/puzzle_day_4/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod puzzle_day_4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return input_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `input_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/puzzle_example/puzzle_example.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | '(' => floor = floor + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `floor += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/puzzle_example/puzzle_example.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | ')' => floor = floor - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `floor -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/puzzle_day_1/position.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn distance_from_origin(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | self.x = match is_in_distance(self.x + 1, self.y) { [INFO] [stderr] | __________________^ [INFO] [stderr] 20 | | true => self.x + 1, [INFO] [stderr] 21 | | false => self.x, [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x + 1, self.y) { self.x + 1 } else { self.x }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | self.x = match is_in_distance(self.x - 1, self.y) { [INFO] [stderr] | __________________^ [INFO] [stderr] 27 | | true => self.x - 1, [INFO] [stderr] 28 | | false => self.x, [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x - 1, self.y) { self.x - 1 } else { self.x }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | self.y = match is_in_distance(self.x, self.y - 1) { [INFO] [stderr] | __________________^ [INFO] [stderr] 34 | | true => self.y - 1, [INFO] [stderr] 35 | | false => self.y, [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x, self.y - 1) { self.y - 1 } else { self.y }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/puzzle_day_2/silly_num_pad.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | self.y = match is_in_distance(self.x, self.y + 1) { [INFO] [stderr] | __________________^ [INFO] [stderr] 41 | | true => self.y + 1, [INFO] [stderr] 42 | | false => self.y, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_in_distance(self.x, self.y + 1) { self.y + 1 } else { self.y }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/puzzle_day_3/triangle.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / true [INFO] [stderr] 19 | | && self.length1 + self.length2 > self.length3 [INFO] [stderr] 20 | | && self.length1 + self.length3 > self.length2 [INFO] [stderr] 21 | | && self.length2 + self.length3 > self.length1 [INFO] [stderr] | |_________________________________________________________^ help: try: `self.length1 + self.length2 > self.length3 && self.length1 + self.length3 > self.length2 && self.length2 + self.length3 > self.length1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/puzzle_day_3/parser.rs:48:54 [INFO] [stderr] | [INFO] [stderr] 48 | let parsing_result = super::three_u32_digits("111 222 333".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"111 222 333"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/puzzle_day_3/parser.rs:55:54 [INFO] [stderr] | [INFO] [stderr] 55 | let parsing_result = super::three_u32_digits("abc".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/puzzle_day_3/parser.rs:67:54 [INFO] [stderr] | [INFO] [stderr] 67 | let parsing_result = super::three_u32_digits("111 222".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"111 222"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/puzzle_day_4/puzzle_day_4.rs:17:42 [INFO] [stderr] | [INFO] [stderr] 17 | .map(|room| room.sector_id()) [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 18 | | .fold(0, |total, next| total + next) [INFO] [stderr] | |________________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.59s [INFO] running `"docker" "inspect" "0abf5e5f1d4531e6ca8622ca1d0881000e0749883ca4ec955eb30a7886ef603d"` [INFO] running `"docker" "rm" "-f" "0abf5e5f1d4531e6ca8622ca1d0881000e0749883ca4ec955eb30a7886ef603d"` [INFO] [stdout] 0abf5e5f1d4531e6ca8622ca1d0881000e0749883ca4ec955eb30a7886ef603d