[INFO] updating cached repository snark/dive-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/snark/dive-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/snark/dive-rs" "work/ex/clippy-test-run/sources/stable/gh/snark/dive-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/snark/dive-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/snark/dive-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snark/dive-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snark/dive-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8ee43cebaa9fd7f8b655152086af57aa9594cc11
[INFO] sha for GitHub repo snark/dive-rs: 8ee43cebaa9fd7f8b655152086af57aa9594cc11
[INFO] validating manifest of snark/dive-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of snark/dive-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing snark/dive-rs
[INFO] finished frobbing snark/dive-rs
[INFO] frobbed toml for snark/dive-rs written to work/ex/clippy-test-run/sources/stable/gh/snark/dive-rs/Cargo.toml
[INFO] started frobbing snark/dive-rs
[INFO] finished frobbing snark/dive-rs
[INFO] frobbed toml for snark/dive-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snark/dive-rs/Cargo.toml
[INFO] crate snark/dive-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting snark/dive-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/snark/dive-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3a2ffb31300acc5ce09065c13b38759305a65c798140cd1d1456685d74887bd1
[INFO] running `"docker" "start" "-a" "3a2ffb31300acc5ce09065c13b38759305a65c798140cd1d1456685d74887bd1"`
[INFO] [stderr]     Checking walkdir v1.0.3
[INFO] [stderr]     Checking thread-id v3.0.0
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking globset v0.1.2
[INFO] [stderr]     Checking thread_local v0.3.2
[INFO] [stderr]     Checking aho-corasick v0.6.1
[INFO] [stderr]     Checking ignore v0.1.6
[INFO] [stderr]     Checking regex v0.2.1
[INFO] [stderr]     Checking dive v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             case_sensitive: case_sensitive,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitive`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:112:13
[INFO] [stderr]     |
[INFO] [stderr] 112 |             case_sensitive: case_sensitive,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitive`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |             glob_options: glob_options,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `glob_options`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             rules: rules,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `rules`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             case_sensitive: case_sensitive,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitive`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:112:13
[INFO] [stderr]     |
[INFO] [stderr] 112 |             case_sensitive: case_sensitive,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `case_sensitive`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:114:13
[INFO] [stderr]     |
[INFO] [stderr] 114 |             glob_options: glob_options,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `glob_options`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/config.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |             rules: rules,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `rules`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/lib.rs:38:28
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     return ();
[INFO] [stderr]    |                            ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/config.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |         for target in vec!["exact", "regex", "regex-full"] {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["exact", "regex", "regex-full"]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:51:45
[INFO] [stderr]    |
[INFO] [stderr] 51 |             let r = if smart_match.contains("/") {
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config.rs:70:61
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     let mut front = elements.filter(|piece| piece.len() != 0)
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!piece.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config.rs:91:12
[INFO] [stderr]    |
[INFO] [stderr] 91 |         if rule_errors.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rule_errors.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 | /         match max_depth {
[INFO] [stderr] 96 | |             Err(ref e) => errors.push(format!("unable to parse maxdepth argument: {}", e)),
[INFO] [stderr] 97 | |             _ => (),
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(ref e) = max_depth { errors.push(format!("unable to parse maxdepth argument: {}", e)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/config.rs:106:12
[INFO] [stderr]     |
[INFO] [stderr] 106 |         if errors.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/config.rs:130:36
[INFO] [stderr]     |
[INFO] [stderr] 130 |     fn contains_glob_characters(s: &String) -> bool {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:20
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                    ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:39
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:58
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                                                          ^^^ help: try using a char instead: `']'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:77
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                                                                             ^^^ help: try using a char instead: `'?'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]   --> src/lib.rs:38:28
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     return ();
[INFO] [stderr]    |                            ^^ help: remove the `()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:27:32
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_glob_match(arg: &String, target: &GlobTarget) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/matching.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 | /                 match target {
[INFO] [stderr] 32 | |                     &GlobTarget::Name => Ok(MatchRule::NameGlob(g)),
[INFO] [stderr] 33 | |                     &GlobTarget::Path => Ok(MatchRule::PathGlob(g)),
[INFO] [stderr] 34 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 match *target {
[INFO] [stderr] 32 |                     GlobTarget::Name => Ok(MatchRule::NameGlob(g)),
[INFO] [stderr] 33 |                     GlobTarget::Path => Ok(MatchRule::PathGlob(g)),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:40:33
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn new_regex_match(arg: &String,
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:60:33
[INFO] [stderr]    |
[INFO] [stderr] 60 |     pub fn new_exact_match(arg: &String, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 60 |     pub fn new_exact_match(arg: &str, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                 ^^^^
[INFO] [stderr] help: change `arg.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 62 |             Ok(MatchRule::Exact(arg.to_string()))
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:68:34
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn new_substr_match(arg: &String, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn new_substr_match(arg: &str, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                  ^^^^
[INFO] [stderr] help: change `arg.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Ok(MatchRule::Substring(arg.to_string()))
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let mut m = config.rules.as_slice().len() == 0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.rules.as_slice().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 | /                 match filter {
[INFO] [stderr] 24 | |                     &config::Filetype::BlockSpecial => FileTypeExt::is_block_device,
[INFO] [stderr] 25 | |                     &config::Filetype::CharacterSpecial => FileTypeExt::is_char_device,
[INFO] [stderr] 26 | |                     &config::Filetype::Directory => FileType::is_dir,
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |                     &config::Filetype::SymbolicLink => FileType::is_symlink,
[INFO] [stderr] 31 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 match *filter {
[INFO] [stderr] 24 |                     config::Filetype::BlockSpecial => FileTypeExt::is_block_device,
[INFO] [stderr] 25 |                     config::Filetype::CharacterSpecial => FileTypeExt::is_char_device,
[INFO] [stderr] 26 |                     config::Filetype::Directory => FileType::is_dir,
[INFO] [stderr] 27 |                     config::Filetype::FIFO => FileTypeExt::is_fifo,
[INFO] [stderr] 28 |                     config::Filetype::RegularFile => FileType::is_file,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         match entry.metadata() {
[INFO] [stderr] 36 | |             Ok(md) => {
[INFO] [stderr] 37 | |                 if !filetype_filter(&md.file_type()) {
[INFO] [stderr] 38 | |                     return ();
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |             Err(_) => (),
[INFO] [stderr] 42 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if let Ok(md) = entry.metadata() {
[INFO] [stderr] 36 |     if !filetype_filter(&md.file_type()) {
[INFO] [stderr] 37 |         return ();
[INFO] [stderr] 38 |     }
[INFO] [stderr] 39 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:82:17
[INFO] [stderr]    |
[INFO] [stderr] 82 | /                 match result {
[INFO] [stderr] 83 | |                     Ok(entry) => handle_entry(entry, &config),
[INFO] [stderr] 84 | |                     _ => (),
[INFO] [stderr] 85 | |                 }
[INFO] [stderr]    | |_________________^ help: try this: `if let Ok(entry) = result { handle_entry(entry, &config) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/config.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |         for target in vec!["exact", "regex", "regex-full"] {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["exact", "regex", "regex-full"]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/config.rs:51:45
[INFO] [stderr]    |
[INFO] [stderr] 51 |             let r = if smart_match.contains("/") {
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config.rs:70:61
[INFO] [stderr]    |
[INFO] [stderr] 70 |                     let mut front = elements.filter(|piece| piece.len() != 0)
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!piece.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/config.rs:91:12
[INFO] [stderr]    |
[INFO] [stderr] 91 |         if rule_errors.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rule_errors.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 | /         match max_depth {
[INFO] [stderr] 96 | |             Err(ref e) => errors.push(format!("unable to parse maxdepth argument: {}", e)),
[INFO] [stderr] 97 | |             _ => (),
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(ref e) = max_depth { errors.push(format!("unable to parse maxdepth argument: {}", e)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/config.rs:106:12
[INFO] [stderr]     |
[INFO] [stderr] 106 |         if errors.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/config.rs:130:36
[INFO] [stderr]     |
[INFO] [stderr] 130 |     fn contains_glob_characters(s: &String) -> bool {
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:20
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                    ^^^ help: try using a char instead: `'*'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:39
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `'['`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:58
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                                                          ^^^ help: try using a char instead: `']'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/config.rs:131:77
[INFO] [stderr]     |
[INFO] [stderr] 131 |         s.contains("*") || s.contains("[") || s.contains("]") || s.contains("?")
[INFO] [stderr]     |                                                                             ^^^ help: try using a char instead: `'?'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:27:32
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn new_glob_match(arg: &String, target: &GlobTarget) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/matching.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 | /                 match target {
[INFO] [stderr] 32 | |                     &GlobTarget::Name => Ok(MatchRule::NameGlob(g)),
[INFO] [stderr] 33 | |                     &GlobTarget::Path => Ok(MatchRule::PathGlob(g)),
[INFO] [stderr] 34 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 match *target {
[INFO] [stderr] 32 |                     GlobTarget::Name => Ok(MatchRule::NameGlob(g)),
[INFO] [stderr] 33 |                     GlobTarget::Path => Ok(MatchRule::PathGlob(g)),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:40:33
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn new_regex_match(arg: &String,
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:60:33
[INFO] [stderr]    |
[INFO] [stderr] 60 |     pub fn new_exact_match(arg: &String, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 60 |     pub fn new_exact_match(arg: &str, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                 ^^^^
[INFO] [stderr] help: change `arg.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 62 |             Ok(MatchRule::Exact(arg.to_string()))
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/matching.rs:68:34
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn new_substr_match(arg: &String, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 68 |     pub fn new_substr_match(arg: &str, case_sensitive: bool) -> Result<MatchRule, String> {
[INFO] [stderr]    |                                  ^^^^
[INFO] [stderr] help: change `arg.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 70 |             Ok(MatchRule::Substring(arg.to_string()))
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:18:17
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let mut m = config.rules.as_slice().len() == 0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.rules.as_slice().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/lib.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 | /                 match filter {
[INFO] [stderr] 24 | |                     &config::Filetype::BlockSpecial => FileTypeExt::is_block_device,
[INFO] [stderr] 25 | |                     &config::Filetype::CharacterSpecial => FileTypeExt::is_char_device,
[INFO] [stderr] 26 | |                     &config::Filetype::Directory => FileType::is_dir,
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |                     &config::Filetype::SymbolicLink => FileType::is_symlink,
[INFO] [stderr] 31 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 match *filter {
[INFO] [stderr] 24 |                     config::Filetype::BlockSpecial => FileTypeExt::is_block_device,
[INFO] [stderr] 25 |                     config::Filetype::CharacterSpecial => FileTypeExt::is_char_device,
[INFO] [stderr] 26 |                     config::Filetype::Directory => FileType::is_dir,
[INFO] [stderr] 27 |                     config::Filetype::FIFO => FileTypeExt::is_fifo,
[INFO] [stderr] 28 |                     config::Filetype::RegularFile => FileType::is_file,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         match entry.metadata() {
[INFO] [stderr] 36 | |             Ok(md) => {
[INFO] [stderr] 37 | |                 if !filetype_filter(&md.file_type()) {
[INFO] [stderr] 38 | |                     return ();
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |             Err(_) => (),
[INFO] [stderr] 42 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if let Ok(md) = entry.metadata() {
[INFO] [stderr] 36 |     if !filetype_filter(&md.file_type()) {
[INFO] [stderr] 37 |         return ();
[INFO] [stderr] 38 |     }
[INFO] [stderr] 39 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lib.rs:82:17
[INFO] [stderr]    |
[INFO] [stderr] 82 | /                 match result {
[INFO] [stderr] 83 | |                     Ok(entry) => handle_entry(entry, &config),
[INFO] [stderr] 84 | |                     _ => (),
[INFO] [stderr] 85 | |                 }
[INFO] [stderr]    | |_________________^ help: try this: `if let Ok(entry) = result { handle_entry(entry, &config) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         print!("\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         print!("\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:17:38
[INFO] [stderr]    |
[INFO] [stderr] 17 | fn error_out(program: &str, message: &String, show_usage: Option<Options>) {
[INFO] [stderr]    |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |        show_usage.map(|opts| {
[INFO] [stderr]    |   _____^
[INFO] [stderr]    |  |_____|
[INFO] [stderr]    | ||
[INFO] [stderr] 20 | ||         print!("\n");
[INFO] [stderr] 21 | ||         print_usage(program, opts)
[INFO] [stderr] 22 | ||     });
[INFO] [stderr]    | ||______^- help: try this: `if let Some(opts) = show_usage { ... }`
[INFO] [stderr]    | |_______|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:17:38
[INFO] [stderr]    |
[INFO] [stderr] 17 | fn error_out(program: &str, message: &String, show_usage: Option<Options>) {
[INFO] [stderr]    |                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |        show_usage.map(|opts| {
[INFO] [stderr]    |   _____^
[INFO] [stderr]    |  |_____|
[INFO] [stderr]    | ||
[INFO] [stderr] 20 | ||         print!("\n");
[INFO] [stderr] 21 | ||         print_usage(program, opts)
[INFO] [stderr] 22 | ||     });
[INFO] [stderr]    | ||______^- help: try this: `if let Some(opts) = show_usage { ... }`
[INFO] [stderr]    | |_______|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.97s
[INFO] running `"docker" "inspect" "3a2ffb31300acc5ce09065c13b38759305a65c798140cd1d1456685d74887bd1"`
[INFO] running `"docker" "rm" "-f" "3a2ffb31300acc5ce09065c13b38759305a65c798140cd1d1456685d74887bd1"`
[INFO] [stdout] 3a2ffb31300acc5ce09065c13b38759305a65c798140cd1d1456685d74887bd1