[INFO] updating cached repository smokytheangel0/stack_setup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/smokytheangel0/stack_setup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/smokytheangel0/stack_setup" "work/ex/clippy-test-run/sources/stable/gh/smokytheangel0/stack_setup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smokytheangel0/stack_setup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/smokytheangel0/stack_setup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smokytheangel0/stack_setup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smokytheangel0/stack_setup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7b812587f70bc9eb5e02e44a2e19d476c0fffa65 [INFO] sha for GitHub repo smokytheangel0/stack_setup: 7b812587f70bc9eb5e02e44a2e19d476c0fffa65 [INFO] validating manifest of smokytheangel0/stack_setup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smokytheangel0/stack_setup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smokytheangel0/stack_setup [INFO] finished frobbing smokytheangel0/stack_setup [INFO] frobbed toml for smokytheangel0/stack_setup written to work/ex/clippy-test-run/sources/stable/gh/smokytheangel0/stack_setup/Cargo.toml [INFO] started frobbing smokytheangel0/stack_setup [INFO] finished frobbing smokytheangel0/stack_setup [INFO] frobbed toml for smokytheangel0/stack_setup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smokytheangel0/stack_setup/Cargo.toml [INFO] crate smokytheangel0/stack_setup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smokytheangel0/stack_setup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/smokytheangel0/stack_setup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3684d4e39b33a9e84b25fd2e19cc9735f939edca0266e0df5e8f3bd38784a95a [INFO] running `"docker" "start" "-a" "3684d4e39b33a9e84b25fd2e19cc9735f939edca0266e0df5e8f3bd38784a95a"` [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Checking webbrowser v0.3.1 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking setup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type or module `OpenOptions` [INFO] [stderr] --> src/main.rs:721:33 [INFO] [stderr] | [INFO] [stderr] 721 | let mut fileBOX = match OpenOptions::new() [INFO] [stderr] | ^^^^^^^^^^^ use of undeclared type or module `OpenOptions` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type or module `OpenOptions` [INFO] [stderr] --> src/main.rs:726:43 [INFO] [stderr] | [INFO] [stderr] 726 | Err(_) => OpenOptions::new().write(true).create_new(true).open(&homePATH).expect("could not create new bash_profile") [INFO] [stderr] | ^^^^^^^^^^^ use of undeclared type or module `OpenOptions` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type or module `OpenOptions` [INFO] [stderr] --> src/main.rs:721:33 [INFO] [stderr] | [INFO] [stderr] 721 | let mut fileBOX = match OpenOptions::new() [INFO] [stderr] | ^^^^^^^^^^^ use of undeclared type or module `OpenOptions` [INFO] [stderr] [INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type or module `OpenOptions` [INFO] [stderr] --> src/main.rs:726:43 [INFO] [stderr] | [INFO] [stderr] 726 | Err(_) => OpenOptions::new().write(true).create_new(true).open(&homePATH).expect("could not create new bash_profile") [INFO] [stderr] | ^^^^^^^^^^^ use of undeclared type or module `OpenOptions` [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | return outBOX [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `outBOX` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return "False".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"False".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:589:12 [INFO] [stderr] | [INFO] [stderr] 589 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 590 | | if filePATH.contains(&"AppImage"[..]) { [INFO] [stderr] 591 | | Command::new("chmod").arg("+x").arg(&filePATH).output().expect("failed to make AppImage executable"); [INFO] [stderr] 592 | | env::set_current_dir(&downloadsPATH).expect("setting cwd failed"); [INFO] [stderr] ... | [INFO] [stderr] 615 | | } [INFO] [stderr] 616 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 589 | } else if filePATH.contains(&"AppImage"[..]) { [INFO] [stderr] 590 | Command::new("chmod").arg("+x").arg(&filePATH).output().expect("failed to make AppImage executable"); [INFO] [stderr] 591 | env::set_current_dir(&downloadsPATH).expect("setting cwd failed"); [INFO] [stderr] 592 | let commandPATH = "./".to_string() + &properNAME; [INFO] [stderr] 593 | Command::new(commandPATH).output().expect("failed to execute appimage"); [INFO] [stderr] 594 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:642:16 [INFO] [stderr] | [INFO] [stderr] 642 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 643 | | if cfg!(target_os = "windows"){ [INFO] [stderr] 644 | | let path = dirs::home_dir().unwrap(); [INFO] [stderr] 645 | | let mut clonePATH = path.to_str() [INFO] [stderr] ... | [INFO] [stderr] 657 | | } [INFO] [stderr] 658 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 642 | } else if cfg!(target_os = "windows"){ [INFO] [stderr] 643 | let path = dirs::home_dir().unwrap(); [INFO] [stderr] 644 | let mut clonePATH = path.to_str() [INFO] [stderr] 645 | .unwrap() [INFO] [stderr] 646 | .to_owned(); [INFO] [stderr] 647 | clonePATH += "\\Desktop\\Code"; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:713:13 [INFO] [stderr] | [INFO] [stderr] 713 | homePATH [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:712:28 [INFO] [stderr] | [INFO] [stderr] 712 | let homePATH = path.to_str().unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:814:9 [INFO] [stderr] | [INFO] [stderr] 814 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:850:21 [INFO] [stderr] | [INFO] [stderr] 850 | Ok(_val) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:851:22 [INFO] [stderr] | [INFO] [stderr] 851 | Err(_err) => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:941:25 [INFO] [stderr] | [INFO] [stderr] 941 | / if answerBOX == "None" { [INFO] [stderr] 942 | | if downloadNAME == "android" || (cfg!(target_os = "macos") && downloadNAME == "git") { [INFO] [stderr] 943 | | let sleepTIME = time::Duration::from_secs(5); [INFO] [stderr] 944 | | thread::sleep(sleepTIME); [INFO] [stderr] ... | [INFO] [stderr] 947 | | [INFO] [stderr] 948 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 941 | if answerBOX == "None" && (downloadNAME == "android" || (cfg!(target_os = "macos") && downloadNAME == "git")) { [INFO] [stderr] 942 | let sleepTIME = time::Duration::from_secs(5); [INFO] [stderr] 943 | thread::sleep(sleepTIME); [INFO] [stderr] 944 | //focus_terminal(); [INFO] [stderr] 945 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | return testLIST; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `testLIST` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | return outBOX [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `outBOX` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return "False".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"False".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:589:12 [INFO] [stderr] | [INFO] [stderr] 589 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 590 | | if filePATH.contains(&"AppImage"[..]) { [INFO] [stderr] 591 | | Command::new("chmod").arg("+x").arg(&filePATH).output().expect("failed to make AppImage executable"); [INFO] [stderr] 592 | | env::set_current_dir(&downloadsPATH).expect("setting cwd failed"); [INFO] [stderr] ... | [INFO] [stderr] 615 | | } [INFO] [stderr] 616 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 589 | } else if filePATH.contains(&"AppImage"[..]) { [INFO] [stderr] 590 | Command::new("chmod").arg("+x").arg(&filePATH).output().expect("failed to make AppImage executable"); [INFO] [stderr] 591 | env::set_current_dir(&downloadsPATH).expect("setting cwd failed"); [INFO] [stderr] 592 | let commandPATH = "./".to_string() + &properNAME; [INFO] [stderr] 593 | Command::new(commandPATH).output().expect("failed to execute appimage"); [INFO] [stderr] 594 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:642:16 [INFO] [stderr] | [INFO] [stderr] 642 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 643 | | if cfg!(target_os = "windows"){ [INFO] [stderr] 644 | | let path = dirs::home_dir().unwrap(); [INFO] [stderr] 645 | | let mut clonePATH = path.to_str() [INFO] [stderr] ... | [INFO] [stderr] 657 | | } [INFO] [stderr] 658 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 642 | } else if cfg!(target_os = "windows"){ [INFO] [stderr] 643 | let path = dirs::home_dir().unwrap(); [INFO] [stderr] 644 | let mut clonePATH = path.to_str() [INFO] [stderr] 645 | .unwrap() [INFO] [stderr] 646 | .to_owned(); [INFO] [stderr] 647 | clonePATH += "\\Desktop\\Code"; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:713:13 [INFO] [stderr] | [INFO] [stderr] 713 | homePATH [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:712:28 [INFO] [stderr] | [INFO] [stderr] 712 | let homePATH = path.to_str().unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:814:9 [INFO] [stderr] | [INFO] [stderr] 814 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:850:21 [INFO] [stderr] | [INFO] [stderr] 850 | Ok(_val) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:851:22 [INFO] [stderr] | [INFO] [stderr] 851 | Err(_err) => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:941:25 [INFO] [stderr] | [INFO] [stderr] 941 | / if answerBOX == "None" { [INFO] [stderr] 942 | | if downloadNAME == "android" || (cfg!(target_os = "macos") && downloadNAME == "git") { [INFO] [stderr] 943 | | let sleepTIME = time::Duration::from_secs(5); [INFO] [stderr] 944 | | thread::sleep(sleepTIME); [INFO] [stderr] ... | [INFO] [stderr] 947 | | [INFO] [stderr] 948 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 941 | if answerBOX == "None" && (downloadNAME == "android" || (cfg!(target_os = "macos") && downloadNAME == "git")) { [INFO] [stderr] 942 | let sleepTIME = time::Duration::from_secs(5); [INFO] [stderr] 943 | thread::sleep(sleepTIME); [INFO] [stderr] 944 | //focus_terminal(); [INFO] [stderr] 945 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:1089:44 [INFO] [stderr] | [INFO] [stderr] 1089 | let randomNUM = range.gen_range(0, 1000000).to_string(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1180:17 [INFO] [stderr] | [INFO] [stderr] 1180 | androidFOLDER [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1179:37 [INFO] [stderr] | [INFO] [stderr] 1179 | let androidFOLDER = "C:\\Program Files\\".to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1183:17 [INFO] [stderr] | [INFO] [stderr] 1183 | androidFOLDER [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1182:37 [INFO] [stderr] | [INFO] [stderr] 1182 | let androidFOLDER = "/Applications/".to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:1215:20 [INFO] [stderr] | [INFO] [stderr] 1215 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1216 | | if folderNAME.contains(&"android-studio"[..]) { [INFO] [stderr] 1217 | | assert_eq!(true, true); [INFO] [stderr] 1218 | | return [INFO] [stderr] ... | [INFO] [stderr] 1221 | | } [INFO] [stderr] 1222 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1215 | } else if folderNAME.contains(&"android-studio"[..]) { [INFO] [stderr] 1216 | assert_eq!(true, true); [INFO] [stderr] 1217 | return [INFO] [stderr] 1218 | } else { [INFO] [stderr] 1219 | continue [INFO] [stderr] 1220 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:1279:20 [INFO] [stderr] | [INFO] [stderr] 1279 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1280 | | if folderNAME.contains(&"Sdk"[..]) { [INFO] [stderr] 1281 | | assert_eq!(true, true); [INFO] [stderr] 1282 | | return [INFO] [stderr] ... | [INFO] [stderr] 1285 | | } [INFO] [stderr] 1286 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1279 | } else if folderNAME.contains(&"Sdk"[..]) { [INFO] [stderr] 1280 | assert_eq!(true, true); [INFO] [stderr] 1281 | return [INFO] [stderr] 1282 | } else { [INFO] [stderr] 1283 | continue [INFO] [stderr] 1284 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1303:17 [INFO] [stderr] | [INFO] [stderr] 1303 | androidPATHs [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1298:36 [INFO] [stderr] | [INFO] [stderr] 1298 | let androidPATHs = [ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 1299 | | androidPATH, [INFO] [stderr] 1300 | | "$ANDROID_HOME/tools:$PATH".to_owned(), [INFO] [stderr] 1301 | | "$ANDROID_HOME/platform-tools:$PATH".to_owned() [INFO] [stderr] 1302 | | ]; [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1311:17 [INFO] [stderr] | [INFO] [stderr] 1311 | androidPATHs [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1306:36 [INFO] [stderr] | [INFO] [stderr] 1306 | let androidPATHs = [ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 1307 | | androidPATH, [INFO] [stderr] 1308 | | "$ANDROID_HOME/tools:$PATH".to_owned(), [INFO] [stderr] 1309 | | "$ANDROID_HOME/platform-tools:$PATH".to_owned() [INFO] [stderr] 1310 | | ]; [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1355:17 [INFO] [stderr] | [INFO] [stderr] 1355 | starFOLDER [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1354:34 [INFO] [stderr] | [INFO] [stderr] 1354 | let starFOLDER = "C:\\Program Files\\".to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1358:17 [INFO] [stderr] | [INFO] [stderr] 1358 | starFOLDER [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1357:34 [INFO] [stderr] | [INFO] [stderr] 1357 | let starFOLDER = "/Applications/".to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:1390:20 [INFO] [stderr] | [INFO] [stderr] 1390 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1391 | | if folderNAME.contains(&"StarUML"[..]) { [INFO] [stderr] 1392 | | assert_eq!(true, true); [INFO] [stderr] 1393 | | return [INFO] [stderr] ... | [INFO] [stderr] 1396 | | } [INFO] [stderr] 1397 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1390 | } else if folderNAME.contains(&"StarUML"[..]) { [INFO] [stderr] 1391 | assert_eq!(true, true); [INFO] [stderr] 1392 | return [INFO] [stderr] 1393 | } else { [INFO] [stderr] 1394 | continue [INFO] [stderr] 1395 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1456:21 [INFO] [stderr] | [INFO] [stderr] 1456 | vsFOLDER [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1455:36 [INFO] [stderr] | [INFO] [stderr] 1455 | let vsFOLDER = "/Applications/".to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:1460:21 [INFO] [stderr] | [INFO] [stderr] 1460 | vsFOLDER [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:1459:36 [INFO] [stderr] | [INFO] [stderr] 1459 | let vsFOLDER = "/usr/bin/".to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:1477:24 [INFO] [stderr] | [INFO] [stderr] 1477 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 1478 | | if folderNAME == &"code"[..] { [INFO] [stderr] 1479 | | assert_eq!(true, true); [INFO] [stderr] 1480 | | return [INFO] [stderr] ... | [INFO] [stderr] 1483 | | } [INFO] [stderr] 1484 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1477 | } else if folderNAME == &"code"[..] { [INFO] [stderr] 1478 | assert_eq!(true, true); [INFO] [stderr] 1479 | return [INFO] [stderr] 1480 | } else { [INFO] [stderr] 1481 | continue [INFO] [stderr] 1482 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0433`. [INFO] [stderr] error: Could not compile `setup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0433`. [INFO] [stderr] error: Could not compile `setup`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3684d4e39b33a9e84b25fd2e19cc9735f939edca0266e0df5e8f3bd38784a95a"` [INFO] running `"docker" "rm" "-f" "3684d4e39b33a9e84b25fd2e19cc9735f939edca0266e0df5e8f3bd38784a95a"` [INFO] [stdout] 3684d4e39b33a9e84b25fd2e19cc9735f939edca0266e0df5e8f3bd38784a95a