[INFO] updating cached repository smoench/maexchen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/smoench/maexchen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/smoench/maexchen" "work/ex/clippy-test-run/sources/stable/gh/smoench/maexchen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smoench/maexchen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/smoench/maexchen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smoench/maexchen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smoench/maexchen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bd22f41af3bb12d42ad992e243d8631e79b1865a
[INFO] sha for GitHub repo smoench/maexchen: bd22f41af3bb12d42ad992e243d8631e79b1865a
[INFO] validating manifest of smoench/maexchen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of smoench/maexchen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing smoench/maexchen
[INFO] finished frobbing smoench/maexchen
[INFO] frobbed toml for smoench/maexchen written to work/ex/clippy-test-run/sources/stable/gh/smoench/maexchen/Cargo.toml
[INFO] started frobbing smoench/maexchen
[INFO] finished frobbing smoench/maexchen
[INFO] frobbed toml for smoench/maexchen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smoench/maexchen/Cargo.toml
[INFO] crate smoench/maexchen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting smoench/maexchen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/smoench/maexchen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 337cd71d7591e6935e5f6d0a421787b047ea463352f97a3504594764033ea778
[INFO] running `"docker" "start" "-a" "337cd71d7591e6935e5f6d0a421787b047ea463352f97a3504594764033ea778"`
[INFO] [stderr]     Checking maexchen v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: variable `last_announced_dice` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 |     let mut last_announced_dice: String = String::new();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_last_announced_dice` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `last_announced_dice` is never read
[INFO] [stderr]   --> src/main.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             last_announced_dice = split_msg[2].to_string();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `hash`
[INFO] [stderr]    --> src/main.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |     let hash: Vec<&str> = vec![
[INFO] [stderr]     |         ^^^^ help: consider using `_hash` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `a`
[INFO] [stderr]    --> src/main.rs:111:15
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn is_greater(a: String, b: String) -> bool {
[INFO] [stderr]     |               ^ help: consider using `_a` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `b`
[INFO] [stderr]    --> src/main.rs:111:26
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn is_greater(a: String, b: String) -> bool {
[INFO] [stderr]     |                          ^ help: consider using `_b` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_greater`
[INFO] [stderr]    --> src/main.rs:111:1
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn is_greater(a: String, b: String) -> bool {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:19:12
[INFO] [stderr]    |
[INFO] [stderr] 19 |         if msg.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:25:12
[INFO] [stderr]    |
[INFO] [stderr] 25 |         if split_msg.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `split_msg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/main.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |         if round_started == false {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!round_started`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 |             if my_dice.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `my_dice.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _res =`
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let _res = socket.set_read_timeout(dur).expect("failed to set timeout");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: variable `last_announced_dice` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 |     let mut last_announced_dice: String = String::new();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_last_announced_dice` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `last_announced_dice` is never read
[INFO] [stderr]   --> src/main.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             last_announced_dice = split_msg[2].to_string();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `hash`
[INFO] [stderr]    --> src/main.rs:112:9
[INFO] [stderr]     |
[INFO] [stderr] 112 |     let hash: Vec<&str> = vec![
[INFO] [stderr]     |         ^^^^ help: consider using `_hash` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `a`
[INFO] [stderr]    --> src/main.rs:111:15
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn is_greater(a: String, b: String) -> bool {
[INFO] [stderr]     |               ^ help: consider using `_a` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `b`
[INFO] [stderr]    --> src/main.rs:111:26
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn is_greater(a: String, b: String) -> bool {
[INFO] [stderr]     |                          ^ help: consider using `_b` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_greater`
[INFO] [stderr]    --> src/main.rs:111:1
[INFO] [stderr]     |
[INFO] [stderr] 111 | fn is_greater(a: String, b: String) -> bool {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:19:12
[INFO] [stderr]    |
[INFO] [stderr] 19 |         if msg.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:25:12
[INFO] [stderr]    |
[INFO] [stderr] 25 |         if split_msg.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `split_msg.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/main.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |         if round_started == false {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!round_started`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 |             if my_dice.len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `my_dice.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _res =`
[INFO] [stderr]   --> src/main.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     let _res = socket.set_read_timeout(dur).expect("failed to set timeout");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.63s
[INFO] running `"docker" "inspect" "337cd71d7591e6935e5f6d0a421787b047ea463352f97a3504594764033ea778"`
[INFO] running `"docker" "rm" "-f" "337cd71d7591e6935e5f6d0a421787b047ea463352f97a3504594764033ea778"`
[INFO] [stdout] 337cd71d7591e6935e5f6d0a421787b047ea463352f97a3504594764033ea778