[INFO] updating cached repository smmckay/aws-tools
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/smmckay/aws-tools
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/smmckay/aws-tools" "work/ex/clippy-test-run/sources/stable/gh/smmckay/aws-tools"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smmckay/aws-tools'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/smmckay/aws-tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smmckay/aws-tools"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smmckay/aws-tools'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0a4019bf47cd3c446c2c4575802ecb5b66540cf3
[INFO] sha for GitHub repo smmckay/aws-tools: 0a4019bf47cd3c446c2c4575802ecb5b66540cf3
[INFO] validating manifest of smmckay/aws-tools on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of smmckay/aws-tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing smmckay/aws-tools
[INFO] finished frobbing smmckay/aws-tools
[INFO] frobbed toml for smmckay/aws-tools written to work/ex/clippy-test-run/sources/stable/gh/smmckay/aws-tools/Cargo.toml
[INFO] started frobbing smmckay/aws-tools
[INFO] finished frobbing smmckay/aws-tools
[INFO] frobbed toml for smmckay/aws-tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smmckay/aws-tools/Cargo.toml
[INFO] crate smmckay/aws-tools has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting smmckay/aws-tools against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/smmckay/aws-tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ace6789d58a9f2adf6cd6f886bc883eb2525de17a9c247de5ed21e734e0972f0
[INFO] running `"docker" "start" "-a" "ace6789d58a9f2adf6cd6f886bc883eb2525de17a9c247de5ed21e734e0972f0"`
[INFO] [stderr]     Checking futures v0.1.22
[INFO] [stderr]    Compiling regex v1.0.1
[INFO] [stderr]    Compiling openssl-sys v0.9.33
[INFO] [stderr]     Checking xml-rs v0.7.0
[INFO] [stderr]     Checking mio v0.6.15
[INFO] [stderr]     Checking aho-corasick v0.6.5
[INFO] [stderr]     Checking crossbeam-epoch v0.4.3
[INFO] [stderr]     Checking idna v0.1.5
[INFO] [stderr]    Compiling rusoto_core v0.32.0
[INFO] [stderr]     Checking serde_json v1.0.22
[INFO] [stderr]     Checking crossbeam-deque v0.3.1
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]    Compiling syn v0.14.4
[INFO] [stderr]     Checking digest v0.7.4
[INFO] [stderr]     Checking url v1.7.1
[INFO] [stderr]    Compiling openssl v0.9.24
[INFO] [stderr]     Checking hmac v0.5.0
[INFO] [stderr]     Checking sha2 v0.7.1
[INFO] [stderr]     Checking tokio-io v0.1.7
[INFO] [stderr]     Checking tokio-executor v0.1.2
[INFO] [stderr]     Checking tokio-service v0.1.0
[INFO] [stderr]     Checking futures-cpupool v0.1.8
[INFO] [stderr]     Checking relay v0.1.1
[INFO] [stderr]     Checking want v0.0.4
[INFO] [stderr]     Checking tokio-threadpool v0.1.5
[INFO] [stderr]     Checking tokio-timer v0.2.4
[INFO] [stderr]     Checking tokio-reactor v0.1.2
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking native-tls v0.1.5
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio-udp v0.1.1
[INFO] [stderr]     Checking tokio-fs v0.1.1
[INFO] [stderr]    Compiling serde_derive v1.0.70
[INFO] [stderr]     Checking tokio v0.1.7
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper v0.11.27
[INFO] [stderr]     Checking docopt v1.0.0
[INFO] [stderr]     Checking hyper-tls v0.1.3
[INFO] [stderr]     Checking rusoto_credential v0.11.0
[INFO] [stderr]     Checking rusoto_s3 v0.32.0
[INFO] [stderr]     Checking rusoto_sqs v0.32.0
[INFO] [stderr]     Checking aws-tools v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:19:15
[INFO] [stderr]    |
[INFO] [stderr] 19 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sz`
[INFO] [stderr]    --> src/bin/s3-bulk-move.rs:148:52
[INFO] [stderr]     |
[INFO] [stderr] 148 |                 objs = Box::new(objs.filter(|(key, sz)| {
[INFO] [stderr]     |                                                    ^^ help: consider using `_sz` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dest_client`
[INFO] [stderr]    --> src/bin/s3-bulk-move.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let dest_client = S3Client::simple(dest_region);
[INFO] [stderr]     |         ^^^^^^^^^^^ help: consider using `_dest_client` instead
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:73:24
[INFO] [stderr]    |
[INFO] [stderr] 73 |             prefix: if prefix.len() > 0 { Some(prefix) } else { None },
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!prefix.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |        run().err().map(|err| {
[INFO] [stderr]    |   _____^
[INFO] [stderr]    |  |_____|
[INFO] [stderr]    | ||
[INFO] [stderr] 86 | ||         println!("{}", err);
[INFO] [stderr] 87 | ||         std::process::exit(1)
[INFO] [stderr] 88 | ||     });
[INFO] [stderr]    | ||______^- help: try this: `if let Some(err) = run().err() { ... }`
[INFO] [stderr]    | |_______|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:91:61
[INFO] [stderr]    |
[INFO] [stderr] 91 | fn get_region(region_flag: &Option<String>, default_region: &String) -> Result<Region, impl std::error::Error> {
[INFO] [stderr]    |                                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/bin/s3-bulk-move.rs:102:10
[INFO] [stderr]     |
[INFO] [stderr] 102 |         .unwrap_or("us-east-1".to_owned());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "us-east-1".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:19:15
[INFO] [stderr]    |
[INFO] [stderr] 19 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `sz`
[INFO] [stderr]    --> src/bin/s3-bulk-move.rs:148:52
[INFO] [stderr]     |
[INFO] [stderr] 148 |                 objs = Box::new(objs.filter(|(key, sz)| {
[INFO] [stderr]     |                                                    ^^ help: consider using `_sz` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dest_client`
[INFO] [stderr]    --> src/bin/s3-bulk-move.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let dest_client = S3Client::simple(dest_region);
[INFO] [stderr]     |         ^^^^^^^^^^^ help: consider using `_dest_client` instead
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:73:24
[INFO] [stderr]    |
[INFO] [stderr] 73 |             prefix: if prefix.len() > 0 { Some(prefix) } else { None },
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!prefix.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 |        run().err().map(|err| {
[INFO] [stderr]    |   _____^
[INFO] [stderr]    |  |_____|
[INFO] [stderr]    | ||
[INFO] [stderr] 86 | ||         println!("{}", err);
[INFO] [stderr] 87 | ||         std::process::exit(1)
[INFO] [stderr] 88 | ||     });
[INFO] [stderr]    | ||______^- help: try this: `if let Some(err) = run().err() { ... }`
[INFO] [stderr]    | |_______|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bin/s3-bulk-move.rs:91:61
[INFO] [stderr]    |
[INFO] [stderr] 91 | fn get_region(region_flag: &Option<String>, default_region: &String) -> Result<Region, impl std::error::Error> {
[INFO] [stderr]    |                                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/bin/s3-bulk-move.rs:102:10
[INFO] [stderr]     |
[INFO] [stderr] 102 |         .unwrap_or("us-east-1".to_owned());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "us-east-1".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 00s
[INFO] running `"docker" "inspect" "ace6789d58a9f2adf6cd6f886bc883eb2525de17a9c247de5ed21e734e0972f0"`
[INFO] running `"docker" "rm" "-f" "ace6789d58a9f2adf6cd6f886bc883eb2525de17a9c247de5ed21e734e0972f0"`
[INFO] [stdout] ace6789d58a9f2adf6cd6f886bc883eb2525de17a9c247de5ed21e734e0972f0