[INFO] updating cached repository sminez/arthroprod [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sminez/arthroprod [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sminez/arthroprod" "work/ex/clippy-test-run/sources/stable/gh/sminez/arthroprod"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sminez/arthroprod'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sminez/arthroprod" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sminez/arthroprod"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sminez/arthroprod'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e091e923fefb4e4915059b4bffd3622da571bf14 [INFO] sha for GitHub repo sminez/arthroprod: e091e923fefb4e4915059b4bffd3622da571bf14 [INFO] validating manifest of sminez/arthroprod on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sminez/arthroprod on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sminez/arthroprod [INFO] finished frobbing sminez/arthroprod [INFO] frobbed toml for sminez/arthroprod written to work/ex/clippy-test-run/sources/stable/gh/sminez/arthroprod/Cargo.toml [INFO] started frobbing sminez/arthroprod [INFO] finished frobbing sminez/arthroprod [INFO] frobbed toml for sminez/arthroprod written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sminez/arthroprod/Cargo.toml [INFO] crate sminez/arthroprod has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sminez/arthroprod against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sminez/arthroprod:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e7720f2aeefbc7e524ca8f04e9c4e68005bb17bec528fabab9a51ff00c7adccb [INFO] running `"docker" "start" "-a" "e7720f2aeefbc7e524ca8f04e9c4e68005bb17bec528fabab9a51ff00c7adccb"` [INFO] [stderr] Checking libc v0.2.31 [INFO] [stderr] Checking getopts v0.2.15 [INFO] [stderr] Checking arthroprod v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/types/component.rs:38:62 [INFO] [stderr] | [INFO] [stderr] 38 | Component::Quadrivector(ref i, ref j, ref k, ref l) => write!(f, "{}{}{}{}", i, j, k, l), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algebra.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | return Alpha::from_comp(&comp, &sign); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Alpha::from_comp(&comp, &sign)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/types/component.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | _ => return Err(ArError::InvalidComponentOrder(String::from(ix))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ArError::InvalidComponentOrder(String::from(ix)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/algebra.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | Mvec::from(i.ar_prod(j)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Mvec::from()`: `i.ar_prod(j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/algebra.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 134 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/algebra.rs:134:30 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Alpha` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/algebra.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn find_prod_override(i: &Alpha, j: &Alpha, metric: &HashMap, allowed: &Allowed) -> Alpha { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/algebra.rs:197:8 [INFO] [stderr] | [INFO] [stderr] 197 | if components.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/algebra.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | let comp = targets [INFO] [stderr] | ________________^ [INFO] [stderr] 207 | | .get(&KeyVec::new(components.clone())) [INFO] [stderr] 208 | | .expect(&format!("{:?} not in TARGETS.", components)) [INFO] [stderr] 209 | | .clone(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 206 | let comp = *targets [INFO] [stderr] 207 | .get(&KeyVec::new(components.clone())) [INFO] [stderr] 208 | .expect(&format!("{:?} not in TARGETS.", components)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/algebra.rs:208:10 [INFO] [stderr] | [INFO] [stderr] 208 | .expect(&format!("{:?} not in TARGETS.", components)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{:?} not in TARGETS.", components))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | point = point + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `point += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | vectors = vectors + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vectors += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | 2 => bivectors = bivectors + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bivectors += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:105:22 [INFO] [stderr] | [INFO] [stderr] 105 | 3 => trivectors = trivectors + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trivectors += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | 4 => quadrivector = quadrivector + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quadrivector += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config.rs:122:51 [INFO] [stderr] | [INFO] [stderr] 122 | return Err(ArError::InvalidConfig(String::from( [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 123 | | format!("ALLOWED contained wrong number of {}: {} != {}", name, have, want), [INFO] [stderr] 124 | | ))); [INFO] [stderr] | |_________________^ help: consider removing `String::from()`: `format!("ALLOWED contained wrong number of {}: {} != {}", name, have, want)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/alpha.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | mvec.add_pair(Pair::from_alpha(self.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/alpha.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | mvec.add_pair(Pair::from_alpha(_rhs.clone())).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*_rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/types/alpha.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let sign = match ix.starts_with("-") { [INFO] [stderr] | ____________________^ [INFO] [stderr] 85 | | true => Sign::Neg, [INFO] [stderr] 86 | | false => Sign::Pos, [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ix.starts_with("-") { Sign::Neg } else { Sign::Pos }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types/alpha.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | let sign = match ix.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/alpha.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn from_comp(comp: &Component, sign: &Sign) -> Alpha { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Component` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/alpha.rs:103:46 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn from_comp(comp: &Component, sign: &Sign) -> Alpha { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Sign` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/alpha.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | comp: comp.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*comp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/alpha.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | sign: sign.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*sign` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/alpha.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn is_point(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/alpha.rs:126:19 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn as_vec(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/component.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn as_vec(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/types/mvec.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | String::from(format!(" α{}: (", c)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!(" α{}: (", c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::mvec::Mvec` [INFO] [stderr] --> src/types/mvec.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new() -> Mvec { [INFO] [stderr] 53 | | let components = HashMap::new(); [INFO] [stderr] 54 | | let order = ALPHAS [INFO] [stderr] 55 | | .iter() [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for types::mvec::Mvec { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/types/mvec.rs:68:57 [INFO] [stderr] | [INFO] [stderr] 68 | let current_comps = self.components.entry(comp).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/mvec.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn get(&self, c: &Component) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Component` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/sign.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn combine_with(&self, j: &Sign) -> Sign { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types/sign.rs:26:35 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn combine_with(&self, j: &Sign) -> Sign { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Sign` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/types/mod.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / impl Hash for KeyVec { [INFO] [stderr] 39 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 40 | | let KeyVec(ref elems) = *self; [INFO] [stderr] 41 | | for elem in elems.iter() { [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/types/mod.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Eq, PartialEq, Debug, Clone)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arthroprod`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "e7720f2aeefbc7e524ca8f04e9c4e68005bb17bec528fabab9a51ff00c7adccb"` [INFO] running `"docker" "rm" "-f" "e7720f2aeefbc7e524ca8f04e9c4e68005bb17bec528fabab9a51ff00c7adccb"` [INFO] [stdout] e7720f2aeefbc7e524ca8f04e9c4e68005bb17bec528fabab9a51ff00c7adccb