[INFO] updating cached repository smilingleo/draw2md [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/smilingleo/draw2md [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/smilingleo/draw2md" "work/ex/clippy-test-run/sources/stable/gh/smilingleo/draw2md"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smilingleo/draw2md'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/smilingleo/draw2md" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smilingleo/draw2md"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smilingleo/draw2md'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 168f0b8b2535bdbb6d116646dcb2b0889bacfb40 [INFO] sha for GitHub repo smilingleo/draw2md: 168f0b8b2535bdbb6d116646dcb2b0889bacfb40 [INFO] validating manifest of smilingleo/draw2md on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smilingleo/draw2md on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smilingleo/draw2md [INFO] finished frobbing smilingleo/draw2md [INFO] frobbed toml for smilingleo/draw2md written to work/ex/clippy-test-run/sources/stable/gh/smilingleo/draw2md/Cargo.toml [INFO] started frobbing smilingleo/draw2md [INFO] finished frobbing smilingleo/draw2md [INFO] frobbed toml for smilingleo/draw2md written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smilingleo/draw2md/Cargo.toml [INFO] crate smilingleo/draw2md has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smilingleo/draw2md against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/smilingleo/draw2md:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 075d3ae85f6ebc7e984831dee3958a13370ddf3c1bd19e0d1d680fb3f656c965 [INFO] running `"docker" "start" "-a" "075d3ae85f6ebc7e984831dee3958a13370ddf3c1bd19e0d1d680fb3f656c965"` [INFO] [stderr] Checking data-encoding v2.1.1 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking xmlJSON v0.2.0 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking draw2md v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if object_name.trim().len() > 0 && tooltip_markdown.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!object_name.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:49:44 [INFO] [stderr] | [INFO] [stderr] 49 | if object_name.trim().len() > 0 && tooltip_markdown.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tooltip_markdown.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:49:12 [INFO] [stderr] | [INFO] [stderr] 49 | if object_name.trim().len() > 0 && tooltip_markdown.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!object_name.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:49:44 [INFO] [stderr] | [INFO] [stderr] 49 | if object_name.trim().len() > 0 && tooltip_markdown.trim().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tooltip_markdown.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.03s [INFO] running `"docker" "inspect" "075d3ae85f6ebc7e984831dee3958a13370ddf3c1bd19e0d1d680fb3f656c965"` [INFO] running `"docker" "rm" "-f" "075d3ae85f6ebc7e984831dee3958a13370ddf3c1bd19e0d1d680fb3f656c965"` [INFO] [stdout] 075d3ae85f6ebc7e984831dee3958a13370ddf3c1bd19e0d1d680fb3f656c965