[INFO] updating cached repository slavovojacek/8QP_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/slavovojacek/8QP_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/slavovojacek/8QP_rust" "work/ex/clippy-test-run/sources/stable/gh/slavovojacek/8QP_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/slavovojacek/8QP_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/slavovojacek/8QP_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slavovojacek/8QP_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slavovojacek/8QP_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d954f74f594f63fe348d514e1cdd08ecc3d3580f [INFO] sha for GitHub repo slavovojacek/8QP_rust: d954f74f594f63fe348d514e1cdd08ecc3d3580f [INFO] validating manifest of slavovojacek/8QP_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slavovojacek/8QP_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slavovojacek/8QP_rust [INFO] finished frobbing slavovojacek/8QP_rust [INFO] frobbed toml for slavovojacek/8QP_rust written to work/ex/clippy-test-run/sources/stable/gh/slavovojacek/8QP_rust/Cargo.toml [INFO] started frobbing slavovojacek/8QP_rust [INFO] finished frobbing slavovojacek/8QP_rust [INFO] frobbed toml for slavovojacek/8QP_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slavovojacek/8QP_rust/Cargo.toml [INFO] crate slavovojacek/8QP_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slavovojacek/8QP_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/slavovojacek/8QP_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0773630e08691232dd03a38f3b5169f870344fb4b2740755667f11d79e68552 [INFO] running `"docker" "start" "-a" "f0773630e08691232dd03a38f3b5169f870344fb4b2740755667f11d79e68552"` [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking eight_queen_problem v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:65:65 [INFO] [stderr] | [INFO] [stderr] 65 | true => board[r as usize][c as usize] = Square::Queen { r: r, c: c }, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:65:71 [INFO] [stderr] | [INFO] [stderr] 65 | true => board[r as usize][c as usize] = Square::Queen { r: r, c: c }, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:65:65 [INFO] [stderr] | [INFO] [stderr] 65 | true => board[r as usize][c as usize] = Square::Queen { r: r, c: c }, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:65:71 [INFO] [stderr] | [INFO] [stderr] 65 | true => board[r as usize][c as usize] = Square::Queen { r: r, c: c }, [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: value assigned to `empty_squares` is never read [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut empty_squares: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:113:33 [INFO] [stderr] | [INFO] [stderr] 113 | fn fill_col(board: &mut Board, (r, c): Position) -> Result<(), Position> { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if (empty_squares.len() == 0) && (queens.len() as u8 == size) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `empty_squares.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:51:62 [INFO] [stderr] | [INFO] [stderr] 51 | queen_position = pick_random_pos(&empty_squares).unwrap_or(gen_random_pos(size)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| gen_random_pos(size))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / match is_empty_at_pos(&board, (r, c)) { [INFO] [stderr] 65 | | true => board[r as usize][c as usize] = Square::Queen { r: r, c: c }, [INFO] [stderr] 66 | | _ => error = Some((r as u8, c as u8)), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_empty_at_pos(&board, (r, c)) { board[r as usize][c as usize] = Square::Queen { r: r, c: c } } else { error = Some((r as u8, c as u8)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_index` is used to index `board` [INFO] [stderr] --> src/main.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | for row_index in 0..board.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for (row_index, ) in board.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | / match col_index == c as usize { [INFO] [stderr] 99 | | true => {} [INFO] [stderr] 100 | | _ => error = Some((row_index as u8, col_index as u8)), [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if !(col_index == c as usize) { error = Some((row_index as u8, col_index as u8)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_index` is used to index `board` [INFO] [stderr] --> src/main.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | for row_index in 0..board.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 115 | for (row_index, ) in board.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | / match col_index == c as usize { [INFO] [stderr] 124 | | true => {} [INFO] [stderr] 125 | | _ => error = Some((row_index as u8, col_index as u8)), [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if !(col_index == c as usize) { error = Some((row_index as u8, col_index as u8)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / match fill_pos(board, position) { [INFO] [stderr] 142 | | Err(pos) => error = Some(pos), [INFO] [stderr] 143 | | _ => {} [INFO] [stderr] 144 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(pos) = fill_pos(board, position) { error = Some(pos) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | fn is_empty_at_pos(board: &Board, (r, c): Position) -> bool { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | fn pick_random_pos(positions: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Position]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: value assigned to `empty_squares` is never read [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut empty_squares: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:113:33 [INFO] [stderr] | [INFO] [stderr] 113 | fn fill_col(board: &mut Board, (r, c): Position) -> Result<(), Position> { [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if (empty_squares.len() == 0) && (queens.len() as u8 == size) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `empty_squares.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:51:62 [INFO] [stderr] | [INFO] [stderr] 51 | queen_position = pick_random_pos(&empty_squares).unwrap_or(gen_random_pos(size)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| gen_random_pos(size))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / match is_empty_at_pos(&board, (r, c)) { [INFO] [stderr] 65 | | true => board[r as usize][c as usize] = Square::Queen { r: r, c: c }, [INFO] [stderr] 66 | | _ => error = Some((r as u8, c as u8)), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if is_empty_at_pos(&board, (r, c)) { board[r as usize][c as usize] = Square::Queen { r: r, c: c } } else { error = Some((r as u8, c as u8)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_index` is used to index `board` [INFO] [stderr] --> src/main.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | for row_index in 0..board.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for (row_index, ) in board.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | / match col_index == c as usize { [INFO] [stderr] 99 | | true => {} [INFO] [stderr] 100 | | _ => error = Some((row_index as u8, col_index as u8)), [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if !(col_index == c as usize) { error = Some((row_index as u8, col_index as u8)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row_index` is used to index `board` [INFO] [stderr] --> src/main.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | for row_index in 0..board.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 115 | for (row_index, ) in board.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:123:25 [INFO] [stderr] | [INFO] [stderr] 123 | / match col_index == c as usize { [INFO] [stderr] 124 | | true => {} [INFO] [stderr] 125 | | _ => error = Some((row_index as u8, col_index as u8)), [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if !(col_index == c as usize) { error = Some((row_index as u8, col_index as u8)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / match fill_pos(board, position) { [INFO] [stderr] 142 | | Err(pos) => error = Some(pos), [INFO] [stderr] 143 | | _ => {} [INFO] [stderr] 144 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(pos) = fill_pos(board, position) { error = Some(pos) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | fn is_empty_at_pos(board: &Board, (r, c): Position) -> bool { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:202:31 [INFO] [stderr] | [INFO] [stderr] 202 | fn pick_random_pos(positions: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Position]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.16s [INFO] running `"docker" "inspect" "f0773630e08691232dd03a38f3b5169f870344fb4b2740755667f11d79e68552"` [INFO] running `"docker" "rm" "-f" "f0773630e08691232dd03a38f3b5169f870344fb4b2740755667f11d79e68552"` [INFO] [stdout] f0773630e08691232dd03a38f3b5169f870344fb4b2740755667f11d79e68552