[INFO] updating cached repository slavam2605/factorio-recipes-planner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/slavam2605/factorio-recipes-planner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/slavam2605/factorio-recipes-planner" "work/ex/clippy-test-run/sources/stable/gh/slavam2605/factorio-recipes-planner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/slavam2605/factorio-recipes-planner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/slavam2605/factorio-recipes-planner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slavam2605/factorio-recipes-planner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slavam2605/factorio-recipes-planner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 06f9158cd15f74e5d2a52b24db116e795c7f1e21 [INFO] sha for GitHub repo slavam2605/factorio-recipes-planner: 06f9158cd15f74e5d2a52b24db116e795c7f1e21 [INFO] validating manifest of slavam2605/factorio-recipes-planner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slavam2605/factorio-recipes-planner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slavam2605/factorio-recipes-planner [INFO] finished frobbing slavam2605/factorio-recipes-planner [INFO] frobbed toml for slavam2605/factorio-recipes-planner written to work/ex/clippy-test-run/sources/stable/gh/slavam2605/factorio-recipes-planner/Cargo.toml [INFO] started frobbing slavam2605/factorio-recipes-planner [INFO] finished frobbing slavam2605/factorio-recipes-planner [INFO] frobbed toml for slavam2605/factorio-recipes-planner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slavam2605/factorio-recipes-planner/Cargo.toml [INFO] crate slavam2605/factorio-recipes-planner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slavam2605/factorio-recipes-planner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/slavam2605/factorio-recipes-planner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dfe17b2ac46124187058ace5ff0d315cc3120cc69cc6802d520af0ce78566fec [INFO] running `"docker" "start" "-a" "dfe17b2ac46124187058ace5ff0d315cc3120cc69cc6802d520af0ce78566fec"` [INFO] [stderr] Checking libc v0.2.19 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking nom v2.0.1 [INFO] [stderr] Checking factorio_recipes_planner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:109:46 [INFO] [stderr] | [INFO] [stderr] 109 | plan.insert(v.clone(), Param{time: time, rate: rate}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:109:46 [INFO] [stderr] | [INFO] [stderr] 109 | plan.insert(v.clone(), Param{time: time, rate: rate}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:109:58 [INFO] [stderr] | [INFO] [stderr] 109 | plan.insert(v.clone(), Param{time: time, rate: rate}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | out.push((v, Param{time: time, rate: rate})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:110:48 [INFO] [stderr] | [INFO] [stderr] 110 | out.push((v, Param{time: time, rate: rate})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | AssemblePlan{out: out, compounds: plan} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | compounds: compounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | time_factor: time_factor [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:109:58 [INFO] [stderr] | [INFO] [stderr] 109 | plan.insert(v.clone(), Param{time: time, rate: rate}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | out.push((v, Param{time: time, rate: rate})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:110:48 [INFO] [stderr] | [INFO] [stderr] 110 | out.push((v, Param{time: time, rate: rate})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | AssemblePlan{out: out, compounds: plan} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | compounds: compounds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/planner.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | time_factor: time_factor [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time_factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(box_syntax)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(box_patterns)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #![feature(i128_type)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `factorio_recipes_planner`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(box_syntax)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/main.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(box_patterns)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #![feature(i128_type)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `factorio_recipes_planner`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/planner.rs:103:47 [INFO] [stderr] | [INFO] [stderr] 103 | rate += edge.weight * plan.get(&edge.from).unwrap().rate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&plan[&edge.from]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | for line in s.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | let parts: Vec<_> = line.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:137:66 [INFO] [stderr] | [INFO] [stderr] 137 | let compounds: Vec<_> = parts[3].replace("\"", "").split("|").map(|s| { [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/planner.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if output != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(output - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/planner.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if output != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/planner.rs:199:16 [INFO] [stderr] | [INFO] [stderr] 199 | if let None = time { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 200 | | println!(" {}: rate = {} parts/min", component, rate * 60.0); [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________- help: try this: `if time.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `factorio_recipes_planner`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/planner.rs:103:47 [INFO] [stderr] | [INFO] [stderr] 103 | rate += edge.weight * plan.get(&edge.from).unwrap().rate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&plan[&edge.from]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | for line in s.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | let parts: Vec<_> = line.split("\t").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/planner.rs:137:66 [INFO] [stderr] | [INFO] [stderr] 137 | let compounds: Vec<_> = parts[3].replace("\"", "").split("|").map(|s| { [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/planner.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if output != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(output - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/planner.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if output != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/planner.rs:199:16 [INFO] [stderr] | [INFO] [stderr] 199 | if let None = time { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 200 | | println!(" {}: rate = {} parts/min", component, rate * 60.0); [INFO] [stderr] 201 | | } [INFO] [stderr] | |_________- help: try this: `if time.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `factorio_recipes_planner`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dfe17b2ac46124187058ace5ff0d315cc3120cc69cc6802d520af0ce78566fec"` [INFO] running `"docker" "rm" "-f" "dfe17b2ac46124187058ace5ff0d315cc3120cc69cc6802d520af0ce78566fec"` [INFO] [stdout] dfe17b2ac46124187058ace5ff0d315cc3120cc69cc6802d520af0ce78566fec