[INFO] updating cached repository slava-sh/rust-bundler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/slava-sh/rust-bundler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/slava-sh/rust-bundler" "work/ex/clippy-test-run/sources/stable/gh/slava-sh/rust-bundler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/slava-sh/rust-bundler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/slava-sh/rust-bundler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slava-sh/rust-bundler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slava-sh/rust-bundler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8f1ac0e50347cdb2d6aa4a6eafc4b998ce84948b [INFO] sha for GitHub repo slava-sh/rust-bundler: 8f1ac0e50347cdb2d6aa4a6eafc4b998ce84948b [INFO] validating manifest of slava-sh/rust-bundler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slava-sh/rust-bundler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slava-sh/rust-bundler [INFO] finished frobbing slava-sh/rust-bundler [INFO] frobbed toml for slava-sh/rust-bundler written to work/ex/clippy-test-run/sources/stable/gh/slava-sh/rust-bundler/Cargo.toml [INFO] started frobbing slava-sh/rust-bundler [INFO] finished frobbing slava-sh/rust-bundler [INFO] frobbed toml for slava-sh/rust-bundler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slava-sh/rust-bundler/Cargo.toml [INFO] crate slava-sh/rust-bundler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slava-sh/rust-bundler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/slava-sh/rust-bundler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 686e753c09f0e19de1291401a9ac41459c14d121b2166a06df044347e6c398a4 [INFO] running `"docker" "start" "-a" "686e753c09f0e19de1291401a9ac41459c14d121b2166a06df044347e6c398a4"` [INFO] [stderr] Compiling rustc-demangle v0.1.7 [INFO] [stderr] Compiling pulldown-cmark v0.1.2 [INFO] [stderr] Compiling itoa v0.4.1 [INFO] [stderr] Compiling remove_dir_all v0.5.1 [INFO] [stderr] Compiling same-file v0.1.3 [INFO] [stderr] Compiling bytecount v0.2.0 [INFO] [stderr] Compiling rustfmt v0.10.0 [INFO] [stderr] Checking diff v0.1.11 [INFO] [stderr] Checking environment v0.1.1 [INFO] [stderr] Checking difference v1.0.0 [INFO] [stderr] Checking proc-macro2 v0.3.6 [INFO] [stderr] Checking difference v0.4.1 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling walkdir v1.0.7 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking strings v0.1.1 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Compiling backtrace v0.3.6 [INFO] [stderr] Checking goldenfile v0.5.1 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling serde_derive v1.0.42 [INFO] [stderr] Compiling serde v1.0.42 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.16 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Checking syntex_pos v0.59.1 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Compiling rustc_version v0.2.2 [INFO] [stderr] Checking syntex_errors v0.59.1 [INFO] [stderr] Compiling extprim v1.5.1 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Checking cargo_metadata v0.5.4 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Checking syntex_syntax v0.59.1 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] Checking bundler v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(bins.len() != 0, "no binary target found"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bins.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(bins.len() != 0, "no binary target found"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bins.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/golden.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | const INPUT_DIR: &'static str = "tests/testdata/input"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/golden.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | const OUTPUT_DIR: &'static str = "tests/testdata/output"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 44s [INFO] running `"docker" "inspect" "686e753c09f0e19de1291401a9ac41459c14d121b2166a06df044347e6c398a4"` [INFO] running `"docker" "rm" "-f" "686e753c09f0e19de1291401a9ac41459c14d121b2166a06df044347e6c398a4"` [INFO] [stdout] 686e753c09f0e19de1291401a9ac41459c14d121b2166a06df044347e6c398a4