[INFO] updating cached repository skrylnikov/rust-factorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/skrylnikov/rust-factorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/skrylnikov/rust-factorial" "work/ex/clippy-test-run/sources/stable/gh/skrylnikov/rust-factorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/skrylnikov/rust-factorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/skrylnikov/rust-factorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skrylnikov/rust-factorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skrylnikov/rust-factorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 16e491601fd5f2cfdc4fc6110cd3cf2905f7af6c [INFO] sha for GitHub repo skrylnikov/rust-factorial: 16e491601fd5f2cfdc4fc6110cd3cf2905f7af6c [INFO] validating manifest of skrylnikov/rust-factorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skrylnikov/rust-factorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skrylnikov/rust-factorial [INFO] finished frobbing skrylnikov/rust-factorial [INFO] frobbed toml for skrylnikov/rust-factorial written to work/ex/clippy-test-run/sources/stable/gh/skrylnikov/rust-factorial/Cargo.toml [INFO] started frobbing skrylnikov/rust-factorial [INFO] finished frobbing skrylnikov/rust-factorial [INFO] frobbed toml for skrylnikov/rust-factorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skrylnikov/rust-factorial/Cargo.toml [INFO] crate skrylnikov/rust-factorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skrylnikov/rust-factorial against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/skrylnikov/rust-factorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bce8a3f19cd3c5f2363b4e82e157c0bb66c1077ee9e4c0aa882b7f95905ce77b [INFO] running `"docker" "start" "-a" "bce8a3f19cd3c5f2363b4e82e157c0bb66c1077ee9e4c0aa882b7f95905ce77b"` [INFO] [stderr] Checking rust-gmp v0.5.0 [INFO] [stderr] Checking factorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:37:32 [INFO] [stderr] | [INFO] [stderr] 37 | elapsed.subsec_nanos() / 1000_000 [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:37:32 [INFO] [stderr] | [INFO] [stderr] 37 | elapsed.subsec_nanos() / 1000_000 [INFO] [stderr] | ^^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | for i in 1..x + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | elapsed.subsec_nanos() / 1000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | for i in 1..x + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | elapsed.subsec_nanos() / 1000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `elapsed.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.77s [INFO] running `"docker" "inspect" "bce8a3f19cd3c5f2363b4e82e157c0bb66c1077ee9e4c0aa882b7f95905ce77b"` [INFO] running `"docker" "rm" "-f" "bce8a3f19cd3c5f2363b4e82e157c0bb66c1077ee9e4c0aa882b7f95905ce77b"` [INFO] [stdout] bce8a3f19cd3c5f2363b4e82e157c0bb66c1077ee9e4c0aa882b7f95905ce77b