[INFO] updating cached repository skk/git_submodules
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/skk/git_submodules
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/skk/git_submodules" "work/ex/clippy-test-run/sources/stable/gh/skk/git_submodules"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/skk/git_submodules'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/skk/git_submodules" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skk/git_submodules"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skk/git_submodules'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 322256bc27880b3007089fce9b68e67ef3bcaceb
[INFO] sha for GitHub repo skk/git_submodules: 322256bc27880b3007089fce9b68e67ef3bcaceb
[INFO] validating manifest of skk/git_submodules on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of skk/git_submodules on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing skk/git_submodules
[INFO] finished frobbing skk/git_submodules
[INFO] frobbed toml for skk/git_submodules written to work/ex/clippy-test-run/sources/stable/gh/skk/git_submodules/Cargo.toml
[INFO] started frobbing skk/git_submodules
[INFO] finished frobbing skk/git_submodules
[INFO] frobbed toml for skk/git_submodules written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skk/git_submodules/Cargo.toml
[INFO] crate skk/git_submodules has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting skk/git_submodules against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/skk/git_submodules:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 71d193e71439a1bbc28eff60468fc930ebde19771eacb776bc44a940f4650e87
[INFO] running `"docker" "start" "-a" "71d193e71439a1bbc28eff60468fc930ebde19771eacb776bc44a940f4650e87"`
[INFO] [stderr]    Compiling cmake v0.1.31
[INFO] [stderr]    Compiling libz-sys v1.0.18
[INFO] [stderr]    Compiling curl-sys v0.4.5
[INFO] [stderr]    Compiling libssh2-sys v0.2.7
[INFO] [stderr]    Compiling libgit2-sys v0.7.1
[INFO] [stderr]     Checking git2 v0.7.1
[INFO] [stderr]     Checking git_submodules v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/arguments.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     matches
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/arguments.rs:5:19
[INFO] [stderr]    |
[INFO] [stderr] 5  |       let matches = App::new("git_submodules")
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 6  | |         .author(crate_authors!())
[INFO] [stderr] 7  | |         .version(crate_version!())
[INFO] [stderr] 8  | |         .subcommand(SubCommand::with_name("generate_json_file")
[INFO] [stderr] ...  |
[INFO] [stderr] 13 | |         )
[INFO] [stderr] 14 | |         .get_matches();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/arguments.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     matches
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/arguments.rs:5:19
[INFO] [stderr]    |
[INFO] [stderr] 5  |       let matches = App::new("git_submodules")
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 6  | |         .author(crate_authors!())
[INFO] [stderr] 7  | |         .version(crate_version!())
[INFO] [stderr] 8  | |         .subcommand(SubCommand::with_name("generate_json_file")
[INFO] [stderr] ...  |
[INFO] [stderr] 13 | |         )
[INFO] [stderr] 14 | |         .get_matches();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `repo`
[INFO] [stderr]   --> src/app.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     repo: Repository,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/app.rs:77:37
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 if name.starts_with(".") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `repo`
[INFO] [stderr]   --> src/app.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     repo: Repository,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/app.rs:77:37
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 if name.starts_with(".") {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3m 02s
[INFO] running `"docker" "inspect" "71d193e71439a1bbc28eff60468fc930ebde19771eacb776bc44a940f4650e87"`
[INFO] running `"docker" "rm" "-f" "71d193e71439a1bbc28eff60468fc930ebde19771eacb776bc44a940f4650e87"`
[INFO] [stdout] 71d193e71439a1bbc28eff60468fc930ebde19771eacb776bc44a940f4650e87