[INFO] updating cached repository skirino/direnv_rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/skirino/direnv_rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/skirino/direnv_rust" "work/ex/clippy-test-run/sources/stable/gh/skirino/direnv_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/skirino/direnv_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/skirino/direnv_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skirino/direnv_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skirino/direnv_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5dc752fd03a7c69cd2bd39646a4b4fbe89b0ca88
[INFO] sha for GitHub repo skirino/direnv_rust: 5dc752fd03a7c69cd2bd39646a4b4fbe89b0ca88
[INFO] validating manifest of skirino/direnv_rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of skirino/direnv_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing skirino/direnv_rust
[INFO] finished frobbing skirino/direnv_rust
[INFO] frobbed toml for skirino/direnv_rust written to work/ex/clippy-test-run/sources/stable/gh/skirino/direnv_rust/Cargo.toml
[INFO] started frobbing skirino/direnv_rust
[INFO] finished frobbing skirino/direnv_rust
[INFO] frobbed toml for skirino/direnv_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skirino/direnv_rust/Cargo.toml
[INFO] crate skirino/direnv_rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting skirino/direnv_rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/skirino/direnv_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 054249e417876c172e75eb4378ffa9779deb3c1aa98eb649d318e7499e2336e7
[INFO] running `"docker" "start" "-a" "054249e417876c172e75eb4378ffa9779deb3c1aa98eb649d318e7499e2336e7"`
[INFO] [stderr]     Checking serde v0.9.12
[INFO] [stderr]    Compiling syn v0.11.9
[INFO] [stderr]    Compiling serde_codegen_internals v0.14.2
[INFO] [stderr]    Compiling serde_derive v0.9.12
[INFO] [stderr]     Checking serde_json v0.9.9
[INFO] [stderr]     Checking direnv_rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]  --> src/output.rs:4:69
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn print_shell_command_without_log(k: &str, o: &Option<String>) -> () {
[INFO] [stderr]   |                                                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]  --> src/output.rs:8:66
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn print_shell_command_with_log(k: &str, o: &Option<String>) -> () {
[INFO] [stderr]   |                                                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/output.rs:21:29
[INFO] [stderr]    |
[INFO] [stderr] 21 | pub fn log_green(msg: &str) -> () {
[INFO] [stderr]    |                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/output.rs:25:27
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub fn log_red(msg: &str) -> () {
[INFO] [stderr]    |                           ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/output.rs:29:34
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn log(color: Colour, msg: &str) -> () {
[INFO] [stderr]    |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:23:60
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn merge_undoes(undo: &[Entry], var_changes: &mut VarsMap) -> () {
[INFO] [stderr]    |                                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/main.rs:100:21
[INFO] [stderr]     |
[INFO] [stderr] 100 | const DIRENV_RUST: &'static str = "DIRENV_RUST";
[INFO] [stderr]     |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:102:29
[INFO] [stderr]     |
[INFO] [stderr] 102 | fn load(current_dir: &Path) -> () {
[INFO] [stderr]     |                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:139:32
[INFO] [stderr]     |
[INFO] [stderr] 139 | fn mark_as_allowed(dir: &Path) -> () {
[INFO] [stderr]     |                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]  --> src/output.rs:4:69
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn print_shell_command_without_log(k: &str, o: &Option<String>) -> () {
[INFO] [stderr]   |                                                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]  --> src/output.rs:8:66
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn print_shell_command_with_log(k: &str, o: &Option<String>) -> () {
[INFO] [stderr]   |                                                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/output.rs:21:29
[INFO] [stderr]    |
[INFO] [stderr] 21 | pub fn log_green(msg: &str) -> () {
[INFO] [stderr]    |                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/output.rs:25:27
[INFO] [stderr]    |
[INFO] [stderr] 25 | pub fn log_red(msg: &str) -> () {
[INFO] [stderr]    |                           ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/output.rs:29:34
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn log(color: Colour, msg: &str) -> () {
[INFO] [stderr]    |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/main.rs:23:60
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn merge_undoes(undo: &[Entry], var_changes: &mut VarsMap) -> () {
[INFO] [stderr]    |                                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/main.rs:100:21
[INFO] [stderr]     |
[INFO] [stderr] 100 | const DIRENV_RUST: &'static str = "DIRENV_RUST";
[INFO] [stderr]     |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:102:29
[INFO] [stderr]     |
[INFO] [stderr] 102 | fn load(current_dir: &Path) -> () {
[INFO] [stderr]     |                             ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:139:32
[INFO] [stderr]     |
[INFO] [stderr] 139 | fn mark_as_allowed(dir: &Path) -> () {
[INFO] [stderr]     |                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/envfile.rs:64:20
[INFO] [stderr]    |
[INFO] [stderr] 64 |     let mut path = env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/envfile.rs:64:20
[INFO] [stderr]    |
[INFO] [stderr] 64 |     let mut path = env::home_dir().unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/envfile.rs:59:49
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn is_allowed(env_file_path: &PathBuf, content: &String) -> bool {
[INFO] [stderr]    |                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/envfile.rs:63:54
[INFO] [stderr]    |
[INFO] [stderr] 63 | fn allow_file_path(env_file_path: &PathBuf, content: &String) -> PathBuf {
[INFO] [stderr]    |                                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/envfile.rs:71:42
[INFO] [stderr]    |
[INFO] [stderr] 71 | fn compute_hash(path: &PathBuf, content: &String) -> String {
[INFO] [stderr]    |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:18:35
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn split_undo_and_kept<'a>(stack: &'a Stack, current_dir: &Path) -> (&'a [Entry], &'a [Entry]) {
[INFO] [stderr]    |                                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:84:40
[INFO] [stderr]    |
[INFO] [stderr] 84 | fn add_changes(dir: &PathBuf, changes: &VarChangesVec, var_changes_so_far: &mut VarsMap) -> Entry {
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:88:44
[INFO] [stderr]    |
[INFO] [stderr] 88 |         changes_by_name.entry(key.clone()).or_insert(Vec::new()).push(change.clone());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/envfile.rs:59:49
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn is_allowed(env_file_path: &PathBuf, content: &String) -> bool {
[INFO] [stderr]    |                                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/envfile.rs:63:54
[INFO] [stderr]    |
[INFO] [stderr] 63 | fn allow_file_path(env_file_path: &PathBuf, content: &String) -> PathBuf {
[INFO] [stderr]    |                                                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/envfile.rs:71:42
[INFO] [stderr]    |
[INFO] [stderr] 71 | fn compute_hash(path: &PathBuf, content: &String) -> String {
[INFO] [stderr]    |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:18:35
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn split_undo_and_kept<'a>(stack: &'a Stack, current_dir: &Path) -> (&'a [Entry], &'a [Entry]) {
[INFO] [stderr]    |                                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:84:40
[INFO] [stderr]    |
[INFO] [stderr] 84 | fn add_changes(dir: &PathBuf, changes: &VarChangesVec, var_changes_so_far: &mut VarsMap) -> Entry {
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/main.rs:88:44
[INFO] [stderr]    |
[INFO] [stderr] 88 |         changes_by_name.entry(key.clone()).or_insert(Vec::new()).push(change.clone());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 17.09s
[INFO] running `"docker" "inspect" "054249e417876c172e75eb4378ffa9779deb3c1aa98eb649d318e7499e2336e7"`
[INFO] running `"docker" "rm" "-f" "054249e417876c172e75eb4378ffa9779deb3c1aa98eb649d318e7499e2336e7"`
[INFO] [stdout] 054249e417876c172e75eb4378ffa9779deb3c1aa98eb649d318e7499e2336e7