[INFO] updating cached repository skaggmannen/rusty-keydata
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/skaggmannen/rusty-keydata
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/skaggmannen/rusty-keydata" "work/ex/clippy-test-run/sources/stable/gh/skaggmannen/rusty-keydata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/skaggmannen/rusty-keydata'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/skaggmannen/rusty-keydata" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skaggmannen/rusty-keydata"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skaggmannen/rusty-keydata'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ca5a26eda960af047473d9c8b51b2753a68c325d
[INFO] sha for GitHub repo skaggmannen/rusty-keydata: ca5a26eda960af047473d9c8b51b2753a68c325d
[INFO] validating manifest of skaggmannen/rusty-keydata on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of skaggmannen/rusty-keydata on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing skaggmannen/rusty-keydata
[INFO] finished frobbing skaggmannen/rusty-keydata
[INFO] frobbed toml for skaggmannen/rusty-keydata written to work/ex/clippy-test-run/sources/stable/gh/skaggmannen/rusty-keydata/Cargo.toml
[INFO] started frobbing skaggmannen/rusty-keydata
[INFO] finished frobbing skaggmannen/rusty-keydata
[INFO] frobbed toml for skaggmannen/rusty-keydata written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skaggmannen/rusty-keydata/Cargo.toml
[INFO] crate skaggmannen/rusty-keydata has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting skaggmannen/rusty-keydata against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/skaggmannen/rusty-keydata:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ca0522d383362247c23b1148175aeb5740881ec38696793fa06891fdafa5e6fe
[INFO] running `"docker" "start" "-a" "ca0522d383362247c23b1148175aeb5740881ec38696793fa06891fdafa5e6fe"`
[INFO] [stderr]     Checking key-data v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/keydata/singleblock.rs:8:13
[INFO] [stderr]   |
[INFO] [stderr] 8 |             format: format,
[INFO] [stderr]   |             ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/keydata/singleblock.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             key_id: key_id,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/keydata/singleblock.rs:168:17
[INFO] [stderr]     |
[INFO] [stderr] 168 |                 offset: offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/keydata/singleblock.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 offset: offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]  --> src/keydata/singleblock.rs:8:13
[INFO] [stderr]   |
[INFO] [stderr] 8 |             format: format,
[INFO] [stderr]   |             ^^^^^^^^^^^^^^ help: replace it with: `format`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/keydata/singleblock.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             key_id: key_id,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/keydata/singleblock.rs:168:17
[INFO] [stderr]     |
[INFO] [stderr] 168 |                 offset: offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/keydata/singleblock.rs:184:17
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 offset: offset,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/keydata/singleblock.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return offset;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/keydata/singleblock.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         return offset;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |       if let Some(_) = matches.subcommand_matches("create") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 25 | |         let key_data = keydata::singleblock::SingleBlock::new(0xaa_bb_cc_dd)
[INFO] [stderr] 26 | |                                 .with_valid_until(0x09_08_07_06)
[INFO] [stderr] 27 | |                                 .with_overriding_access(&[101], 1)
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("create").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:32:19
[INFO] [stderr]    |
[INFO] [stderr] 32 |       } else if let Some(_) = matches.subcommand_matches("read") {
[INFO] [stderr]    |  ____________-      ^^^^^^^
[INFO] [stderr] 33 | |
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("read").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |       if let Some(_) = matches.subcommand_matches("create") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 25 | |         let key_data = keydata::singleblock::SingleBlock::new(0xaa_bb_cc_dd)
[INFO] [stderr] 26 | |                                 .with_valid_until(0x09_08_07_06)
[INFO] [stderr] 27 | |                                 .with_overriding_access(&[101], 1)
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("create").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:32:19
[INFO] [stderr]    |
[INFO] [stderr] 32 |       } else if let Some(_) = matches.subcommand_matches("read") {
[INFO] [stderr]    |  ____________-      ^^^^^^^
[INFO] [stderr] 33 | |
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("read").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.07s
[INFO] running `"docker" "inspect" "ca0522d383362247c23b1148175aeb5740881ec38696793fa06891fdafa5e6fe"`
[INFO] running `"docker" "rm" "-f" "ca0522d383362247c23b1148175aeb5740881ec38696793fa06891fdafa5e6fe"`
[INFO] [stdout] ca0522d383362247c23b1148175aeb5740881ec38696793fa06891fdafa5e6fe