[INFO] updating cached repository skade/rust-three-days-course [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/skade/rust-three-days-course [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/skade/rust-three-days-course" "work/ex/clippy-test-run/sources/stable/gh/skade/rust-three-days-course"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/skade/rust-three-days-course'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/skade/rust-three-days-course" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skade/rust-three-days-course"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skade/rust-three-days-course'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3cb312e9eeb4cbee34eefdd796154ae81ce516d4 [INFO] sha for GitHub repo skade/rust-three-days-course: 3cb312e9eeb4cbee34eefdd796154ae81ce516d4 [INFO] validating manifest of skade/rust-three-days-course on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skade/rust-three-days-course on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skade/rust-three-days-course [INFO] finished frobbing skade/rust-three-days-course [INFO] frobbed toml for skade/rust-three-days-course written to work/ex/clippy-test-run/sources/stable/gh/skade/rust-three-days-course/Cargo.toml [INFO] started frobbing skade/rust-three-days-course [INFO] finished frobbing skade/rust-three-days-course [INFO] frobbed toml for skade/rust-three-days-course written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skade/rust-three-days-course/Cargo.toml [INFO] crate skade/rust-three-days-course has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skade/rust-three-days-course against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/skade/rust-three-days-course:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2921162706a9a32f6bc801622eac5c9411cf826d8f58b892f86acffea93fbef [INFO] running `"docker" "start" "-a" "b2921162706a9a32f6bc801622eac5c9411cf826d8f58b892f86acffea93fbef"` [INFO] [stderr] Checking shells v0.2.0 [INFO] [stderr] Checking pandoc_types v0.1.0 [INFO] [stderr] Checking tasks v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | pub const LOCALES: [&'static str; 3] = ["en-US", "es-ES", "de-DE"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | pub const LOCALES: [&'static str; 3] = ["en-US", "es-ES", "de-DE"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/build-indices.rs:11:52 [INFO] [stderr] | [INFO] [stderr] 11 | let new_name = format!("{}{}", &file.split(".").nth(0).unwrap(), ".html"); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/rename-chapters.rs:15:56 [INFO] [stderr] | [INFO] [stderr] 15 | let new_name = format!("{}{}", &file.split(".").nth(0).unwrap(), ".chapter"); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/build-indices.rs:11:52 [INFO] [stderr] | [INFO] [stderr] 11 | let new_name = format!("{}{}", &file.split(".").nth(0).unwrap(), ".html"); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/rename-chapters.rs:15:56 [INFO] [stderr] | [INFO] [stderr] 15 | let new_name = format!("{}{}", &file.split(".").nth(0).unwrap(), ".chapter"); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/extract-code.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / if let &mut Block::CodeBlock(ref attributes, ref content) = block { [INFO] [stderr] 44 | | let code_lang = match attributes.1.first() { [INFO] [stderr] 45 | | Some(lang) => lang, [INFO] [stderr] 46 | | None => "output" [INFO] [stderr] ... | [INFO] [stderr] 63 | | blocknumber += 1; [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | if let Block::CodeBlock(ref attributes, ref content) = *block { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/extract-code.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / if let &mut Block::CodeBlock(ref attributes, ref content) = block { [INFO] [stderr] 44 | | let code_lang = match attributes.1.first() { [INFO] [stderr] 45 | | Some(lang) => lang, [INFO] [stderr] 46 | | None => "output" [INFO] [stderr] ... | [INFO] [stderr] 63 | | blocknumber += 1; [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | if let Block::CodeBlock(ref attributes, ref content) = *block { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.59s [INFO] running `"docker" "inspect" "b2921162706a9a32f6bc801622eac5c9411cf826d8f58b892f86acffea93fbef"` [INFO] running `"docker" "rm" "-f" "b2921162706a9a32f6bc801622eac5c9411cf826d8f58b892f86acffea93fbef"` [INFO] [stdout] b2921162706a9a32f6bc801622eac5c9411cf826d8f58b892f86acffea93fbef